From: guanjx09@163.com (guanjx09)
Subject: [PATCH 1/2] nvme-cli: add fields into identify controller data structure
Date: Sat, 3 Jun 2017 11:08:54 +0800 [thread overview]
Message-ID: <e704f915-f08f-6fe9-1132-81d7b6845c7d@163.com> (raw)
In-Reply-To: <20170602074600.GA11424@infradead.org>
Hi,Christoph
On Friday, June 02, 2017 03:46 PM, Christoph Hellwig wrote:
> Please also add them to the kernel copy of the header so that they
> stay in sync. Except for that his looks fine to me:
>
> Reviewed-by: Christoph Hellwig <hch at lst.de>
>
Here is the patch which adds those fields into nvme_id_ctrl structure
in the kernel copy of the header. Does it looks good?
Thanks for your review.
Best ,
Guan Junxiong
---
>From 5f6fa71d885e7cb64cdf5a5ef5e03cee5a5f6f52 Mon Sep 17 00:00:00 2001
From: Guan Junxiong <guanjunxiong@huawei.com>
Date: Fri, 2 Jun 2017 23:13:28 +0800
Subject: [PATCH] nvme: add fields into identify controller data structure
NVMe 1.3 inctrodues new fields such as EDSTT, DSTO, FWUG, HCTMA, MNTMT,
MXTMT, SANICAP into the idenfity controller data structure. So we add
them for later use.
---
include/linux/nvme.h | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/include/linux/nvme.h b/include/linux/nvme.h
index b625bac..e5f09f8 100644
--- a/include/linux/nvme.h
+++ b/include/linux/nvme.h
@@ -207,9 +207,15 @@ struct nvme_id_ctrl {
__u8 tnvmcap[16];
__u8 unvmcap[16];
__le32 rpmbs;
- __u8 rsvd316[4];
+ __le16 edstt;
+ __u8 dsto;
+ __u8 fwug;
__le16 kas;
- __u8 rsvd322[190];
+ __le16 hctma;
+ __le16 mntmt;
+ __le16 mxtmt;
+ __le32 sanicap;
+ __u8 rsvd332[180];
__u8 sqes;
__u8 cqes;
__le16 maxcmd;
--
2.7.4
next prev parent reply other threads:[~2017-06-03 3:08 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-02 7:18 [PATCH 0/2]nvme-cli: id-ctrl supports NVMe 1.3 spec Guan Junxiong
2017-06-02 7:18 ` [PATCH 1/2] nvme-cli: add fields into identify controller data structure Guan Junxiong
2017-06-02 7:46 ` Christoph Hellwig
2017-06-03 3:08 ` guanjx09 [this message]
2017-06-03 5:25 ` Christoph Hellwig
[not found] ` <71e89de.8c54.15c69866ff6.Coremail.guanjx09@163.com>
2017-06-03 5:25 ` Christoph Hellwig
2017-06-04 15:20 ` Sagi Grimberg
2017-06-12 16:11 ` Christoph Hellwig
2017-06-13 1:31 ` Guan Junxiong
2017-06-04 15:20 ` Sagi Grimberg
2017-06-02 7:18 ` [PATCH 2/2] nvme-cli: show more fields for id-ctrl Guan Junxiong
2017-06-02 7:46 ` Christoph Hellwig
2017-06-04 15:22 ` Sagi Grimberg
2017-06-12 14:30 ` Keith Busch
2017-06-13 1:37 ` Guan Junxiong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e704f915-f08f-6fe9-1132-81d7b6845c7d@163.com \
--to=guanjx09@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.