From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16AB2C433FE for ; Mon, 17 Oct 2022 14:14:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230308AbiJQOOm (ORCPT ); Mon, 17 Oct 2022 10:14:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49278 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230288AbiJQOOi (ORCPT ); Mon, 17 Oct 2022 10:14:38 -0400 Received: from mail-wr1-x430.google.com (mail-wr1-x430.google.com [IPv6:2a00:1450:4864:20::430]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1971C11A2A for ; Mon, 17 Oct 2022 07:14:35 -0700 (PDT) Received: by mail-wr1-x430.google.com with SMTP id u10so18703113wrq.2 for ; Mon, 17 Oct 2022 07:14:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Vq5kCnUtoL+6Ezgs4d51zvzN1gUGsMC/kvnhiOvxhZA=; b=tz3RbYuUFruNlDazal9vUSlnltiLDHvOxIl0LPUBuv6NxoHo4Vq9jqpO+al2nQKQI5 jgcl8xIehpkHmpp4r4Q+IWD+dhvC9i80tQ5Wzp5nQou+s9jLpG8rhqY+Uh7I5z9wMxlt QF2zH65EKK1nXRdZNuvu7k7GEGtmX3+rZ5JWHfOoipbWSqjwn6KyzKKMzAZ85ZEuOHMV bpTAOFrf+BiU+6sZmU/F2OjMtWb1YvTZFJTAJeSXADdnC0J3jbbszwQAP0UX8EnC6t2Q DvyGE8C+YTFM/9xHctANb6CMFAo6zi46s9s+OfhIkFxaQNacgLnWj/3UByTYBYsKua1p 9K6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Vq5kCnUtoL+6Ezgs4d51zvzN1gUGsMC/kvnhiOvxhZA=; b=Tw/VDvJ1sB64YXbCs0QrAG6k13MrvtZbqrPP3FXSkg8cbyXKSwx4xuFYJKUGZj1egr B+D0vJpqUyKilZIyJZP+EzAt2nSYkQvlcM7TCgsKWF9i2BD3j1q63PsAnvK8tG/54ffc +5VG1K66+zp5+ye7rohu+/jEcIJlDQxHtBvU6v+My/Lx7KumzRLSw3BB6faBxhyQ+VBC WMby1h1197hYL7PLiqWPqOn0hUshCt9JoI9HSvJbwHOL0IQEK/r22JiMG3zwgFPQNNUZ Ax+oasPY5FGxPKAbZlZFtt2IQnhH7LTWWbk+JPBQCCi4rC95RlJgMK+uvsmrXH28gOBF AGMw== X-Gm-Message-State: ACrzQf1SBTyZmSOXPkVw4eI+KQSq4GYs2aOBx2EhgBeCKhqBFwd9A25w MENWQeiJUdTmIL/fBXndy+F2SA== X-Google-Smtp-Source: AMsMyM7CM0UpKnoMrB0XCN0oLx3Pp5aNEqNuOcOBP8m2CUuk58Y8mdiVuC8BXiFJDuJcLQxlD0XrEg== X-Received: by 2002:adf:fd4a:0:b0:22d:d3aa:e004 with SMTP id h10-20020adffd4a000000b0022dd3aae004mr6402643wrs.173.1666016073416; Mon, 17 Oct 2022 07:14:33 -0700 (PDT) Received: from ?IPV6:2a05:6e02:1041:c10:ea6:24ea:3fe7:64b9? ([2a05:6e02:1041:c10:ea6:24ea:3fe7:64b9]) by smtp.googlemail.com with ESMTPSA id x17-20020adff0d1000000b00231ed902a4esm8608659wro.5.2022.10.17.07.14.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 17 Oct 2022 07:14:33 -0700 (PDT) Message-ID: Date: Mon, 17 Oct 2022 16:14:31 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] thermal/drivers/exynos: Fix NULL pointer dereference when getting the critical temp Content-Language: en-US To: Marek Szyprowski , rafael@kernel.org Cc: Bartlomiej Zolnierkiewicz , Krzysztof Kozlowski , Amit Kucheria , Zhang Rui , Alim Akhtar , "open list:SAMSUNG THERMAL DRIVER" , "open list:SAMSUNG THERMAL DRIVER" , "moderated list:ARM/SAMSUNG S3C, S5P AND EXYNOS ARM ARCHITECTURES" , open list References: <4e4d873b-4a40-334a-34e7-defb0fcc4e6b@samsung.com> <20221003132943.1383065-1-daniel.lezcano@linaro.org> <1155a694-b821-d41a-da54-8a9656d90e50@samsung.com> From: Daniel Lezcano In-Reply-To: <1155a694-b821-d41a-da54-8a9656d90e50@samsung.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 17/10/2022 15:48, Marek Szyprowski wrote: > Hi Daniel, > > On 03.10.2022 15:29, Daniel Lezcano wrote: >> The driver is assuming the get_critical temperature exists as it is >> inherited by the thermal of ops. But this one has been removed in >> favor of the generic one. >> >> Use the generic thermal_zone_get_crit_temp() function instead >> >> Fixes: 13bea86623b ("thermal/of: Remove of_thermal_get_crit_temp(") >> Reported-by: Marek Szyprowski >> Signed-off-by: Daniel Lezcano > > This patch has been dropped from -next, is there are reason for that? No, my mistake. I dropped it accidentally when I rebased the branch. Thanks for pointing it out. -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1D9BFC433FE for ; Mon, 17 Oct 2022 14:15:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=uMuJykFpM+9CuPX9Hprep1iSmucs0NF00o60OlkCSpc=; b=xvAyEO6w4iQzVp OhJeP5qgbbO41jI5YhrXj7nCRVAYPxDMEWmzi3sjuGWg6D1YE6Wq7bZa1cmFz/kcRM60werEoxz9d JjpZIXCZ6Zj15xY6HEDfoACE/TjRhCPsZjzUuv2zbgGgXhi0JPI931RafGqNBmFZW7GGtbJCDjJTF PcTNk+4iLKQhSN9C5FvsFAwOzRk2nkHel/D1W6lSUid7Qh5MtGRTQQLYIxttzXp3xmW/Yk+REpHz2 PvdoFMjz4Zc742WwwbUJZNu+SbqD33tkLWjwLPCQtQ51n1xeTTkGAYmQJ3OluVhJqxRGhqXpo3r0V /r8Df0sVdb5ovWVKAJnQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1okQt5-00CYDk-QA; Mon, 17 Oct 2022 14:14:39 +0000 Received: from mail-wr1-x42f.google.com ([2a00:1450:4864:20::42f]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1okQt2-00CY9r-F1 for linux-arm-kernel@lists.infradead.org; Mon, 17 Oct 2022 14:14:37 +0000 Received: by mail-wr1-x42f.google.com with SMTP id b4so18717340wrs.1 for ; Mon, 17 Oct 2022 07:14:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Vq5kCnUtoL+6Ezgs4d51zvzN1gUGsMC/kvnhiOvxhZA=; b=tz3RbYuUFruNlDazal9vUSlnltiLDHvOxIl0LPUBuv6NxoHo4Vq9jqpO+al2nQKQI5 jgcl8xIehpkHmpp4r4Q+IWD+dhvC9i80tQ5Wzp5nQou+s9jLpG8rhqY+Uh7I5z9wMxlt QF2zH65EKK1nXRdZNuvu7k7GEGtmX3+rZ5JWHfOoipbWSqjwn6KyzKKMzAZ85ZEuOHMV bpTAOFrf+BiU+6sZmU/F2OjMtWb1YvTZFJTAJeSXADdnC0J3jbbszwQAP0UX8EnC6t2Q DvyGE8C+YTFM/9xHctANb6CMFAo6zi46s9s+OfhIkFxaQNacgLnWj/3UByTYBYsKua1p 9K6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Vq5kCnUtoL+6Ezgs4d51zvzN1gUGsMC/kvnhiOvxhZA=; b=SKnK6pCsrgxVpnCj/LJra4BmMLKoCCsZQSCwidqsV/+uaLG8kuOxERqdcrtGrEEm/b aE+2sC3hdMbsQ2gBKBLqIroGlxwa4vZYxuTTHROngX0/wKheh/uA/ae6JlPMk4I0lNNP VtdCXS8G23YGK7xgyqp0Lqs6hv55yXXNhEymZJB8UOlvXEFVDCJCB1PczyAwgom0weLz 8NrnF/4sVmFhiA9djU6Sgl19UXUvOF1YKrgoem1GttO10EaUK7ymTDx0yO38uckLa9Cd +0nsnbzJ/nzWYZOXwC5/1ATUELVNhbk/qMrscbxMEVYBBv+aZ+5aYwtQ3KDVxzNp25di NZKg== X-Gm-Message-State: ACrzQf1NqKp6SqwbDtbrDflYKJzvi4HjCWLeFTg5FgwPN8VRvaUqclCx vELDUUbko0nFEX/GFto9+Dt0sA== X-Google-Smtp-Source: AMsMyM7CM0UpKnoMrB0XCN0oLx3Pp5aNEqNuOcOBP8m2CUuk58Y8mdiVuC8BXiFJDuJcLQxlD0XrEg== X-Received: by 2002:adf:fd4a:0:b0:22d:d3aa:e004 with SMTP id h10-20020adffd4a000000b0022dd3aae004mr6402643wrs.173.1666016073416; Mon, 17 Oct 2022 07:14:33 -0700 (PDT) Received: from ?IPV6:2a05:6e02:1041:c10:ea6:24ea:3fe7:64b9? ([2a05:6e02:1041:c10:ea6:24ea:3fe7:64b9]) by smtp.googlemail.com with ESMTPSA id x17-20020adff0d1000000b00231ed902a4esm8608659wro.5.2022.10.17.07.14.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 17 Oct 2022 07:14:33 -0700 (PDT) Message-ID: Date: Mon, 17 Oct 2022 16:14:31 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] thermal/drivers/exynos: Fix NULL pointer dereference when getting the critical temp Content-Language: en-US To: Marek Szyprowski , rafael@kernel.org Cc: Bartlomiej Zolnierkiewicz , Krzysztof Kozlowski , Amit Kucheria , Zhang Rui , Alim Akhtar , "open list:SAMSUNG THERMAL DRIVER" , "open list:SAMSUNG THERMAL DRIVER" , "moderated list:ARM/SAMSUNG S3C, S5P AND EXYNOS ARM ARCHITECTURES" , open list References: <4e4d873b-4a40-334a-34e7-defb0fcc4e6b@samsung.com> <20221003132943.1383065-1-daniel.lezcano@linaro.org> <1155a694-b821-d41a-da54-8a9656d90e50@samsung.com> From: Daniel Lezcano In-Reply-To: <1155a694-b821-d41a-da54-8a9656d90e50@samsung.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221017_071436_519979_D7237561 X-CRM114-Status: GOOD ( 13.59 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gMTcvMTAvMjAyMiAxNTo0OCwgTWFyZWsgU3p5cHJvd3NraSB3cm90ZToKPiBIaSBEYW5pZWws Cj4gCj4gT24gMDMuMTAuMjAyMiAxNToyOSwgRGFuaWVsIExlemNhbm8gd3JvdGU6Cj4+IFRoZSBk cml2ZXIgaXMgYXNzdW1pbmcgdGhlIGdldF9jcml0aWNhbCB0ZW1wZXJhdHVyZSBleGlzdHMgYXMg aXQgaXMKPj4gaW5oZXJpdGVkIGJ5IHRoZSB0aGVybWFsIG9mIG9wcy4gQnV0IHRoaXMgb25lIGhh cyBiZWVuIHJlbW92ZWQgaW4KPj4gZmF2b3Igb2YgdGhlIGdlbmVyaWMgb25lLgo+Pgo+PiBVc2Ug dGhlIGdlbmVyaWMgdGhlcm1hbF96b25lX2dldF9jcml0X3RlbXAoKSBmdW5jdGlvbiBpbnN0ZWFk Cj4+Cj4+IEZpeGVzOiAxM2JlYTg2NjIzYiAoInRoZXJtYWwvb2Y6IFJlbW92ZSBvZl90aGVybWFs X2dldF9jcml0X3RlbXAoIikKPj4gUmVwb3J0ZWQtYnk6IE1hcmVrIFN6eXByb3dza2kgPG0uc3p5 cHJvd3NraUBzYW1zdW5nLmNvbT4KPj4gU2lnbmVkLW9mZi1ieTogRGFuaWVsIExlemNhbm8gPGRh bmllbC5sZXpjYW5vQGxpbmFyby5vcmc+Cj4gCj4gVGhpcyBwYXRjaCBoYXMgYmVlbiBkcm9wcGVk IGZyb20gLW5leHQsIGlzIHRoZXJlIGFyZSByZWFzb24gZm9yIHRoYXQ/CgpObywgbXkgbWlzdGFr ZS4gSSBkcm9wcGVkIGl0IGFjY2lkZW50YWxseSB3aGVuIEkgcmViYXNlZCB0aGUgYnJhbmNoLgoK VGhhbmtzIGZvciBwb2ludGluZyBpdCBvdXQuCgoKLS0gCjxodHRwOi8vd3d3LmxpbmFyby5vcmcv PiBMaW5hcm8ub3JnIOKUgiBPcGVuIHNvdXJjZSBzb2Z0d2FyZSBmb3IgQVJNIFNvQ3MKCkZvbGxv dyBMaW5hcm86ICA8aHR0cDovL3d3dy5mYWNlYm9vay5jb20vcGFnZXMvTGluYXJvPiBGYWNlYm9v ayB8CjxodHRwOi8vdHdpdHRlci5jb20vIyEvbGluYXJvb3JnPiBUd2l0dGVyIHwKPGh0dHA6Ly93 d3cubGluYXJvLm9yZy9saW5hcm8tYmxvZy8+IEJsb2cKCl9fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0Cmxp bnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFk Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK