From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE1EFC43140 for ; Thu, 21 Jun 2018 05:06:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 969BC20883 for ; Thu, 21 Jun 2018 05:06:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 969BC20883 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932508AbeFUFGN (ORCPT ); Thu, 21 Jun 2018 01:06:13 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:56184 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932231AbeFUFGM (ORCPT ); Thu, 21 Jun 2018 01:06:12 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 139F8400225D; Thu, 21 Jun 2018 05:06:12 +0000 (UTC) Received: from localhost.localdomain (ovpn-12-127.pek2.redhat.com [10.72.12.127]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0C5352156880; Thu, 21 Jun 2018 05:06:08 +0000 (UTC) Subject: Re: [PATCH 2/4 V3] Allocate pages for kdump without encryption when SME is enabled To: Baoquan He Cc: linux-kernel@vger.kernel.org, thomas.lendacky@amd.com, iommu@lists.linux-foundation.org, dyoung@redhat.com, kexec@lists.infradead.org References: <20180616082714.32035-1-lijiang@redhat.com> <20180616082714.32035-3-lijiang@redhat.com> <20180621015306.GG29979@MiWiFi-R3L-srv> From: lijiang Message-ID: Date: Thu, 21 Jun 2018 13:06:05 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20180621015306.GG29979@MiWiFi-R3L-srv> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.7]); Thu, 21 Jun 2018 05:06:12 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.7]); Thu, 21 Jun 2018 05:06:12 +0000 (UTC) for IP:'10.11.54.6' DOMAIN:'int-mx06.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'lijiang@redhat.com' RCPT:'' Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 在 2018年06月21日 09:53, Baoquan He 写道: > On 06/16/18 at 04:27pm, Lianbo Jiang wrote: >> When SME is enabled in the first kernel, we will allocate pages >> for kdump without encryption in order to be able to boot the >> second kernel in the same manner as kexec, which helps to keep >> the same code style. >> >> Signed-off-by: Lianbo Jiang >> --- >> kernel/kexec_core.c | 12 ++++++++++++ >> 1 file changed, 12 insertions(+) >> >> diff --git a/kernel/kexec_core.c b/kernel/kexec_core.c >> index 20fef1a..3c22a9b 100644 >> --- a/kernel/kexec_core.c >> +++ b/kernel/kexec_core.c >> @@ -471,6 +471,16 @@ static struct page *kimage_alloc_crash_control_pages(struct kimage *image, >> } >> } >> >> + if (pages) { >> + unsigned int count, i; >> + >> + pages->mapping = NULL; >> + set_page_private(pages, order); >> + count = 1 << order; >> + for (i = 0; i < count; i++) >> + SetPageReserved(pages + i); > > I guess you might imitate the kexec case, however kexec get pages from > buddy. Crash pages are reserved in memblock, these codes might make no sense. > Thanks for your comments. We have changed the attribute of pages, so the original attribute of pages will be restored when they free. Thanks. Lianbo >> + arch_kexec_post_alloc_pages(page_address(pages), 1 << order, 0); >> + } >> return pages; >> } >> >> @@ -865,6 +875,7 @@ static int kimage_load_crash_segment(struct kimage *image, >> result = -ENOMEM; >> goto out; >> } >> + arch_kexec_post_alloc_pages(page_address(page), 1, 0); >> ptr = kmap(page); >> ptr += maddr & ~PAGE_MASK; >> mchunk = min_t(size_t, mbytes, >> @@ -882,6 +893,7 @@ static int kimage_load_crash_segment(struct kimage *image, >> result = copy_from_user(ptr, buf, uchunk); >> kexec_flush_icache_page(page); >> kunmap(page); >> + arch_kexec_pre_free_pages(page_address(page), 1); >> if (result) { >> result = -EFAULT; >> goto out; >> -- >> 2.9.5 >> >> >> _______________________________________________ >> kexec mailing list >> kexec@lists.infradead.org >> http://lists.infradead.org/mailman/listinfo/kexec From mboxrd@z Thu Jan 1 00:00:00 1970 From: lijiang Subject: Re: [PATCH 2/4 V3] Allocate pages for kdump without encryption when SME is enabled Date: Thu, 21 Jun 2018 13:06:05 +0800 Message-ID: References: <20180616082714.32035-1-lijiang@redhat.com> <20180616082714.32035-3-lijiang@redhat.com> <20180621015306.GG29979@MiWiFi-R3L-srv> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20180621015306.GG29979@MiWiFi-R3L-srv> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Baoquan He Cc: thomas.lendacky-5C7GfCeVMHo@public.gmane.org, iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, kexec-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: iommu@lists.linux-foundation.org 5ZyoIDIwMTjlubQwNuaciDIx5pelIDA5OjUzLCBCYW9xdWFuIEhlIOWGmemBkzoKPiBPbiAwNi8x Ni8xOCBhdCAwNDoyN3BtLCBMaWFuYm8gSmlhbmcgd3JvdGU6Cj4+IFdoZW4gU01FIGlzIGVuYWJs ZWQgaW4gdGhlIGZpcnN0IGtlcm5lbCwgd2Ugd2lsbCBhbGxvY2F0ZSBwYWdlcwo+PiBmb3Iga2R1 bXAgd2l0aG91dCBlbmNyeXB0aW9uIGluIG9yZGVyIHRvIGJlIGFibGUgdG8gYm9vdCB0aGUKPj4g c2Vjb25kIGtlcm5lbCBpbiB0aGUgc2FtZSBtYW5uZXIgYXMga2V4ZWMsIHdoaWNoIGhlbHBzIHRv IGtlZXAKPj4gdGhlIHNhbWUgY29kZSBzdHlsZS4KPj4KPj4gU2lnbmVkLW9mZi1ieTogTGlhbmJv IEppYW5nIDxsaWppYW5nQHJlZGhhdC5jb20+Cj4+IC0tLQo+PiAga2VybmVsL2tleGVjX2NvcmUu YyB8IDEyICsrKysrKysrKysrKwo+PiAgMSBmaWxlIGNoYW5nZWQsIDEyIGluc2VydGlvbnMoKykK Pj4KPj4gZGlmZiAtLWdpdCBhL2tlcm5lbC9rZXhlY19jb3JlLmMgYi9rZXJuZWwva2V4ZWNfY29y ZS5jCj4+IGluZGV4IDIwZmVmMWEuLjNjMjJhOWIgMTAwNjQ0Cj4+IC0tLSBhL2tlcm5lbC9rZXhl Y19jb3JlLmMKPj4gKysrIGIva2VybmVsL2tleGVjX2NvcmUuYwo+PiBAQCAtNDcxLDYgKzQ3MSwx NiBAQCBzdGF0aWMgc3RydWN0IHBhZ2UgKmtpbWFnZV9hbGxvY19jcmFzaF9jb250cm9sX3BhZ2Vz KHN0cnVjdCBraW1hZ2UgKmltYWdlLAo+PiAgCQl9Cj4+ICAJfQo+PiAgCj4+ICsJaWYgKHBhZ2Vz KSB7Cj4+ICsJCXVuc2lnbmVkIGludCBjb3VudCwgaTsKPj4gKwo+PiArCQlwYWdlcy0+bWFwcGlu ZyA9IE5VTEw7Cj4+ICsJCXNldF9wYWdlX3ByaXZhdGUocGFnZXMsIG9yZGVyKTsKPj4gKwkJY291 bnQgPSAxIDw8IG9yZGVyOwo+PiArCQlmb3IgKGkgPSAwOyBpIDwgY291bnQ7IGkrKykKPj4gKwkJ CVNldFBhZ2VSZXNlcnZlZChwYWdlcyArIGkpOwo+IAo+IEkgZ3Vlc3MgeW91IG1pZ2h0IGltaXRh dGUgdGhlIGtleGVjIGNhc2UsIGhvd2V2ZXIga2V4ZWMgZ2V0IHBhZ2VzIGZyb20KPiBidWRkeS4g Q3Jhc2ggcGFnZXMgYXJlIHJlc2VydmVkIGluIG1lbWJsb2NrLCB0aGVzZSBjb2RlcyBtaWdodCBt YWtlIG5vIHNlbnNlLgo+IApUaGFua3MgZm9yIHlvdXIgY29tbWVudHMuCldlIGhhdmUgY2hhbmdl ZCB0aGUgYXR0cmlidXRlIG9mIHBhZ2VzLCBzbyB0aGUgb3JpZ2luYWwgYXR0cmlidXRlIG9mIHBh Z2VzIHdpbGwgYmUKcmVzdG9yZWQgd2hlbiB0aGV5IGZyZWUuCgpUaGFua3MuCkxpYW5ibwo+PiAr CQlhcmNoX2tleGVjX3Bvc3RfYWxsb2NfcGFnZXMocGFnZV9hZGRyZXNzKHBhZ2VzKSwgMSA8PCBv cmRlciwgMCk7Cj4+ICsJfQo+PiAgCXJldHVybiBwYWdlczsKPj4gIH0KPj4gIAo+PiBAQCAtODY1 LDYgKzg3NSw3IEBAIHN0YXRpYyBpbnQga2ltYWdlX2xvYWRfY3Jhc2hfc2VnbWVudChzdHJ1Y3Qg a2ltYWdlICppbWFnZSwKPj4gIAkJCXJlc3VsdCAgPSAtRU5PTUVNOwo+PiAgCQkJZ290byBvdXQ7 Cj4+ICAJCX0KPj4gKwkJYXJjaF9rZXhlY19wb3N0X2FsbG9jX3BhZ2VzKHBhZ2VfYWRkcmVzcyhw YWdlKSwgMSwgMCk7Cj4+ICAJCXB0ciA9IGttYXAocGFnZSk7Cj4+ICAJCXB0ciArPSBtYWRkciAm IH5QQUdFX01BU0s7Cj4+ICAJCW1jaHVuayA9IG1pbl90KHNpemVfdCwgbWJ5dGVzLAo+PiBAQCAt ODgyLDYgKzg5Myw3IEBAIHN0YXRpYyBpbnQga2ltYWdlX2xvYWRfY3Jhc2hfc2VnbWVudChzdHJ1 Y3Qga2ltYWdlICppbWFnZSwKPj4gIAkJCXJlc3VsdCA9IGNvcHlfZnJvbV91c2VyKHB0ciwgYnVm LCB1Y2h1bmspOwo+PiAgCQlrZXhlY19mbHVzaF9pY2FjaGVfcGFnZShwYWdlKTsKPj4gIAkJa3Vu bWFwKHBhZ2UpOwo+PiArCQlhcmNoX2tleGVjX3ByZV9mcmVlX3BhZ2VzKHBhZ2VfYWRkcmVzcyhw YWdlKSwgMSk7Cj4+ICAJCWlmIChyZXN1bHQpIHsKPj4gIAkJCXJlc3VsdCA9IC1FRkFVTFQ7Cj4+ ICAJCQlnb3RvIG91dDsKPj4gLS0gCj4+IDIuOS41Cj4+Cj4+Cj4+IF9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4+IGtleGVjIG1haWxpbmcgbGlzdAo+PiBr ZXhlY0BsaXN0cy5pbmZyYWRlYWQub3JnCj4+IGh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21h aWxtYW4vbGlzdGluZm8va2V4ZWMKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18KaW9tbXUgbWFpbGluZyBsaXN0CmlvbW11QGxpc3RzLmxpbnV4LWZvdW5kYXRp b24ub3JnCmh0dHBzOi8vbGlzdHMubGludXhmb3VuZGF0aW9uLm9yZy9tYWlsbWFuL2xpc3RpbmZv L2lvbW11 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mx3-rdu2.redhat.com ([66.187.233.73] helo=mx1.redhat.com) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1fVrnb-0003om-8b for kexec@lists.infradead.org; Thu, 21 Jun 2018 05:06:25 +0000 Subject: Re: [PATCH 2/4 V3] Allocate pages for kdump without encryption when SME is enabled References: <20180616082714.32035-1-lijiang@redhat.com> <20180616082714.32035-3-lijiang@redhat.com> <20180621015306.GG29979@MiWiFi-R3L-srv> From: lijiang Message-ID: Date: Thu, 21 Jun 2018 13:06:05 +0800 MIME-Version: 1.0 In-Reply-To: <20180621015306.GG29979@MiWiFi-R3L-srv> Content-Language: en-US List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "kexec" Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org To: Baoquan He Cc: thomas.lendacky@amd.com, iommu@lists.linux-foundation.org, dyoung@redhat.com, linux-kernel@vger.kernel.org, kexec@lists.infradead.org 5ZyoIDIwMTjlubQwNuaciDIx5pelIDA5OjUzLCBCYW9xdWFuIEhlIOWGmemBkzoKPiBPbiAwNi8x Ni8xOCBhdCAwNDoyN3BtLCBMaWFuYm8gSmlhbmcgd3JvdGU6Cj4+IFdoZW4gU01FIGlzIGVuYWJs ZWQgaW4gdGhlIGZpcnN0IGtlcm5lbCwgd2Ugd2lsbCBhbGxvY2F0ZSBwYWdlcwo+PiBmb3Iga2R1 bXAgd2l0aG91dCBlbmNyeXB0aW9uIGluIG9yZGVyIHRvIGJlIGFibGUgdG8gYm9vdCB0aGUKPj4g c2Vjb25kIGtlcm5lbCBpbiB0aGUgc2FtZSBtYW5uZXIgYXMga2V4ZWMsIHdoaWNoIGhlbHBzIHRv IGtlZXAKPj4gdGhlIHNhbWUgY29kZSBzdHlsZS4KPj4KPj4gU2lnbmVkLW9mZi1ieTogTGlhbmJv IEppYW5nIDxsaWppYW5nQHJlZGhhdC5jb20+Cj4+IC0tLQo+PiAga2VybmVsL2tleGVjX2NvcmUu YyB8IDEyICsrKysrKysrKysrKwo+PiAgMSBmaWxlIGNoYW5nZWQsIDEyIGluc2VydGlvbnMoKykK Pj4KPj4gZGlmZiAtLWdpdCBhL2tlcm5lbC9rZXhlY19jb3JlLmMgYi9rZXJuZWwva2V4ZWNfY29y ZS5jCj4+IGluZGV4IDIwZmVmMWEuLjNjMjJhOWIgMTAwNjQ0Cj4+IC0tLSBhL2tlcm5lbC9rZXhl Y19jb3JlLmMKPj4gKysrIGIva2VybmVsL2tleGVjX2NvcmUuYwo+PiBAQCAtNDcxLDYgKzQ3MSwx NiBAQCBzdGF0aWMgc3RydWN0IHBhZ2UgKmtpbWFnZV9hbGxvY19jcmFzaF9jb250cm9sX3BhZ2Vz KHN0cnVjdCBraW1hZ2UgKmltYWdlLAo+PiAgCQl9Cj4+ICAJfQo+PiAgCj4+ICsJaWYgKHBhZ2Vz KSB7Cj4+ICsJCXVuc2lnbmVkIGludCBjb3VudCwgaTsKPj4gKwo+PiArCQlwYWdlcy0+bWFwcGlu ZyA9IE5VTEw7Cj4+ICsJCXNldF9wYWdlX3ByaXZhdGUocGFnZXMsIG9yZGVyKTsKPj4gKwkJY291 bnQgPSAxIDw8IG9yZGVyOwo+PiArCQlmb3IgKGkgPSAwOyBpIDwgY291bnQ7IGkrKykKPj4gKwkJ CVNldFBhZ2VSZXNlcnZlZChwYWdlcyArIGkpOwo+IAo+IEkgZ3Vlc3MgeW91IG1pZ2h0IGltaXRh dGUgdGhlIGtleGVjIGNhc2UsIGhvd2V2ZXIga2V4ZWMgZ2V0IHBhZ2VzIGZyb20KPiBidWRkeS4g Q3Jhc2ggcGFnZXMgYXJlIHJlc2VydmVkIGluIG1lbWJsb2NrLCB0aGVzZSBjb2RlcyBtaWdodCBt YWtlIG5vIHNlbnNlLgo+IApUaGFua3MgZm9yIHlvdXIgY29tbWVudHMuCldlIGhhdmUgY2hhbmdl ZCB0aGUgYXR0cmlidXRlIG9mIHBhZ2VzLCBzbyB0aGUgb3JpZ2luYWwgYXR0cmlidXRlIG9mIHBh Z2VzIHdpbGwgYmUKcmVzdG9yZWQgd2hlbiB0aGV5IGZyZWUuCgpUaGFua3MuCkxpYW5ibwo+PiAr CQlhcmNoX2tleGVjX3Bvc3RfYWxsb2NfcGFnZXMocGFnZV9hZGRyZXNzKHBhZ2VzKSwgMSA8PCBv cmRlciwgMCk7Cj4+ICsJfQo+PiAgCXJldHVybiBwYWdlczsKPj4gIH0KPj4gIAo+PiBAQCAtODY1 LDYgKzg3NSw3IEBAIHN0YXRpYyBpbnQga2ltYWdlX2xvYWRfY3Jhc2hfc2VnbWVudChzdHJ1Y3Qg a2ltYWdlICppbWFnZSwKPj4gIAkJCXJlc3VsdCAgPSAtRU5PTUVNOwo+PiAgCQkJZ290byBvdXQ7 Cj4+ICAJCX0KPj4gKwkJYXJjaF9rZXhlY19wb3N0X2FsbG9jX3BhZ2VzKHBhZ2VfYWRkcmVzcyhw YWdlKSwgMSwgMCk7Cj4+ICAJCXB0ciA9IGttYXAocGFnZSk7Cj4+ICAJCXB0ciArPSBtYWRkciAm IH5QQUdFX01BU0s7Cj4+ICAJCW1jaHVuayA9IG1pbl90KHNpemVfdCwgbWJ5dGVzLAo+PiBAQCAt ODgyLDYgKzg5Myw3IEBAIHN0YXRpYyBpbnQga2ltYWdlX2xvYWRfY3Jhc2hfc2VnbWVudChzdHJ1 Y3Qga2ltYWdlICppbWFnZSwKPj4gIAkJCXJlc3VsdCA9IGNvcHlfZnJvbV91c2VyKHB0ciwgYnVm LCB1Y2h1bmspOwo+PiAgCQlrZXhlY19mbHVzaF9pY2FjaGVfcGFnZShwYWdlKTsKPj4gIAkJa3Vu bWFwKHBhZ2UpOwo+PiArCQlhcmNoX2tleGVjX3ByZV9mcmVlX3BhZ2VzKHBhZ2VfYWRkcmVzcyhw YWdlKSwgMSk7Cj4+ICAJCWlmIChyZXN1bHQpIHsKPj4gIAkJCXJlc3VsdCA9IC1FRkFVTFQ7Cj4+ ICAJCQlnb3RvIG91dDsKPj4gLS0gCj4+IDIuOS41Cj4+Cj4+Cj4+IF9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4+IGtleGVjIG1haWxpbmcgbGlzdAo+PiBr ZXhlY0BsaXN0cy5pbmZyYWRlYWQub3JnCj4+IGh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21h aWxtYW4vbGlzdGluZm8va2V4ZWMKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fCmtleGVjIG1haWxpbmcgbGlzdAprZXhlY0BsaXN0cy5pbmZyYWRlYWQub3Jn Cmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8va2V4ZWMK