From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8205BC7EE23 for ; Tue, 30 May 2023 14:25:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229782AbjE3OZd (ORCPT ); Tue, 30 May 2023 10:25:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37516 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230236AbjE3OYa (ORCPT ); Tue, 30 May 2023 10:24:30 -0400 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E4587171D; Tue, 30 May 2023 07:23:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=FWAIGy3W6VRuHfHWmHtL4IHZGLEpQvK9/WLf1WisLfI=; b=QsJSun8z9mB/Mco6Uqic0npFOn J+Nfq1fixoi8UAwixInmQg0yHXy8gshY81qIm+lDlc/NAlnr/QZLZH+oqsCRdgXLnKy5XB/URA4Uo l0v6im7FYGjFGucV2X4rFcYiVJhAk8gO4jS7ftT7eGW6EkjsfqqV6pR19J8gsQ5iaU0U=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1q40Fs-00ELCp-5e; Tue, 30 May 2023 16:23:20 +0200 Date: Tue, 30 May 2023 16:23:20 +0200 From: Andrew Lunn To: Lukasz Majewski Cc: "Russell King (Oracle)" , Vivien Didelot , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Jakub Kicinski , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC] net: dsa: slave: Advertise correct EEE capabilities at slave PHY setup Message-ID: References: <20230530122621.2142192-1-lukma@denx.de> <20230530160743.2c93a388@wsk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230530160743.2c93a388@wsk> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 30, 2023 at 04:07:43PM +0200, Lukasz Majewski wrote: > Hi Russell, > > > On Tue, May 30, 2023 at 02:26:21PM +0200, Lukasz Majewski wrote: > > > One can disable in device tree advertising of EEE capabilities of > > > PHY when 'eee-broken-100tx' property is present in DTS. > > > > > > With DSA switch it also may happen that one would need to disable > > > EEE due to some network issues. > > > > > > Corresponding switch DTS description: > > > > > > switch@0 { > > > ports { > > > port@0 { > > > reg = <0>; > > > label = "lan1"; > > > phy-handle = <&switchphy0>; > > > }; > > > } > > > mdio { > > > switchphy0: switchphy@0 { > > > reg = <0>; > > > eee-broken-100tx; > > > }; > > > }; > > > > > > This patch adjusts the content of MDIO_AN_EEE_ADV in MDIO_MMD_AN > > > "device" so the phydev->eee_broken_modes are taken into account > > > from the start of the slave PHYs. > > > > This should be handled by phylib today in recent kernels without the > > need for any patch (as I describe below, because the config_aneg PHY > > method should be programming it.) Are you seeing a problem with it > > in 6.4-rc? > > Unfortunately, for this project I use LTS 5.15.z kernel. > > My impression is that the mv88e6xxx driver is not handling EEE setup > during initialization (even with v6.4-rc). In general, nearly every driver gets EEE wrong. I have a patchset which basically rewrites EEE. It has been posted as RFC a couple times, and i plan to start posting it for merging this week. But as a result, don't expect EEE to actually work with any LTS kernel. Andrew