From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38048) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cw53w-00075y-Kp for qemu-devel@nongnu.org; Thu, 06 Apr 2017 06:54:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cw53t-0000d3-Hn for qemu-devel@nongnu.org; Thu, 06 Apr 2017 06:54:48 -0400 Received: from mx1.redhat.com ([209.132.183.28]:35030) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cw53t-0000ck-8c for qemu-devel@nongnu.org; Thu, 06 Apr 2017 06:54:45 -0400 References: <1491462524-1617-1-git-send-email-peterx@redhat.com> <1491462524-1617-5-git-send-email-peterx@redhat.com> From: Auger Eric Message-ID: Date: Thu, 6 Apr 2017 12:54:30 +0200 MIME-Version: 1.0 In-Reply-To: <1491462524-1617-5-git-send-email-peterx@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v8 4/9] memory: introduce memory_region_notify_one() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Xu , qemu-devel@nongnu.org Cc: tianyu.lan@intel.com, kevin.tian@intel.com, mst@redhat.com, jan.kiszka@siemens.com, jasowang@redhat.com, alex.williamson@redhat.com, Marcel Apfelbaum , bd.aviv@gmail.com, David Gibson Hi Peter, On 06/04/2017 09:08, Peter Xu wrote: > Generalizing the notify logic in memory_region_notify_iommu() into a > single function. This can be further used in customized replay() > functions for IOMMUs. > > Reviewed-by: David Gibson > Signed-off-by: Peter Xu Reviewed-by: Eric Auger Thanks Eric > --- > include/exec/memory.h | 15 +++++++++++++++ > memory.c | 40 ++++++++++++++++++++++++---------------- > 2 files changed, 39 insertions(+), 16 deletions(-) > > diff --git a/include/exec/memory.h b/include/exec/memory.h > index fb7dff3..055b3a8 100644 > --- a/include/exec/memory.h > +++ b/include/exec/memory.h > @@ -688,6 +688,21 @@ void memory_region_notify_iommu(MemoryRegion *mr, > IOMMUTLBEntry entry); > > /** > + * memory_region_notify_one: notify a change in an IOMMU translation > + * entry to a single notifier > + * > + * This works just like memory_region_notify_iommu(), but it only > + * notifies a specific notifier, not all of them. > + * > + * @notifier: the notifier to be notified > + * @entry: the new entry in the IOMMU translation table. The entry > + * replaces all old entries for the same virtual I/O address range. > + * Deleted entries have .@perm == 0. > + */ > +void memory_region_notify_one(IOMMUNotifier *notifier, > + IOMMUTLBEntry *entry); > + > +/** > * memory_region_register_iommu_notifier: register a notifier for changes to > * IOMMU translation entries. > * > diff --git a/memory.c b/memory.c > index b4ed67b..ded4bf1 100644 > --- a/memory.c > +++ b/memory.c > @@ -1662,32 +1662,40 @@ void memory_region_unregister_iommu_notifier(MemoryRegion *mr, > memory_region_update_iommu_notify_flags(mr); > } > > -void memory_region_notify_iommu(MemoryRegion *mr, > - IOMMUTLBEntry entry) > +void memory_region_notify_one(IOMMUNotifier *notifier, > + IOMMUTLBEntry *entry) > { > - IOMMUNotifier *iommu_notifier; > IOMMUNotifierFlag request_flags; > > - assert(memory_region_is_iommu(mr)); > + /* > + * Skip the notification if the notification does not overlap > + * with registered range. > + */ > + if (notifier->start > entry->iova + entry->addr_mask + 1 || > + notifier->end < entry->iova) { > + return; > + } > > - if (entry.perm & IOMMU_RW) { > + if (entry->perm & IOMMU_RW) { > request_flags = IOMMU_NOTIFIER_MAP; > } else { > request_flags = IOMMU_NOTIFIER_UNMAP; > } > > + if (notifier->notifier_flags & request_flags) { > + notifier->notify(notifier, entry); > + } > +} > + > +void memory_region_notify_iommu(MemoryRegion *mr, > + IOMMUTLBEntry entry) > +{ > + IOMMUNotifier *iommu_notifier; > + > + assert(memory_region_is_iommu(mr)); > + > IOMMU_NOTIFIER_FOREACH(iommu_notifier, mr) { > - /* > - * Skip the notification if the notification does not overlap > - * with registered range. > - */ > - if (iommu_notifier->start > entry.iova + entry.addr_mask + 1 || > - iommu_notifier->end < entry.iova) { > - continue; > - } > - if (iommu_notifier->notifier_flags & request_flags) { > - iommu_notifier->notify(iommu_notifier, &entry); > - } > + memory_region_notify_one(iommu_notifier, &entry); > } > } > >