From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ferruh Yigit Subject: Re: [PATCH] net/mlx5: fix ICC compiler warning Date: Fri, 20 Oct 2017 18:05:12 -0700 Message-ID: References: <20171017024643.1011-1-xuemingl@mellanox.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Cc: dev@dpdk.org To: Xueming Li , Nelio Laranjeiro , FerruhYigitferruh.yigit@intel.com Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id D9AE91B29D for ; Sat, 21 Oct 2017 03:05:13 +0200 (CEST) In-Reply-To: <20171017024643.1011-1-xuemingl@mellanox.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/16/2017 7:46 PM, Xueming Li wrote: > Initialize variable to avoid ICC compiler warning: > http://www.dpdk.org/ml/archives/dev/2017-October/077971.html Hi Xueming, Nelio, I disabled that warning for ICC in Makefile [1], as mentioned in above mail. If you prefer to fix it instead of disable, can you please update the patch, and remove that workaround in this patch? Thanks, ferruh [1] http://dpdk.org/browse/dpdk/tree/drivers/net/mlx5/Makefile#n93 # Disable false positive warning ifeq ($(CONFIG_RTE_TOOLCHAIN_ICC),y) CFLAGS_mlx5_txq.o += -wd3656 endif > > Fixes: f8b9a3bad467 ("net/mlx5: install a socket to exchange a file...") > > Signed-off-by: Xueming Li > --- > drivers/net/mlx5/mlx5_txq.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/mlx5/mlx5_txq.c b/drivers/net/mlx5/mlx5_txq.c > index 9deaa7e..93f1388 100644 > --- a/drivers/net/mlx5/mlx5_txq.c > +++ b/drivers/net/mlx5/mlx5_txq.c > @@ -246,6 +246,7 @@ > int already_mapped; > size_t page_size = sysconf(_SC_PAGESIZE); > > + memset(pages, 0, priv->txqs_n * sizeof(uintptr_t)); > /* > * As rdma-core, UARs are mapped in size of OS page size. > * Use aligned address to avoid duplicate mmap. >