Re: [EXT] Re: [PATCH v3 10/11] qla2xxx: enable heartbeat validation for edif command

[Himanshu Madhani <himanshu.madhani@oracle.com>]

On 6/23/21 11:02 PM, Nilesh Javali wrote:
> Himanshu,
> 
> The heartbeat check patch attached does the actual validation,
> and the same is extended for edif commands too.
> 
Correct.... this patch is not doing that enablment right?

My point is that your commit subject and commit log does not match. it 
should say "qla2xxx: Increment EDIF command and completion counts" 
instead of "qla2xxx: enable heartbeat validation for edif command"

> Thanks,
> Nilesh
> 
>> -----Original Message-----
>> From: Himanshu Madhani <himanshu.madhani@oracle.com>
>> Sent: Thursday, June 24, 2021 12:17 AM
>> To: Nilesh Javali <njavali@marvell.com>; martin.petersen@oracle.com
>> Cc: linux-scsi@vger.kernel.org; GR-QLogic-Storage-Upstream <GR-QLogic-
>> Storage-Upstream@marvell.com>
>> Subject: [EXT] Re: [PATCH v3 10/11] qla2xxx: enable heartbeat validation for
>> edif command
>>
>> External Email
>>
>> ----------------------------------------------------------------------
>>
>>
>> On 6/23/21 5:26 AM, Nilesh Javali wrote:
>>> From: Quinn Tran <qutran@marvell.com>
>>>
>>> Increment the command and the completion counts.
>>
>> I don't see enablement of heartbeat validation code in this patch.
>>
>> Am i missing something?
>>
>>>
>>> Signed-off-by: Quinn Tran <qutran@marvell.com>
>>> Signed-off-by: Nilesh Javali <njavali@marvell.com>
>>> ---
>>>    drivers/scsi/qla2xxx/qla_edif.c | 1 +
>>>    drivers/scsi/qla2xxx/qla_isr.c  | 3 +--
>>>    2 files changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/drivers/scsi/qla2xxx/qla_edif.c b/drivers/scsi/qla2xxx/qla_edif.c
>>> index 8e730cc882e6..ccbe0e1bfcbc 100644
>>> --- a/drivers/scsi/qla2xxx/qla_edif.c
>>> +++ b/drivers/scsi/qla2xxx/qla_edif.c
>>> @@ -2926,6 +2926,7 @@ qla28xx_start_scsi_edif(srb_t *sp)
>>>    		req->ring_ptr++;
>>>    	}
>>>
>>> +	sp->qpair->cmd_cnt++;
>>>    	/* Set chip new ring index. */
>>>    	wrt_reg_dword(req->req_q_in, req->ring_index);
>>>
>>> diff --git a/drivers/scsi/qla2xxx/qla_isr.c b/drivers/scsi/qla2xxx/qla_isr.c
>>> index ce4f93fb4d25..e8928fd83049 100644
>>> --- a/drivers/scsi/qla2xxx/qla_isr.c
>>> +++ b/drivers/scsi/qla2xxx/qla_isr.c
>>> @@ -3192,10 +3192,9 @@ qla2x00_status_entry(scsi_qla_host_t *vha,
>> struct rsp_que *rsp, void *pkt)
>>>    		return;
>>>    	}
>>>
>>> -	sp->qpair->cmd_completion_cnt++;
>>> -
>>>    	/* Fast path completion. */
>>>    	qla_chk_edif_rx_sa_delete_pending(vha, sp, sts24);
>>> +	sp->qpair->cmd_completion_cnt++;
>>>
>>>    	if (comp_status == CS_COMPLETE && scsi_status == 0) {
>>>    		qla2x00_process_completed_request(vha, req, handle);
>>>
>>
>> --
>> Himanshu Madhani                                Oracle Linux Engineering

-- 
Himanshu Madhani                                Oracle Linux Engineering