On 04/29/2016 07:46 AM, Sagi Grimberg wrote: > >>> Replace the homegrown RDMA READ/WRITE code in isert with the generic >>> API, >>> which also adds iWarp support to the I/O path as a side effect. Note >>> that full iWarp operation will need a few additional patches from Steve. >>> >>> Signed-off-by: Christoph Hellwig >>> --- >>> drivers/infiniband/ulp/isert/ib_isert.c | 841 >>> ++++---------------------------- >>> drivers/infiniband/ulp/isert/ib_isert.h | 69 +-- >>> 2 files changed, 85 insertions(+), 825 deletions(-) >> >> Hi Sagi, >> >> I've seen your reviews on the smaller patches in this series, but this >> one in particular has your name all over it. If you could review it, I >> would appreciate it ;-) > > ~800 LOC deleted, what's not to love ? :) Well, if it neutered support for something in the process, it wouldn't be to love ;-) > The patch looks fine to me, > Reviewed-by: Sagi Grimberg > > I did some light testing with rxe and it works fine (no signature stuff > though). I've asked Mellanox folks to get this set into their regression > systems and still hoping to get their tested-by tag, but if we don't > hear from them by the merge window I don't think we should block it. Good to hear, thanks! -- Doug Ledford GPG KeyID: 0E572FDD