From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH 31/32] drm/i915/execlists: Virtual engine bonding Date: Thu, 18 Apr 2019 10:50:30 +0100 Message-ID: References: <20190417075657.19456-1-chris@chris-wilson.co.uk> <20190417075657.19456-31-chris@chris-wilson.co.uk> <155557065786.3649.15598309807699098369@skylake-alporthouse-com> <155557882725.4314.8046103585634106323@skylake-alporthouse-com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id C57A96E0E6 for ; Thu, 18 Apr 2019 09:50:33 +0000 (UTC) In-Reply-To: <155557882725.4314.8046103585634106323@skylake-alporthouse-com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDE4LzA0LzIwMTkgMTA6MTMsIENocmlzIFdpbHNvbiB3cm90ZToKPiBRdW90aW5nIFR2cnRr byBVcnN1bGluICgyMDE5LTA0LTE4IDA5OjU3OjQzKQo+Pgo+PiBPbiAxOC8wNC8yMDE5IDA3OjU3 LCBDaHJpcyBXaWxzb24gd3JvdGU6Cj4+PiBRdW90aW5nIFR2cnRrbyBVcnN1bGluICgyMDE5LTA0 LTE4IDA3OjQ3OjUxKQo+Pj4+Cj4+Pj4gT24gMTcvMDQvMjAxOSAwODo1NiwgQ2hyaXMgV2lsc29u IHdyb3RlOgo+Pj4+PiArc3RhdGljIHZvaWQKPj4+Pj4gK3ZpcnR1YWxfYm9uZF9leGVjdXRlKHN0 cnVjdCBpOTE1X3JlcXVlc3QgKnJxLCBzdHJ1Y3QgZG1hX2ZlbmNlICpzaWduYWwpCj4+Pj4+ICt7 Cj4+Pj4+ICsgICAgIHN0cnVjdCB2aXJ0dWFsX2VuZ2luZSAqdmUgPSB0b192aXJ0dWFsX2VuZ2lu ZShycS0+ZW5naW5lKTsKPj4+Pj4gKyAgICAgc3RydWN0IHZlX2JvbmQgKmJvbmQ7Cj4+Pj4+ICsK Pj4+Pj4gKyAgICAgYm9uZCA9IHZpcnR1YWxfZmluZF9ib25kKHZlLCB0b19yZXF1ZXN0KHNpZ25h bCktPmVuZ2luZSk7Cj4+Pj4+ICsgICAgIGlmIChib25kKSB7Cj4+Pj4+ICsgICAgICAgICAgICAg aW50ZWxfZW5naW5lX21hc2tfdCBvbGQsIG5ldywgY21wOwo+Pj4+PiArCj4+Pj4+ICsgICAgICAg ICAgICAgY21wID0gUkVBRF9PTkNFKHJxLT5leGVjdXRpb25fbWFzayk7Cj4+Pj4+ICsgICAgICAg ICAgICAgZG8gewo+Pj4+PiArICAgICAgICAgICAgICAgICAgICAgb2xkID0gY21wOwo+Pj4+PiAr ICAgICAgICAgICAgICAgICAgICAgbmV3ID0gY21wICYgYm9uZC0+c2libGluZ19tYXNrOwo+Pj4+ PiArICAgICAgICAgICAgIH0gd2hpbGUgKChjbXAgPSBjbXB4Y2hnKCZycS0+ZXhlY3V0aW9uX21h c2ssIG9sZCwgbmV3KSkgIT0gb2xkKTsKPj4+Pgo+Pj4+IExvb3AgaW1wbGllcyBzb21lb25lIGVs c2UgbWlnaHQgYmUgbW9kaWZ5aW5nIHRoZSBycS0+ZXhlY3V0aW9uX21hc2sgaW4KPj4+PiBwYXJh bGxlbD8KPj4+Cj4+PiBUaGVyZSdzIG5vdGhpbmcgdGhhdCBwcmV2ZW50cyB0aGVyZSBiZWluZyBt dWx0aXBsZSBib25kcyBiZWluZwo+Pj4gZXhlY3V0ZWQgc2ltdWx0YW5lb3VzbHkgKG90aGVyIHRo YW4gcHJhY3RpY2FsaXR5KS4gVGhlcmUncyBhbHNvIG5vdGhpbmcKPj4+IHRoYXQgc2F5cyB0aGlz IHNob3VsZCBiZSB0aGUgb25seSB3YXkgdG8gbW9kaWZ5IHJxLT5leGVjdXRpb25fbWFzayBpbgo+ Pj4gdGhlIGZ1dHVyZS4KPj4KPj4gQnV0IHJlcXVlc3QgaXMgb25lLCBob3cgY2FuIGl0IGJlIHN1 Ym1pdHRlZCBtdWx0aXBsZSB0aW1lcyBzaW11bHRhbmVvdXNseT8KPiAKPiBZb3UgbWVhbiAiSG93 IGNhbiBpdCBiZSBzaWduYWxlZCBtdWx0aXBsZSB0aW1lcyBzaW11bHRhbmVvdXNseT8iCgpPa2F5 IHllcywgc2lnbmFsZWQuIFlvdSBjb3VsZCBnaXZlIHNhbWUgc3VibWl0IGZlbmNlIHRvIG11bHRp cGxlIHNsYXZlcywgCmJ1dCB5b3UgY2FuJ3QgaGF2ZSBzYW1lIHNsYXZlIHJlcXVlc3QgcmVjZWl2 ZSBub3RpZmljYXRpb24gZnJvbSBtdWx0aXBsZSAKbWFzdGVycy4KCk9yIHlvdSBjYW4gaWYgeW91 IGJ1aWxkIGEgY29tcG9zaXRlIGZlbmNlIGFuZCBwYXNzIHRoYXQgaW4/IElzIHRoaXMgdGhlIApz dG9yeSBhYm91dCBzaWduYWwtb24tYW55IHZzIHNpZ25hbC1vbi1hbGw/Cgo+Pgo+Pj4+PiArc3Rh dGljIGludAo+Pj4+PiArc2V0X2VuZ2luZXNfX2JvbmQoc3RydWN0IGk5MTVfdXNlcl9leHRlbnNp b24gX191c2VyICpiYXNlLCB2b2lkICpkYXRhKQo+Pj4+PiArewo+Pj4+PiArICAgICBzdHJ1Y3Qg aTkxNV9jb250ZXh0X2VuZ2luZXNfYm9uZCBfX3VzZXIgKmV4dCA9Cj4+Pj4+ICsgICAgICAgICAg ICAgY29udGFpbmVyX29mX3VzZXIoYmFzZSwgdHlwZW9mKCpleHQpLCBiYXNlKTsKPj4+Pj4gKyAg ICAgY29uc3Qgc3RydWN0IHNldF9lbmdpbmVzICpzZXQgPSBkYXRhOwo+Pj4+PiArICAgICBzdHJ1 Y3QgaW50ZWxfZW5naW5lX2NzICp2aXJ0dWFsOwo+Pj4+PiArICAgICBzdHJ1Y3QgaW50ZWxfZW5n aW5lX2NzICptYXN0ZXI7Cj4+Pj4+ICsgICAgIHUxNiBjbGFzcywgaW5zdGFuY2U7Cj4+Pj4+ICsg ICAgIHUxNiBpZHgsIG51bV9ib25kczsKPj4+Pj4gKyAgICAgaW50IGVyciwgbjsKPj4+Pj4gKwo+ Pj4+PiArICAgICBpZiAoZ2V0X3VzZXIoaWR4LCAmZXh0LT52aXJ0dWFsX2luZGV4KSkKPj4+Pj4g KyAgICAgICAgICAgICByZXR1cm4gLUVGQVVMVDsKPj4+Pj4gKwo+Pj4+PiArICAgICBpZiAoaWR4 ID49IHNldC0+ZW5naW5lcy0+bnVtX2VuZ2luZXMpIHsKPj4+Pj4gKyAgICAgICAgICAgICBEUk1f REVCVUcoIkludmFsaWQgaW5kZXggZm9yIHZpcnR1YWwgZW5naW5lOiAlZCA+PSAlZFxuIiwKPj4+ Pj4gKyAgICAgICAgICAgICAgICAgICAgICAgaWR4LCBzZXQtPmVuZ2luZXMtPm51bV9lbmdpbmVz KTsKPj4+Pj4gKyAgICAgICAgICAgICByZXR1cm4gLUVJTlZBTDsKPj4+Pj4gKyAgICAgfQo+Pj4+ PiArCj4+Pj4+ICsgICAgIGlkeCA9IGFycmF5X2luZGV4X25vc3BlYyhpZHgsIHNldC0+ZW5naW5l cy0+bnVtX2VuZ2luZXMpOwo+Pj4+PiArICAgICBpZiAoIXNldC0+ZW5naW5lcy0+ZW5naW5lc1tp ZHhdKSB7Cj4+Pj4+ICsgICAgICAgICAgICAgRFJNX0RFQlVHKCJJbnZhbGlkIGVuZ2luZSBhdCAl ZFxuIiwgaWR4KTsKPj4+Pj4gKyAgICAgICAgICAgICByZXR1cm4gLUVJTlZBTDsKPj4+Pj4gKyAg ICAgfQo+Pj4+PiArCj4+Pj4+ICsgICAgIC8qCj4+Pj4+ICsgICAgICAqIEEgbm9uLXZpcnR1YWwg ZW5naW5lIGhhcyAwIHNpYmxpbmdzIHRvIGNob29zZSBiZXR3ZWVuOyBhbmQgc3VibWl0Cj4+Pj4+ ICsgICAgICAqIGZlbmNlIHdpbGwgYWx3YXlzIGJlIGRpcmVjdGVkIHRvIHRoZSBvbmUgZW5naW5l Lgo+Pj4+PiArICAgICAgKi8KPj4+Pj4gKyAgICAgdmlydHVhbCA9IHNldC0+ZW5naW5lcy0+ZW5n aW5lc1tpZHhdLT5lbmdpbmU7Cj4+Pj4+ICsgICAgIGlmICghaW50ZWxfZW5naW5lX2lzX3ZpcnR1 YWwodmlydHVhbCkpCj4+Pj4+ICsgICAgICAgICAgICAgcmV0dXJuIDA7Cj4+Pj4KPj4+PiBIbW0g d291bGRuJ3Qgd2Ugc3RyaWN0bHkgc3BlYWtpbmcgbmVlZCB0byBkaXN0aW5ndWlzaCBiZXR3ZWVu IHVBUEkKPj4+PiBlcnJvcnMgYW5kIGF1dG8tbWFnaWMtc2luZ2xlLXZlbmctcmVwbGFjZW1lbnQ/ IExhdHRlciBpcyBPSyB0byByZXR1cm4KPj4+PiBzdWNjZXNzLCBidXQgZm9ybWVyIHNob3VsZCBi ZSByZXBvcnRlZCBhcyAtRUlOVkFMIEkgdGhpbmsuCj4+Pgo+Pj4gSXMgaXQgYSB1QVBJIGVycm9y IGlmIGl0IHdvcmtzPyA6KQo+Pgo+PiBJdCB3b3JrcyBidXQgd2hhdCBpcyB0aGUgcHJhY3RpY2Fs IHVzZT8gSXQgbW9yZSBzaWduYWxzIHVzZXJzcGFjZSBnb3QKPj4gaXQncyBjb25maWd1cmF0aW9u IHdyb25nIGFuZCBpZiB3ZSBzaWxlbnRseSBhY2NlcHQgaXQgZ2V0cyBtb3JlCj4+IGRpZmZpY3Vs dCB0byBmaWd1cmUgb3V0Lgo+IAo+IEF0IHRoYXQgcG9pbnQsIEkgd2FzIGJlaW5nIGZhY2V0aW91 cy4gTWVtb3J5IHNheXMgaXQgd2FzIHNpbXBsZXIgdG8ganVzdAo+IHN0aWNrIHRoZSB2aXJ0dWFs IGNoZWNrIGF0IHRoZSBzdGFydCB0aGFuIGhhdmUgdG8gaW5zZXJ0IGl0IGxhdGVyLiBCdXQKPiBp dCdzIHRyaXZpYWwgdG8gbW92ZSBsYXRlciwgc28gaXQncyBkb25lLgo+IAo+Pj4+PiArCj4+Pj4+ ICsgICAgIGVyciA9IGNoZWNrX3VzZXJfbWJ6KCZleHQtPmZsYWdzKTsKPj4+Pj4gKyAgICAgaWYg KGVycikKPj4+Pj4gKyAgICAgICAgICAgICByZXR1cm4gZXJyOwo+Pj4+PiArCj4+Pj4+ICsgICAg IGZvciAobiA9IDA7IG4gPCBBUlJBWV9TSVpFKGV4dC0+bWJ6NjQpOyBuKyspIHsKPj4+Pj4gKyAg ICAgICAgICAgICBlcnIgPSBjaGVja191c2VyX21ieigmZXh0LT5tYno2NFtuXSk7Cj4+Pj4+ICsg ICAgICAgICAgICAgaWYgKGVycikKPj4+Pj4gKyAgICAgICAgICAgICAgICAgICAgIHJldHVybiBl cnI7Cj4+Pj4+ICsgICAgIH0KPj4+Pj4gKwo+Pj4+PiArICAgICBpZiAoZ2V0X3VzZXIoY2xhc3Ms ICZleHQtPm1hc3Rlcl9jbGFzcykpCj4+Pj4+ICsgICAgICAgICAgICAgcmV0dXJuIC1FRkFVTFQ7 Cj4+Pj4+ICsKPj4+Pj4gKyAgICAgaWYgKGdldF91c2VyKGluc3RhbmNlLCAmZXh0LT5tYXN0ZXJf aW5zdGFuY2UpKQo+Pj4+PiArICAgICAgICAgICAgIHJldHVybiAtRUZBVUxUOwo+Pj4+PiArCj4+ Pj4+ICsgICAgIG1hc3RlciA9IGludGVsX2VuZ2luZV9sb29rdXBfdXNlcihzZXQtPmN0eC0+aTkx NSwgY2xhc3MsIGluc3RhbmNlKTsKPj4+Pj4gKyAgICAgaWYgKCFtYXN0ZXIpIHsKPj4+Pj4gKyAg ICAgICAgICAgICBEUk1fREVCVUcoIlVucmVjb2duaXNlZCBtYXN0ZXIgZW5naW5lOiB7IGNsYXNz OiVkLCBpbnN0YW5jZTolZCB9XG4iLAo+Pj4+PiArICAgICAgICAgICAgICAgICAgICAgICBjbGFz cywgaW5zdGFuY2UpOwo+Pj4+PiArICAgICAgICAgICAgIHJldHVybiAtRUlOVkFMOwo+Pj4+PiAr ICAgICB9Cj4+Pj4+ICsKPj4+Pj4gKyAgICAgaWYgKGdldF91c2VyKG51bV9ib25kcywgJmV4dC0+ bnVtX2JvbmRzKSkKPj4+Pj4gKyAgICAgICAgICAgICByZXR1cm4gLUVGQVVMVDsKPj4+Pgo+Pj4+ IFNob3VsZCBudW1fYm9uZHMgPiB2aXJ0dWFsLT5udW1fc2libGluZ3MgYmUgYW4gZXJyb3I/Cj4+ Pgo+Pj4gVGhleSBjb3VsZCBzcGVjaWZ5IHRoZSBzYW1lIGJvbmQgbXVsdGlwbGUgdGltZXMgZm9y IHdoYXRldmVyIHJlYXNvbiAoYW5kCj4+PiBwcm9iYWJseSBzaG91bGQgYWxsb3cgc2tpcHBpbmcg Tk9ORT8pLCBpZiB0aGUgdGFyZ2V0IGRvZXNuJ3QgZXhpc3QgdGhhdCdzCj4+PiBkZWZpbml0ZWx5 IGFuIGVycm9yLgo+Pgo+PiBTbyB3aGljaCBib25kIHdlIHBpY2sgaWYgdGhleSBzcGVjaWZ5IG11 bHRpcGxlIG9uZXM/IEp1c3QgdGhlIGZpcnN0IG9uZQo+PiBmb3VuZC4gSG0gYWN0dWFsbHkgSSB3 YXMgdGhpbmtpbmcgYWJvdXQgbWFraW5nIHN1cmUgZWFjaCBtYXN0ZXIgaXMgb25seQo+PiBzcGVj aWZpZWQgb25jZSwgbm90IHNpYmxpbmdzLiBGb3Igc2libGluZ3Mgd2UgaW5kZWVkIGRvIG5vdCBj YXJlLgo+IAo+IE5vLCBpdCdzIGEgbWFzayBvZiBpZiBwYXJlbnQgZXhlY3V0ZXMgb24gbWFzdGVy LCB1c2UgdGhpcyBzZXQgb2YKPiBjaGlsZHJlbi4KPiAKPiBJIHdhcyByZWFzb25hYmx5IGhhcHB5 IHRvIHVzZSBhIGN1bXVsYXRpdmUgbWFzayBpZiBtYXN0ZXIgaXMgc3BlY2lmaWVkCj4gYnkgbW9y ZSB0aGFuIG9uZSBib25kIGV4dDsgYnV0IG1heWJlIGl0IHNob3VsZCBiZSBhbiBpbnRlcnNlY3Rp b24uIEhtbS4KCkRvIHlvdSBzZWUgYSByZWFsaXN0aWMgYW5kIG1ha2luZyBzZW5zZSB1c2UgY2Fz ZSBmb3Igc3BlY2lmeWluZyB0aGUgc2FtZSAKbWFzdGVyIGluIG11bHRpcGxlIGJvbmRzPyBJZiBu b3QgSSdkIGp1c3QgZGlzYWxsb3cgaXQgYW5kIHRoZW4gd2UgZG9uJ3QgCmhhdmUgYSBxdWVzdGlv biBvZiB1bmlvbiB2cyBpbnRlcnNlY3Rpb24gcG9saWN5LgoKUmVnYXJkcywKClR2cnRrbwpfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFp bGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5m cmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZng=