All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Juergen Gross <jgross@suse.com>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Wei Liu <wl@xen.org>, Anthony Perard <anthony.perard@citrix.com>,
	Jan Beulich <jbeulich@suse.com>
Subject: Re: [PATCH 4/4] tools/libs/light: don't set errno to a negative value
Date: Fri, 22 Apr 2022 14:59:57 +0000	[thread overview]
Message-ID: <e7a1c235-1746-e3df-f3d5-77edb899b8a2@citrix.com> (raw)
In-Reply-To: <f70f7746-2e9d-3418-d198-aa42cb58c9ad@suse.com>

On 22/04/2022 15:55, Juergen Gross wrote:
> On 22.04.22 16:52, Andrew Cooper wrote:
>> On 20/04/2022 08:31, Juergen Gross wrote:
>>> Setting errno to a negative value makes no sense.
>>
>> Fixes: e78e8b9bb649b
>>
>>> Signed-off-by: Juergen Gross <jgross@suse.com>
>>
>> Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>
>
> Do you want me to send the patches with the Fixes tags added?
>
> TBH I didn't bother to do the research for those, as the wrong values
> don't seem to cause any harm today. I just stumbled over the issues
> and thought it would be a good idea to fix those.

Given that there's nothing else to adjust, I was thinking of just fixing
them on commit.

But we should backport these to all appropriate releases (cc Jan).

~Andrew

      reply	other threads:[~2022-04-22 15:00 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-20  7:31 [PATCH 0/4] tools/libs: don't set errno to negative values Juergen Gross
2022-04-20  7:31 ` [PATCH 1/4] tools/libs/evtchn: " Juergen Gross
2022-04-22 14:44   ` Andrew Cooper
2022-04-20  7:31 ` [PATCH 2/4] tools/libs/ctrl: don't set errno to a negative value Juergen Gross
2022-04-22 14:47   ` Andrew Cooper
2022-04-20  7:31 ` [PATCH 3/4] tools/libs/guest: " Juergen Gross
2022-04-22 14:49   ` Andrew Cooper
2022-04-20  7:31 ` [PATCH 4/4] tools/libs/light: " Juergen Gross
2022-04-22 14:52   ` Andrew Cooper
2022-04-22 14:55     ` Juergen Gross
2022-04-22 14:59       ` Andrew Cooper [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e7a1c235-1746-e3df-f3d5-77edb899b8a2@citrix.com \
    --to=andrew.cooper3@citrix.com \
    --cc=anthony.perard@citrix.com \
    --cc=jbeulich@suse.com \
    --cc=jgross@suse.com \
    --cc=wl@xen.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.