From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ferruh Yigit Subject: Re: [PATCH 03/17] net/fm10k/base: expose macros needed by DPDK Date: Sun, 5 Mar 2017 11:41:37 +0000 Message-ID: References: <20170303031727.461-1-qi.z.zhang@intel.com> <20170303031727.461-4-qi.z.zhang@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Cc: helin.zhang@intel.com, dev@dpdk.org To: Qi Zhang , jing.d.chen@intel.com Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id E01B698 for ; Sun, 5 Mar 2017 12:41:41 +0100 (CET) In-Reply-To: <20170303031727.461-4-qi.z.zhang@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 3/3/2017 3:17 AM, Qi Zhang wrote: > Some defines were previously wrapped to strip them from opensource driver > builds, but these are required by DPDK. Change the wrapping of these so > that the DPDK gets them as long as DPDK_SUPPORT is correctly added as a > strip flag, while we can remove the reduandant ones in fm10k_osdep.h. s/reduandant/redundant > > Signed-off-by: Qi Zhang <...> > diff --git a/drivers/net/fm10k/base/fm10k_type.h b/drivers/net/fm10k/base/fm10k_type.h > index fe3e498..8ddfd49 100644 > --- a/drivers/net/fm10k/base/fm10k_type.h > +++ b/drivers/net/fm10k/base/fm10k_type.h > @@ -40,6 +40,9 @@ struct fm10k_hw; > #include "fm10k_osdep.h" > #include "fm10k_mbx.h" > > +#if !defined(EXTERNAL_RELEASE) || defined(DPDK_SUPPORT) >>From commit log what I understand is, released code is coming from a shared code by some #ifdefs stripped based on a strip flag configuration. If that is the case, these #ifdefs should not be released code, they should be stripped but only #defines should remain, is this correct? > +#define FM10K_INTEL_VENDOR_ID 0x8086 > +#endif > #define FM10K_DEV_ID_PF 0x15A4 > #define FM10K_DEV_ID_VF 0x15A5 > #ifdef BOULDER_RAPIDS_HW <...>