From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64504C64EC4 for ; Wed, 8 Mar 2023 03:51:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229852AbjCHDvq (ORCPT ); Tue, 7 Mar 2023 22:51:46 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57890 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229468AbjCHDvo (ORCPT ); Tue, 7 Mar 2023 22:51:44 -0500 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 49C63A8382; Tue, 7 Mar 2023 19:51:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Sender:Reply-To:Content-ID:Content-Description; bh=/mWTJhwI3ECRxvq10RxYV3el2FK8VbqEYNOHUpoMPMY=; b=WIRvsl3sDr6h2G0SCbUzG7iFV7 qXyrs1OZayoRULdN+H3BtXEX1TnDJZOkuSUMvZmFaQsH0ZjBsF54inCPOFR7y81EAxUpCGyl5a5Pz R4l/XPTZsaaymXgRrkL0nuc7lQFL0mWOgvBtWXdCIeyOw7F69tWfbg+nwuOWqjmafCPbEU4hEvD8z zAfHHClKQWTywyopTX/D7uGR221oE+b5KDq4TaFgVJYoIzYgR1A7SdqQqjiPFtbXNP6W0Who1D7t0 dLXgsSm7TR9WY7tsHmTBuETwJysHVzyOfPdmX9mzan6ZY3TbLDzg/E8sB6kyIcag06PRSgFD9tmk3 D20mZYyw==; Received: from [2601:1c2:980:9ec0::df2f] by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1pZkq4-003Nu7-GL; Wed, 08 Mar 2023 03:51:40 +0000 Message-ID: Date: Tue, 7 Mar 2023 19:51:39 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v3 0/3] Add RISC-V 32 NOMMU support Content-Language: en-US To: Damien Le Moal , Jesse Taube , linux-riscv@lists.infradead.org Cc: linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Yimin Gu , Damien Le Moal , Stephen Boyd , Michael Turquette , Waldemar Brodkorb , Albert Ou , Palmer Dabbelt , Paul Walmsley References: <20230301002657.352637-1-Mr.Bossman075@gmail.com> <42446784-a88b-df09-41e9-5f685b4df6ee@infradead.org> <556ce787-80eb-dc48-f8d6-83e415538e36@opensource.wdc.com> <62852ee1-3763-3323-c3a8-f1e84f70204a@infradead.org> <1d858dbb-ae85-95a0-3e46-b67017733c04@infradead.org> <7280914e-59e3-ba6d-4324-a29c1c0b4ce8@gmail.com> <2ebe4bc5-c11c-89b1-2644-358dc12bdfa5@infradead.org> From: Randy Dunlap In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/7/23 19:42, Damien Le Moal wrote: > On 3/8/23 12:23, Randy Dunlap wrote: >>>> OK, I don't know how it happened. I cannot reproduce it now. >>>> The failing .config files has CONFIG_MMU is not set (for RV32I), which >>>> appears to be impossible. >>> These patches add `CONFIG_MMU is not set` (for RV32I). >>> But no worries it seems to be a non issue  now. >>> >>> Your thoughts Damien? >>> >> >> Thanks for reminding me. >> >> With these 3 patches applied to linux-next-20230307, >> I still get this build error. > > Does this help ? > > diff --git a/drivers/soc/canaan/Kconfig b/drivers/soc/canaan/Kconfig > index 2527cf5757ec..7796c5f1d109 100644 > --- a/drivers/soc/canaan/Kconfig > +++ b/drivers/soc/canaan/Kconfig > @@ -4,7 +4,8 @@ config SOC_K210_SYSCTL > bool "Canaan Kendryte K210 SoC system controller" > depends on RISCV && SOC_CANAAN && OF > default SOC_CANAAN > - select PM > - select MFD_SYSCON > + select COMMON_CLK_K210 > + select PM > + select MFD_SYSCON > help > Canaan Kendryte K210 SoC system controller driver. > > (just noticed that there are whitespace errors here...) Yes, this patch allows it to build cleanly. Thanks. I didn't test any of the below changes. > Note that both the sysctl and clk driver depend on RISCV. I think these should > probably also depend on 64BIT, and eventually add a "|| COMPILE_TEST" as well. > So something like this: > > diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig > index b6c5bf69a2b2..657a36d2640d 100644 > --- a/drivers/clk/Kconfig > +++ b/drivers/clk/Kconfig > @@ -431,7 +431,7 @@ config COMMON_CLK_FIXED_MMIO > > config COMMON_CLK_K210 > bool "Clock driver for the Canaan Kendryte K210 SoC" > - depends on OF && RISCV && SOC_CANAAN > + depends on OF && RISCV && SOC_CANAAN && (64BIT || COMPILE_TEST) > default SOC_CANAAN > help > Support for the Canaan Kendryte K210 RISC-V SoC clocks. > diff --git a/drivers/soc/canaan/Kconfig b/drivers/soc/canaan/Kconfig > index 2527cf5757ec..1745a614d2a7 100644 > --- a/drivers/soc/canaan/Kconfig > +++ b/drivers/soc/canaan/Kconfig > @@ -2,9 +2,10 @@ > > config SOC_K210_SYSCTL > bool "Canaan Kendryte K210 SoC system controller" > - depends on RISCV && SOC_CANAAN && OF > + depends on RISCV && SOC_CANAAN && OF && (64BIT || COMPILE_TEST) > default SOC_CANAAN > - select PM > - select MFD_SYSCON > + select COMMON_CLK_K210 > + select PM > + select MFD_SYSCON > help > Canaan Kendryte K210 SoC system controller driver. > > COMPILE_TEST is optional though, but I do not see any reason why not eventhough > in practice these drivers will likely never end up in 32-bits SoC. > > -- ~Randy From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0BFB3C6FD20 for ; Wed, 8 Mar 2023 03:51:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=4lhOo95FyWUFIzghVmXm0bACgzaqLpYBzFxnOHFJ9Mk=; b=ZHEADTKTZwvcna fFCCCgmUcV8Q/c2KuG+XbI2uPId0WIIt+aN2QXSQ5+IzpG/xPMPq3PCEEAbv/TfMLIeH8RjPVzmfF 2Ehi7VMW6POWVfc/aQuaGnZjLpmn25pO+bNUe4SOey2RaTKQ8oVx7vuswJlW8hcbBv0BSKd0ZGWVg c/ufpdUJ05F42eTrOY6PnF6Mwd3v6+teiz6yGCZ9uL97+nqBGzUVTCxYOKKP6NX6C4m0TFa3VKr96 FobqyDh66S2pC4GnpEm8hLfcyTTyODsnuWMYWgGAZcaFmyZqjG2MBZ/chCD2dwrVURcmdrb/UG+M/ TVnDwKuxBr6yLIUDLQDA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pZkq6-003Nuv-K2; Wed, 08 Mar 2023 03:51:42 +0000 Received: from [2601:1c2:980:9ec0::df2f] by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1pZkq4-003Nu7-GL; Wed, 08 Mar 2023 03:51:40 +0000 Message-ID: Date: Tue, 7 Mar 2023 19:51:39 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v3 0/3] Add RISC-V 32 NOMMU support Content-Language: en-US To: Damien Le Moal , Jesse Taube , linux-riscv@lists.infradead.org Cc: linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Yimin Gu , Damien Le Moal , Stephen Boyd , Michael Turquette , Waldemar Brodkorb , Albert Ou , Palmer Dabbelt , Paul Walmsley References: <20230301002657.352637-1-Mr.Bossman075@gmail.com> <42446784-a88b-df09-41e9-5f685b4df6ee@infradead.org> <556ce787-80eb-dc48-f8d6-83e415538e36@opensource.wdc.com> <62852ee1-3763-3323-c3a8-f1e84f70204a@infradead.org> <1d858dbb-ae85-95a0-3e46-b67017733c04@infradead.org> <7280914e-59e3-ba6d-4324-a29c1c0b4ce8@gmail.com> <2ebe4bc5-c11c-89b1-2644-358dc12bdfa5@infradead.org> From: Randy Dunlap In-Reply-To: X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org CgpPbiAzLzcvMjMgMTk6NDIsIERhbWllbiBMZSBNb2FsIHdyb3RlOgo+IE9uIDMvOC8yMyAxMjoy MywgUmFuZHkgRHVubGFwIHdyb3RlOgo+Pj4+IE9LLCBJIGRvbid0IGtub3cgaG93IGl0IGhhcHBl bmVkLiBJIGNhbm5vdCByZXByb2R1Y2UgaXQgbm93Lgo+Pj4+IFRoZSBmYWlsaW5nIC5jb25maWcg ZmlsZXMgaGFzIENPTkZJR19NTVUgaXMgbm90IHNldCAoZm9yIFJWMzJJKSwgd2hpY2gKPj4+PiBh cHBlYXJzIHRvIGJlIGltcG9zc2libGUuCj4+PiBUaGVzZSBwYXRjaGVzIGFkZCBgQ09ORklHX01N VSBpcyBub3Qgc2V0YCAoZm9yIFJWMzJJKS4KPj4+IEJ1dCBubyB3b3JyaWVzIGl0IHNlZW1zIHRv IGJlIGEgbm9uIGlzc3VlwqAgbm93Lgo+Pj4KPj4+IFlvdXIgdGhvdWdodHMgRGFtaWVuPwo+Pj4K Pj4KPj4gVGhhbmtzIGZvciByZW1pbmRpbmcgbWUuCj4+Cj4+IFdpdGggdGhlc2UgMyBwYXRjaGVz IGFwcGxpZWQgdG8gbGludXgtbmV4dC0yMDIzMDMwNywKPj4gSSBzdGlsbCBnZXQgdGhpcyBidWls ZCBlcnJvci4KPiAKPiBEb2VzIHRoaXMgaGVscCA/Cj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMv c29jL2NhbmFhbi9LY29uZmlnIGIvZHJpdmVycy9zb2MvY2FuYWFuL0tjb25maWcKPiBpbmRleCAy NTI3Y2Y1NzU3ZWMuLjc3OTZjNWYxZDEwOSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL3NvYy9jYW5h YW4vS2NvbmZpZwo+ICsrKyBiL2RyaXZlcnMvc29jL2NhbmFhbi9LY29uZmlnCj4gQEAgLTQsNyAr NCw4IEBAIGNvbmZpZyBTT0NfSzIxMF9TWVNDVEwKPiAgICAgICAgIGJvb2wgIkNhbmFhbiBLZW5k cnl0ZSBLMjEwIFNvQyBzeXN0ZW0gY29udHJvbGxlciIKPiAgICAgICAgIGRlcGVuZHMgb24gUklT Q1YgJiYgU09DX0NBTkFBTiAmJiBPRgo+ICAgICAgICAgZGVmYXVsdCBTT0NfQ0FOQUFOCj4gLSAg ICAgICAgc2VsZWN0IFBNCj4gLSAgICAgICAgc2VsZWN0IE1GRF9TWVNDT04KPiArICAgICAgIHNl bGVjdCBDT01NT05fQ0xLX0syMTAKPiArICAgICAgIHNlbGVjdCBQTQo+ICsgICAgICAgc2VsZWN0 IE1GRF9TWVNDT04KPiAgICAgICAgIGhlbHAKPiAgICAgICAgICAgQ2FuYWFuIEtlbmRyeXRlIEsy MTAgU29DIHN5c3RlbSBjb250cm9sbGVyIGRyaXZlci4KPiAKPiAoanVzdCBub3RpY2VkIHRoYXQg dGhlcmUgYXJlIHdoaXRlc3BhY2UgZXJyb3JzIGhlcmUuLi4pCgpZZXMsIHRoaXMgcGF0Y2ggYWxs b3dzIGl0IHRvIGJ1aWxkIGNsZWFubHkuClRoYW5rcy4KCkkgZGlkbid0IHRlc3QgYW55IG9mIHRo ZSBiZWxvdyBjaGFuZ2VzLgoKPiBOb3RlIHRoYXQgYm90aCB0aGUgc3lzY3RsIGFuZCBjbGsgZHJp dmVyIGRlcGVuZCBvbiBSSVNDVi4gSSB0aGluayB0aGVzZSBzaG91bGQKPiBwcm9iYWJseSBhbHNv IGRlcGVuZCBvbiA2NEJJVCwgYW5kIGV2ZW50dWFsbHkgYWRkIGEgInx8IENPTVBJTEVfVEVTVCIg YXMgd2VsbC4KPiBTbyBzb21ldGhpbmcgbGlrZSB0aGlzOgo+IAo+IGRpZmYgLS1naXQgYS9kcml2 ZXJzL2Nsay9LY29uZmlnIGIvZHJpdmVycy9jbGsvS2NvbmZpZwo+IGluZGV4IGI2YzViZjY5YTJi Mi4uNjU3YTM2ZDI2NDBkIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvY2xrL0tjb25maWcKPiArKysg Yi9kcml2ZXJzL2Nsay9LY29uZmlnCj4gQEAgLTQzMSw3ICs0MzEsNyBAQCBjb25maWcgQ09NTU9O X0NMS19GSVhFRF9NTUlPCj4gCj4gIGNvbmZpZyBDT01NT05fQ0xLX0syMTAKPiAgICAgICAgIGJv b2wgIkNsb2NrIGRyaXZlciBmb3IgdGhlIENhbmFhbiBLZW5kcnl0ZSBLMjEwIFNvQyIKPiAtICAg ICAgIGRlcGVuZHMgb24gT0YgJiYgUklTQ1YgJiYgU09DX0NBTkFBTgo+ICsgICAgICAgZGVwZW5k cyBvbiBPRiAmJiBSSVNDViAmJiBTT0NfQ0FOQUFOICYmICg2NEJJVCB8fCBDT01QSUxFX1RFU1Qp Cj4gICAgICAgICBkZWZhdWx0IFNPQ19DQU5BQU4KPiAgICAgICAgIGhlbHAKPiAgICAgICAgICAg U3VwcG9ydCBmb3IgdGhlIENhbmFhbiBLZW5kcnl0ZSBLMjEwIFJJU0MtViBTb0MgY2xvY2tzLgo+ IGRpZmYgLS1naXQgYS9kcml2ZXJzL3NvYy9jYW5hYW4vS2NvbmZpZyBiL2RyaXZlcnMvc29jL2Nh bmFhbi9LY29uZmlnCj4gaW5kZXggMjUyN2NmNTc1N2VjLi4xNzQ1YTYxNGQyYTcgMTAwNjQ0Cj4g LS0tIGEvZHJpdmVycy9zb2MvY2FuYWFuL0tjb25maWcKPiArKysgYi9kcml2ZXJzL3NvYy9jYW5h YW4vS2NvbmZpZwo+IEBAIC0yLDkgKzIsMTAgQEAKPiAKPiAgY29uZmlnIFNPQ19LMjEwX1NZU0NU TAo+ICAgICAgICAgYm9vbCAiQ2FuYWFuIEtlbmRyeXRlIEsyMTAgU29DIHN5c3RlbSBjb250cm9s bGVyIgo+IC0gICAgICAgZGVwZW5kcyBvbiBSSVNDViAmJiBTT0NfQ0FOQUFOICYmIE9GCj4gKyAg ICAgICBkZXBlbmRzIG9uIFJJU0NWICYmIFNPQ19DQU5BQU4gJiYgT0YgJiYgKDY0QklUIHx8IENP TVBJTEVfVEVTVCkKPiAgICAgICAgIGRlZmF1bHQgU09DX0NBTkFBTgo+IC0gICAgICAgIHNlbGVj dCBQTQo+IC0gICAgICAgIHNlbGVjdCBNRkRfU1lTQ09OCj4gKyAgICAgICBzZWxlY3QgQ09NTU9O X0NMS19LMjEwCj4gKyAgICAgICBzZWxlY3QgUE0KPiArICAgICAgIHNlbGVjdCBNRkRfU1lTQ09O Cj4gICAgICAgICBoZWxwCj4gICAgICAgICAgIENhbmFhbiBLZW5kcnl0ZSBLMjEwIFNvQyBzeXN0 ZW0gY29udHJvbGxlciBkcml2ZXIuCj4gCj4gQ09NUElMRV9URVNUIGlzIG9wdGlvbmFsIHRob3Vn aCwgYnV0IEkgZG8gbm90IHNlZSBhbnkgcmVhc29uIHdoeSBub3QgZXZlbnRob3VnaAo+IGluIHBy YWN0aWNlIHRoZXNlIGRyaXZlcnMgd2lsbCBsaWtlbHkgbmV2ZXIgZW5kIHVwIGluIDMyLWJpdHMg U29DLgo+IAo+IAoKLS0gCn5SYW5keQoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KbGludXgtcmlzY3YgbWFpbGluZyBsaXN0CmxpbnV4LXJpc2N2QGxpc3Rz LmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5m by9saW51eC1yaXNjdgo=