From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50F9DC2B9F4 for ; Mon, 14 Jun 2021 17:38:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 37684613B9 for ; Mon, 14 Jun 2021 17:38:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233681AbhFNRkJ (ORCPT ); Mon, 14 Jun 2021 13:40:09 -0400 Received: from mga17.intel.com ([192.55.52.151]:29560 "EHLO mga17.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233178AbhFNRkJ (ORCPT ); Mon, 14 Jun 2021 13:40:09 -0400 IronPort-SDR: 0K5+nJVSaOldVUl8X3+9rpHkJhL8eScP03rX0MTR486arFFpERIG3e7U1z3wn56pj5khEEmrB3 lhYEtKs0Lq/A== X-IronPort-AV: E=McAfee;i="6200,9189,10015"; a="186223538" X-IronPort-AV: E=Sophos;i="5.83,273,1616482800"; d="scan'208";a="186223538" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Jun 2021 10:38:06 -0700 IronPort-SDR: 1/SjHrDv+mFd8hSdfVG7Yh6FemGNmTKCSMk0VnAwUgDwdX68ynh3N0RMGzMSmk5lkT5e+Wunxu 0INLcb17TqOQ== X-IronPort-AV: E=Sophos;i="5.83,273,1616482800"; d="scan'208";a="449966692" Received: from rhweight-mobl2.amr.corp.intel.com (HELO [10.0.2.4]) ([10.255.228.61]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Jun 2021 10:38:06 -0700 Subject: Re: [PATCH 2/8] fpga: stratix10-soc: Add missing fpga_mgr_free() call To: Greg KH , Moritz Fischer Cc: linux-fpga@vger.kernel.org, Xu Yilun References: <20210614170909.232415-1-mdf@kernel.org> <20210614170909.232415-3-mdf@kernel.org> From: Russ Weight Message-ID: Date: Mon, 14 Jun 2021 10:38:01 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-fpga@vger.kernel.org On 6/14/21 10:30 AM, Greg KH wrote: > On Mon, Jun 14, 2021 at 10:09:03AM -0700, Moritz Fischer wrote: >> From: Russ Weight >> >> The stratix10-soc driver uses fpga_mgr_create() function and is therefore >> responsible to call fpga_mgr_free() to release the class driver resources. >> Add a missing call to fpga_mgr_free in the s10_remove() function. >> >> Signed-off-by: Russ Weight >> Reviewed-by: Xu Yilun >> Signed-off-by: Moritz Fischer >> --- >> drivers/fpga/stratix10-soc.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/fpga/stratix10-soc.c b/drivers/fpga/stratix10-soc.c >> index 657a70c5fc99..9e34bbbce26e 100644 >> --- a/drivers/fpga/stratix10-soc.c >> +++ b/drivers/fpga/stratix10-soc.c >> @@ -454,6 +454,7 @@ static int s10_remove(struct platform_device *pdev) >> struct s10_priv *priv = mgr->priv; >> >> fpga_mgr_unregister(mgr); >> + fpga_mgr_free(mgr); >> stratix10_svc_free_channel(priv->chan); >> >> return 0; >> -- >> 2.31.1 >> > Does this fix a specific commit? Does it need a Fixes: and cc: stable > line too? It fixes: e7eef1d7633a fpga: add intel stratix10 soc fpga manager driver And yes, I think it needs the Fixes: and cc: stable lines Moritz: Let me know if you want me to add the tags Greg: Patch 1 in this series could be viewed as a fix for a particular commit as well, but the code being deleted is harmless/unused. I'm assuming it does NOT need the Fixes: and cc: stable lines? - Russ > > thanks, > > greg k-h