From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B26FFC43381 for ; Tue, 26 Mar 2019 13:49:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 81B312075C for ; Tue, 26 Mar 2019 13:49:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731644AbfCZNta (ORCPT ); Tue, 26 Mar 2019 09:49:30 -0400 Received: from www1102.sakura.ne.jp ([219.94.129.142]:18541 "EHLO www1102.sakura.ne.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726111AbfCZNta (ORCPT ); Tue, 26 Mar 2019 09:49:30 -0400 Received: from fsav302.sakura.ne.jp (fsav302.sakura.ne.jp [153.120.85.133]) by www1102.sakura.ne.jp (8.15.2/8.15.2) with ESMTP id x2QDnGT8061775; Tue, 26 Mar 2019 22:49:17 +0900 (JST) (envelope-from katsuhiro@katsuster.net) Received: from www1102.sakura.ne.jp (219.94.129.142) by fsav302.sakura.ne.jp (F-Secure/fsigk_smtp/530/fsav302.sakura.ne.jp); Tue, 26 Mar 2019 22:49:16 +0900 (JST) X-Virus-Status: clean(F-Secure/fsigk_smtp/530/fsav302.sakura.ne.jp) Received: from [192.168.1.2] (118.153.231.153.ap.dti.ne.jp [153.231.153.118]) (authenticated bits=0) by www1102.sakura.ne.jp (8.15.2/8.15.2) with ESMTPSA id x2QDnGHD061770 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NO); Tue, 26 Mar 2019 22:49:16 +0900 (JST) (envelope-from katsuhiro@katsuster.net) Subject: Re: [PATCH v2] arm64: dts: rockchip: add rk3399 UART DMAs To: Robin Murphy , Heiko Stuebner Cc: linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20190321162244.10080-1-katsuhiro@katsuster.net> <8309531.dRdlsDmmhi@phil> From: Katsuhiro Suzuki Message-ID: Date: Tue, 26 Mar 2019 22:49:16 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Robin, Sorry for inconvenience. Since I don't adhere enabling DMA for UARTs, please revert my patch if you need. BTW, there are DMA properties in RK3328 device-tree like as this patch. RK3328 UART DMA could not work correctly too...?? Best Regards, Katsuhiro Suzuki On 2019/03/26 20:48, Robin Murphy wrote: > On 25/03/2019 12:34, Heiko Stuebner wrote: >> Am Donnerstag, 21. März 2019, 17:22:44 CET schrieb Katsuhiro Suzuki: >>> Add UART dma channels as specified by the rk3399 TRM. >>> >>> Refer: >>> RK3399 TRM V1.4: Chapter 12 DMA Controller >>> >>> Signed-off-by: Katsuhiro Suzuki >> >> applied for 5.2 > > As a heads-up, I did manage to try my board with this patch applied over > the weekend, and it makes probing the bluetooth adapter fail with > communication errors, so I'm not sure the 8250 and pl330 drivers are > really cooperating well enough :( > > Robin. > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Katsuhiro Suzuki Subject: Re: [PATCH v2] arm64: dts: rockchip: add rk3399 UART DMAs Date: Tue, 26 Mar 2019 22:49:16 +0900 Message-ID: References: <20190321162244.10080-1-katsuhiro@katsuster.net> <8309531.dRdlsDmmhi@phil> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Robin Murphy , Heiko Stuebner Cc: linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org List-Id: linux-rockchip.vger.kernel.org SGVsbG8gUm9iaW4sCgpTb3JyeSBmb3IgaW5jb252ZW5pZW5jZS4gU2luY2UgSSBkb24ndCBhZGhl cmUgZW5hYmxpbmcgRE1BIGZvciBVQVJUcywKcGxlYXNlIHJldmVydCBteSBwYXRjaCBpZiB5b3Ug bmVlZC4KCkJUVywgdGhlcmUgYXJlIERNQSBwcm9wZXJ0aWVzIGluIFJLMzMyOCBkZXZpY2UtdHJl ZSBsaWtlIGFzIHRoaXMgcGF0Y2guClJLMzMyOCBVQVJUIERNQSBjb3VsZCBub3Qgd29yayBjb3Jy ZWN0bHkgdG9vLi4uPz8KCkJlc3QgUmVnYXJkcywKS2F0c3VoaXJvIFN1enVraQoKCk9uIDIwMTkv MDMvMjYgMjA6NDgsIFJvYmluIE11cnBoeSB3cm90ZToKPiBPbiAyNS8wMy8yMDE5IDEyOjM0LCBI ZWlrbyBTdHVlYm5lciB3cm90ZToKPj4gQW0gRG9ubmVyc3RhZywgMjEuIE3DpHJ6IDIwMTksIDE3 OjIyOjQ0IENFVCBzY2hyaWViIEthdHN1aGlybyBTdXp1a2k6Cj4+PiBBZGQgVUFSVCBkbWEgY2hh bm5lbHMgYXMgc3BlY2lmaWVkIGJ5IHRoZSByazMzOTkgVFJNLgo+Pj4KPj4+IFJlZmVyOgo+Pj4g UkszMzk5IFRSTSBWMS40OiBDaGFwdGVyIDEyIERNQSBDb250cm9sbGVyCj4+Pgo+Pj4gU2lnbmVk LW9mZi1ieTogS2F0c3VoaXJvIFN1enVraSA8a2F0c3VoaXJvQGthdHN1c3Rlci5uZXQ+Cj4+Cj4+ IGFwcGxpZWQgZm9yIDUuMgo+IAo+IEFzIGEgaGVhZHMtdXAsIEkgZGlkIG1hbmFnZSB0byB0cnkg bXkgYm9hcmQgd2l0aCB0aGlzIHBhdGNoIGFwcGxpZWQgb3ZlciAKPiB0aGUgd2Vla2VuZCwgYW5k IGl0IG1ha2VzIHByb2JpbmcgdGhlIGJsdWV0b290aCBhZGFwdGVyIGZhaWwgd2l0aCAKPiBjb21t dW5pY2F0aW9uIGVycm9ycywgc28gSSdtIG5vdCBzdXJlIHRoZSA4MjUwIGFuZCBwbDMzMCBkcml2 ZXJzIGFyZSAKPiByZWFsbHkgY29vcGVyYXRpbmcgd2VsbCBlbm91Z2ggOigKPiAKPiBSb2Jpbi4K PiAKCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51 eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVh ZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1h cm0ta2VybmVsCg==