Re: [PATCH] staging: media: atomisp: cleaning up sh_css.c

[Hans Verkuil <hverkuil@xs4all.nl>]

Hi Martiros,

If you look at other patch series, you'll see that they follow this pattern:

[PATCH x/y]

and for the cover letter: [PATCH 0/y]

It's recommended to follow that rule.

On 15/04/2021 02:50, Martiros Shakhzadyan wrote:
> The following set of patches for sh_css.c aims to resolve coding style issues
> and remove redundancies.
> 
> Martiros Shakhzadyan (9):
>   staging: media: atomisp: [1/6] Fix sh_css.c brace coding style issues
>   staging: media: atomisp: [2/6] Fix sh_css.c brace coding style issues
>   staging: media: atomisp: [3/6] Fix sh_css.c brace coding style issues
>   staging: media: atomisp: [4/6] Fix sh_css.c brace coding style issues
>   staging: media: atomisp: [5/6] Fix sh_css.c brace coding style issues
>   staging: media: atomisp: [6/6] Fix sh_css.c brace coding style issues\

Why split this up in 6 patches? Just combine it in one. It's all the same thing
for the same source.

>   staging: media: atomisp: Use goto instead of return in ia_css_init()
>   staging: media: atomisp: [1/2] Remove redundant assertions in sh_css.c
>   staging: media: atomisp: [2/2] Remove redundant assertions in sh_css.c

Ditto for these two.

Regards,

	Hans

> 
>  drivers/staging/media/atomisp/pci/sh_css.c | 266 ++++++++-------------
>  1 file changed, 105 insertions(+), 161 deletions(-)
>