* Re: media/master bisection: v4l2-compliance-vivid.device-presence on qemu_x86_64 [not found] <60ed7c49.1c69fb81.518d4.80d2@mx.google.com> @ 2021-07-29 7:05 ` Guillaume Tucker 2021-07-29 7:25 ` Hans Verkuil 0 siblings, 1 reply; 10+ messages in thread From: Guillaume Tucker @ 2021-07-29 7:05 UTC (permalink / raw) To: Linux Media Mailing List; +Cc: Kees Cook, kernelci-results Hello, FYI - This bisection was run because the KernelCI v4l2-compliance tests on vivid failed to find a media device. Regression details can be found here: https://linux.kernelci.org/test/job/media/branch/master/kernel/v5.14-rc1/plan/v4l2-compliance-vivid/ This doesn't really seem to be a kernel config issue per se, the driver just wasn't built because of the DRM Kconfig change. Instead I've added CONFIG_FB to the fragment used by KernelCI to enable the vivid driver: https://github.com/kernelci/kernelci-core/pull/776/files Does that sound like the best approach? Trying to enable CONFIG_FB in the vivid Kconfig causes cyclic dependencies and seems backwards, so I thought that was the way to go. The drm-tip tree is not currently covered by KernelCI, I guess it would have caught the issue before it landed in mainline. We're planning to enable it again, mainly to run IGT but it seems like some basic checks for drivers that depend on some DRM configs would be useful too. Maybe doing that on linux-next too would be useful. Best wishes, Guillaume On 13/07/2021 12:43, KernelCI bot wrote: > * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * > * This automated bisection report was sent to you on the basis * > * that you may be involved with the breaking commit it has * > * found. No manual investigation has been done to verify it, * > * and the root cause of the problem may be somewhere else. * > * * > * If you do send a fix, please include this trailer: * > * Reported-by: "kernelci.org bot" <bot@kernelci.org> * > * * > * Hope this helps! * > * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * > > media/master bisection: v4l2-compliance-vivid.device-presence on qemu_x86_64 > > Summary: > Start: e73f0f0ee754 Linux 5.14-rc1 > Plain log: https://storage.kernelci.org/media/master/v5.14-rc1/x86_64/x86_64_defconfig+virtualvideo/gcc-8/lab-collabora/v4l2-compliance-vivid-qemu_x86_64.txt > HTML log: https://storage.kernelci.org/media/master/v5.14-rc1/x86_64/x86_64_defconfig+virtualvideo/gcc-8/lab-collabora/v4l2-compliance-vivid-qemu_x86_64.html > Result: f611b1e7624c drm: Avoid circular dependencies for CONFIG_FB > > Checks: > revert: PASS > verify: PASS > > Parameters: > Tree: media > URL: https://git.linuxtv.org/media_tree.git > Branch: master > Target: qemu_x86_64 > CPU arch: x86_64 > Lab: lab-collabora > Compiler: gcc-8 > Config: x86_64_defconfig+virtualvideo > Test case: v4l2-compliance-vivid.device-presence > > Breaking commit found: > > ------------------------------------------------------------------------------- > commit f611b1e7624ccdbd495c19e9805629e22265aa16 > Author: Kees Cook <keescook@chromium.org> > Date: Wed Jun 2 14:52:50 2021 -0700 > > drm: Avoid circular dependencies for CONFIG_FB > > When cleaning up other drm config dependencies, it is too easy to create > larger problems. Instead, mark CONFIG_FB as a "depends": > > drivers/gpu/drm/Kconfig:74:error: recursive dependency detected! > > Suggested-by: Arnd Bergmann <arnd@kernel.org> > Link: https://lore.kernel.org/lkml/CAK8P3a3jUQs6c5tESSNMbqfuymewj9FhqRizyHcfOXf8Rgy-nA@mail.gmail.com/ > Signed-off-by: Kees Cook <keescook@chromium.org> > [danvet: Rebase, the symbol has changed.] > Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch> > Link: https://patchwork.freedesktop.org/patch/msgid/20210602215252.695994-2-keescook@chromium.org > > diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig > index 594ac6c3a1f4..56a55a6e6239 100644 > --- a/drivers/gpu/drm/Kconfig > +++ b/drivers/gpu/drm/Kconfig > @@ -98,8 +98,8 @@ config DRM_DEBUG_DP_MST_TOPOLOGY_REFS > config DRM_FBDEV_EMULATION > bool "Enable legacy fbdev support for your modesetting driver" > depends on DRM > + depends on FB > select DRM_KMS_HELPER > - select FB > select FB_CFB_FILLRECT > select FB_CFB_COPYAREA > select FB_CFB_IMAGEBLIT > ------------------------------------------------------------------------------- > > > Git bisection log: > > ------------------------------------------------------------------------------- > git bisect start > # good: [50e7a31d30e8221632675abed3be306382324ca2] media: Fix Media Controller API config checks > git bisect good 50e7a31d30e8221632675abed3be306382324ca2 > # bad: [e73f0f0ee7541171d89f2e2491130c7771ba58d3] Linux 5.14-rc1 > git bisect bad e73f0f0ee7541171d89f2e2491130c7771ba58d3 > # bad: [e058a84bfddc42ba356a2316f2cf1141974625c9] Merge tag 'drm-next-2021-07-01' of git://anongit.freedesktop.org/drm/drm > git bisect bad e058a84bfddc42ba356a2316f2cf1141974625c9 > # good: [a6eaf3850cb171c328a8b0db6d3c79286a1eba9d] Merge tag 'sched-urgent-2021-06-30' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip > git bisect good a6eaf3850cb171c328a8b0db6d3c79286a1eba9d > # good: [007b312c6f294770de01fbc0643610145012d244] Merge tag 'mac80211-next-for-net-next-2021-06-25' of git://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211-next > git bisect good 007b312c6f294770de01fbc0643610145012d244 > # good: [18703923a66aecf6f7ded0e16d22eb412ddae72f] drm/amdgpu: Fix incorrect register offsets for Sienna Cichlid > git bisect good 18703923a66aecf6f7ded0e16d22eb412ddae72f > # bad: [334200bf52f0637a5ab8331c557dfcecbb9c30fa] Merge tag 'drm-msm-next-2021-06-23b' of https://gitlab.freedesktop.org/drm/msm into drm-next > git bisect bad 334200bf52f0637a5ab8331c557dfcecbb9c30fa > # bad: [c707b73f0cfb1acc94a20389aecde65e6385349b] Merge tag 'amd-drm-next-5.14-2021-06-09' of https://gitlab.freedesktop.org/agd5f/linux into drm-next > git bisect bad c707b73f0cfb1acc94a20389aecde65e6385349b > # good: [caa18dd6dd9305d52943a6b59f410cbc960ad0a0] drm/amd/display: force CP to DESIRED when removing display > git bisect good caa18dd6dd9305d52943a6b59f410cbc960ad0a0 > # bad: [691cf8cd7a531dbfcc29d09a23c509a86fd9b24f] drm/amdgpu: use correct rounding macro for 64-bit > git bisect bad 691cf8cd7a531dbfcc29d09a23c509a86fd9b24f > # bad: [2fdcb55dfc86835e4845e3f422180b5596d23cb4] drm/amdkfd: use resource cursor in svm_migrate_copy_to_vram v2 > git bisect bad 2fdcb55dfc86835e4845e3f422180b5596d23cb4 > # bad: [6c3f953381e526a1623d4575660afae8b19ffa20] drm/sti/sti_hqvdp: Fix incorrectly named function 'sti_hqvdp_vtg_cb()' > git bisect bad 6c3f953381e526a1623d4575660afae8b19ffa20 > # bad: [5ea4dba68305d9648b9dba30036cc36d4e877bca] drm/msm/a6xx: add CONFIG_QCOM_LLCC dependency > git bisect bad 5ea4dba68305d9648b9dba30036cc36d4e877bca > # good: [4a888ba03fd97d1cb0253581973533965bf348c4] drm/vgem/vgem_drv: Standard comment blocks should not use kernel-doc format > git bisect good 4a888ba03fd97d1cb0253581973533965bf348c4 > # good: [c5ef15ae09637fb51ae43e1d1d98329d67dd4fd6] video: fbdev: atyfb: mach64_cursor.c: deleted the repeated word > git bisect good c5ef15ae09637fb51ae43e1d1d98329d67dd4fd6 > # bad: [f611b1e7624ccdbd495c19e9805629e22265aa16] drm: Avoid circular dependencies for CONFIG_FB > git bisect bad f611b1e7624ccdbd495c19e9805629e22265aa16 > # good: [ff323d6d72e1e4971c8ba9e2f3cf8afc48f22383] video: fbdev: mb862xx: use DEVICE_ATTR_RO macro > git bisect good ff323d6d72e1e4971c8ba9e2f3cf8afc48f22383 > # first bad commit: [f611b1e7624ccdbd495c19e9805629e22265aa16] drm: Avoid circular dependencies for CONFIG_FB > ------------------------------------------------------------------------------- > > > -=-=-=-=-=-=-=-=-=-=-=- > Groups.io Links: You receive all messages sent to this group. > View/Reply Online (#13992): https://groups.io/g/kernelci-results/message/13992 > Mute This Topic: https://groups.io/mt/84176294/924702 > Group Owner: kernelci-results+owner@groups.io > Unsubscribe: https://groups.io/g/kernelci-results/unsub [guillaume.tucker@collabora.com] > -=-=-=-=-=-=-=-=-=-=-=- > > ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: media/master bisection: v4l2-compliance-vivid.device-presence on qemu_x86_64 2021-07-29 7:05 ` media/master bisection: v4l2-compliance-vivid.device-presence on qemu_x86_64 Guillaume Tucker @ 2021-07-29 7:25 ` Hans Verkuil 2021-07-29 11:21 ` Guillaume Tucker 0 siblings, 1 reply; 10+ messages in thread From: Hans Verkuil @ 2021-07-29 7:25 UTC (permalink / raw) To: Guillaume Tucker, Linux Media Mailing List; +Cc: Kees Cook, kernelci-results On 29/07/2021 09:05, Guillaume Tucker wrote: > Hello, > > FYI - This bisection was run because the KernelCI v4l2-compliance > tests on vivid failed to find a media device. Regression details > can be found here: > > https://linux.kernelci.org/test/job/media/branch/master/kernel/v5.14-rc1/plan/v4l2-compliance-vivid/ > > This doesn't really seem to be a kernel config issue per se, the > driver just wasn't built because of the DRM Kconfig change. > Instead I've added CONFIG_FB to the fragment used by KernelCI to > enable the vivid driver: > > https://github.com/kernelci/kernelci-core/pull/776/files > > Does that sound like the best approach? Trying to enable > CONFIG_FB in the vivid Kconfig causes cyclic dependencies and > seems backwards, so I thought that was the way to go. Yes, that's the right approach. I read that they disabled CONFIG_FB by default, so this is the fallout of that change. I wonder if I should change vivid so that it no longer depends on CONFIG_FB and instead just disables the bits that depend on that if it isn't set. I think it's a fair amount of work, though. Regards, Hans > > The drm-tip tree is not currently covered by KernelCI, I guess it > would have caught the issue before it landed in mainline. We're > planning to enable it again, mainly to run IGT but it seems like > some basic checks for drivers that depend on some DRM configs > would be useful too. Maybe doing that on linux-next too would be > useful. > > Best wishes, > Guillaume > > > On 13/07/2021 12:43, KernelCI bot wrote: >> * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * >> * This automated bisection report was sent to you on the basis * >> * that you may be involved with the breaking commit it has * >> * found. No manual investigation has been done to verify it, * >> * and the root cause of the problem may be somewhere else. * >> * * >> * If you do send a fix, please include this trailer: * >> * Reported-by: "kernelci.org bot" <bot@kernelci.org> * >> * * >> * Hope this helps! * >> * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * >> >> media/master bisection: v4l2-compliance-vivid.device-presence on qemu_x86_64 >> >> Summary: >> Start: e73f0f0ee754 Linux 5.14-rc1 >> Plain log: https://storage.kernelci.org/media/master/v5.14-rc1/x86_64/x86_64_defconfig+virtualvideo/gcc-8/lab-collabora/v4l2-compliance-vivid-qemu_x86_64.txt >> HTML log: https://storage.kernelci.org/media/master/v5.14-rc1/x86_64/x86_64_defconfig+virtualvideo/gcc-8/lab-collabora/v4l2-compliance-vivid-qemu_x86_64.html >> Result: f611b1e7624c drm: Avoid circular dependencies for CONFIG_FB >> >> Checks: >> revert: PASS >> verify: PASS >> >> Parameters: >> Tree: media >> URL: https://git.linuxtv.org/media_tree.git >> Branch: master >> Target: qemu_x86_64 >> CPU arch: x86_64 >> Lab: lab-collabora >> Compiler: gcc-8 >> Config: x86_64_defconfig+virtualvideo >> Test case: v4l2-compliance-vivid.device-presence >> >> Breaking commit found: >> >> ------------------------------------------------------------------------------- >> commit f611b1e7624ccdbd495c19e9805629e22265aa16 >> Author: Kees Cook <keescook@chromium.org> >> Date: Wed Jun 2 14:52:50 2021 -0700 >> >> drm: Avoid circular dependencies for CONFIG_FB >> >> When cleaning up other drm config dependencies, it is too easy to create >> larger problems. Instead, mark CONFIG_FB as a "depends": >> >> drivers/gpu/drm/Kconfig:74:error: recursive dependency detected! >> >> Suggested-by: Arnd Bergmann <arnd@kernel.org> >> Link: https://lore.kernel.org/lkml/CAK8P3a3jUQs6c5tESSNMbqfuymewj9FhqRizyHcfOXf8Rgy-nA@mail.gmail.com/ >> Signed-off-by: Kees Cook <keescook@chromium.org> >> [danvet: Rebase, the symbol has changed.] >> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch> >> Link: https://patchwork.freedesktop.org/patch/msgid/20210602215252.695994-2-keescook@chromium.org >> >> diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig >> index 594ac6c3a1f4..56a55a6e6239 100644 >> --- a/drivers/gpu/drm/Kconfig >> +++ b/drivers/gpu/drm/Kconfig >> @@ -98,8 +98,8 @@ config DRM_DEBUG_DP_MST_TOPOLOGY_REFS >> config DRM_FBDEV_EMULATION >> bool "Enable legacy fbdev support for your modesetting driver" >> depends on DRM >> + depends on FB >> select DRM_KMS_HELPER >> - select FB >> select FB_CFB_FILLRECT >> select FB_CFB_COPYAREA >> select FB_CFB_IMAGEBLIT >> ------------------------------------------------------------------------------- >> >> >> Git bisection log: >> >> ------------------------------------------------------------------------------- >> git bisect start >> # good: [50e7a31d30e8221632675abed3be306382324ca2] media: Fix Media Controller API config checks >> git bisect good 50e7a31d30e8221632675abed3be306382324ca2 >> # bad: [e73f0f0ee7541171d89f2e2491130c7771ba58d3] Linux 5.14-rc1 >> git bisect bad e73f0f0ee7541171d89f2e2491130c7771ba58d3 >> # bad: [e058a84bfddc42ba356a2316f2cf1141974625c9] Merge tag 'drm-next-2021-07-01' of git://anongit.freedesktop.org/drm/drm >> git bisect bad e058a84bfddc42ba356a2316f2cf1141974625c9 >> # good: [a6eaf3850cb171c328a8b0db6d3c79286a1eba9d] Merge tag 'sched-urgent-2021-06-30' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip >> git bisect good a6eaf3850cb171c328a8b0db6d3c79286a1eba9d >> # good: [007b312c6f294770de01fbc0643610145012d244] Merge tag 'mac80211-next-for-net-next-2021-06-25' of git://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211-next >> git bisect good 007b312c6f294770de01fbc0643610145012d244 >> # good: [18703923a66aecf6f7ded0e16d22eb412ddae72f] drm/amdgpu: Fix incorrect register offsets for Sienna Cichlid >> git bisect good 18703923a66aecf6f7ded0e16d22eb412ddae72f >> # bad: [334200bf52f0637a5ab8331c557dfcecbb9c30fa] Merge tag 'drm-msm-next-2021-06-23b' of https://gitlab.freedesktop.org/drm/msm into drm-next >> git bisect bad 334200bf52f0637a5ab8331c557dfcecbb9c30fa >> # bad: [c707b73f0cfb1acc94a20389aecde65e6385349b] Merge tag 'amd-drm-next-5.14-2021-06-09' of https://gitlab.freedesktop.org/agd5f/linux into drm-next >> git bisect bad c707b73f0cfb1acc94a20389aecde65e6385349b >> # good: [caa18dd6dd9305d52943a6b59f410cbc960ad0a0] drm/amd/display: force CP to DESIRED when removing display >> git bisect good caa18dd6dd9305d52943a6b59f410cbc960ad0a0 >> # bad: [691cf8cd7a531dbfcc29d09a23c509a86fd9b24f] drm/amdgpu: use correct rounding macro for 64-bit >> git bisect bad 691cf8cd7a531dbfcc29d09a23c509a86fd9b24f >> # bad: [2fdcb55dfc86835e4845e3f422180b5596d23cb4] drm/amdkfd: use resource cursor in svm_migrate_copy_to_vram v2 >> git bisect bad 2fdcb55dfc86835e4845e3f422180b5596d23cb4 >> # bad: [6c3f953381e526a1623d4575660afae8b19ffa20] drm/sti/sti_hqvdp: Fix incorrectly named function 'sti_hqvdp_vtg_cb()' >> git bisect bad 6c3f953381e526a1623d4575660afae8b19ffa20 >> # bad: [5ea4dba68305d9648b9dba30036cc36d4e877bca] drm/msm/a6xx: add CONFIG_QCOM_LLCC dependency >> git bisect bad 5ea4dba68305d9648b9dba30036cc36d4e877bca >> # good: [4a888ba03fd97d1cb0253581973533965bf348c4] drm/vgem/vgem_drv: Standard comment blocks should not use kernel-doc format >> git bisect good 4a888ba03fd97d1cb0253581973533965bf348c4 >> # good: [c5ef15ae09637fb51ae43e1d1d98329d67dd4fd6] video: fbdev: atyfb: mach64_cursor.c: deleted the repeated word >> git bisect good c5ef15ae09637fb51ae43e1d1d98329d67dd4fd6 >> # bad: [f611b1e7624ccdbd495c19e9805629e22265aa16] drm: Avoid circular dependencies for CONFIG_FB >> git bisect bad f611b1e7624ccdbd495c19e9805629e22265aa16 >> # good: [ff323d6d72e1e4971c8ba9e2f3cf8afc48f22383] video: fbdev: mb862xx: use DEVICE_ATTR_RO macro >> git bisect good ff323d6d72e1e4971c8ba9e2f3cf8afc48f22383 >> # first bad commit: [f611b1e7624ccdbd495c19e9805629e22265aa16] drm: Avoid circular dependencies for CONFIG_FB >> ------------------------------------------------------------------------------- >> >> >> -=-=-=-=-=-=-=-=-=-=-=- >> Groups.io Links: You receive all messages sent to this group. >> View/Reply Online (#13992): https://groups.io/g/kernelci-results/message/13992 >> Mute This Topic: https://groups.io/mt/84176294/924702 >> Group Owner: kernelci-results+owner@groups.io >> Unsubscribe: https://groups.io/g/kernelci-results/unsub [guillaume.tucker@collabora.com] >> -=-=-=-=-=-=-=-=-=-=-=- >> >> > ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: media/master bisection: v4l2-compliance-vivid.device-presence on qemu_x86_64 2021-07-29 7:25 ` Hans Verkuil @ 2021-07-29 11:21 ` Guillaume Tucker 2021-07-29 11:30 ` Hans Verkuil 0 siblings, 1 reply; 10+ messages in thread From: Guillaume Tucker @ 2021-07-29 11:21 UTC (permalink / raw) To: Hans Verkuil Cc: Kees Cook, kernelci-results, kernel, Linux Media Mailing List +collabora On 29/07/2021 08:25, Hans Verkuil wrote: > On 29/07/2021 09:05, Guillaume Tucker wrote: >> Hello, >> >> FYI - This bisection was run because the KernelCI v4l2-compliance >> tests on vivid failed to find a media device. Regression details >> can be found here: >> >> https://linux.kernelci.org/test/job/media/branch/master/kernel/v5.14-rc1/plan/v4l2-compliance-vivid/ >> >> This doesn't really seem to be a kernel config issue per se, the >> driver just wasn't built because of the DRM Kconfig change. >> Instead I've added CONFIG_FB to the fragment used by KernelCI to >> enable the vivid driver: >> >> https://github.com/kernelci/kernelci-core/pull/776/files >> >> Does that sound like the best approach? Trying to enable >> CONFIG_FB in the vivid Kconfig causes cyclic dependencies and >> seems backwards, so I thought that was the way to go. > > Yes, that's the right approach. > > I read that they disabled CONFIG_FB by default, so this is the fallout > of that change. I wonder if I should change vivid so that it no longer > depends on CONFIG_FB and instead just disables the bits that depend on > that if it isn't set. I think it's a fair amount of work, though. Well I had a look and it's not that bad, unless I'm missing something else: https://lore.kernel.org/linux-media/bf74a4670438864ca2e6bde47121554490350729.1627557341.git.guillaume.tucker@collabora.com/T/#u I've run some initial KernelCI tests by hand with this change, both with CONFIG_FB=y and without: https://lava.collabora.co.uk/scheduler/job/4276515 (with CONFIG_FB=y) https://lava.collabora.co.uk/scheduler/job/4276493 (without CONFIG_FB) It builds fine and the results seem OK in both cases. If this patch looks good to you then we could have both builds also enabled on kernelci.org for the media tree, to test v4l2-compliance on vivid with and without CONFIG_FB enabled. Best wishes, Guillaume >> The drm-tip tree is not currently covered by KernelCI, I guess it >> would have caught the issue before it landed in mainline. We're >> planning to enable it again, mainly to run IGT but it seems like >> some basic checks for drivers that depend on some DRM configs >> would be useful too. Maybe doing that on linux-next too would be >> useful. >> >> Best wishes, >> Guillaume >> >> >> On 13/07/2021 12:43, KernelCI bot wrote: >>> * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * >>> * This automated bisection report was sent to you on the basis * >>> * that you may be involved with the breaking commit it has * >>> * found. No manual investigation has been done to verify it, * >>> * and the root cause of the problem may be somewhere else. * >>> * * >>> * If you do send a fix, please include this trailer: * >>> * Reported-by: "kernelci.org bot" <bot@kernelci.org> * >>> * * >>> * Hope this helps! * >>> * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * >>> >>> media/master bisection: v4l2-compliance-vivid.device-presence on qemu_x86_64 >>> >>> Summary: >>> Start: e73f0f0ee754 Linux 5.14-rc1 >>> Plain log: https://storage.kernelci.org/media/master/v5.14-rc1/x86_64/x86_64_defconfig+virtualvideo/gcc-8/lab-collabora/v4l2-compliance-vivid-qemu_x86_64.txt >>> HTML log: https://storage.kernelci.org/media/master/v5.14-rc1/x86_64/x86_64_defconfig+virtualvideo/gcc-8/lab-collabora/v4l2-compliance-vivid-qemu_x86_64.html >>> Result: f611b1e7624c drm: Avoid circular dependencies for CONFIG_FB >>> >>> Checks: >>> revert: PASS >>> verify: PASS >>> >>> Parameters: >>> Tree: media >>> URL: https://git.linuxtv.org/media_tree.git >>> Branch: master >>> Target: qemu_x86_64 >>> CPU arch: x86_64 >>> Lab: lab-collabora >>> Compiler: gcc-8 >>> Config: x86_64_defconfig+virtualvideo >>> Test case: v4l2-compliance-vivid.device-presence >>> >>> Breaking commit found: >>> >>> ------------------------------------------------------------------------------- >>> commit f611b1e7624ccdbd495c19e9805629e22265aa16 >>> Author: Kees Cook <keescook@chromium.org> >>> Date: Wed Jun 2 14:52:50 2021 -0700 >>> >>> drm: Avoid circular dependencies for CONFIG_FB >>> >>> When cleaning up other drm config dependencies, it is too easy to create >>> larger problems. Instead, mark CONFIG_FB as a "depends": >>> >>> drivers/gpu/drm/Kconfig:74:error: recursive dependency detected! >>> >>> Suggested-by: Arnd Bergmann <arnd@kernel.org> >>> Link: https://lore.kernel.org/lkml/CAK8P3a3jUQs6c5tESSNMbqfuymewj9FhqRizyHcfOXf8Rgy-nA@mail.gmail.com/ >>> Signed-off-by: Kees Cook <keescook@chromium.org> >>> [danvet: Rebase, the symbol has changed.] >>> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch> >>> Link: https://patchwork.freedesktop.org/patch/msgid/20210602215252.695994-2-keescook@chromium.org >>> >>> diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig >>> index 594ac6c3a1f4..56a55a6e6239 100644 >>> --- a/drivers/gpu/drm/Kconfig >>> +++ b/drivers/gpu/drm/Kconfig >>> @@ -98,8 +98,8 @@ config DRM_DEBUG_DP_MST_TOPOLOGY_REFS >>> config DRM_FBDEV_EMULATION >>> bool "Enable legacy fbdev support for your modesetting driver" >>> depends on DRM >>> + depends on FB >>> select DRM_KMS_HELPER >>> - select FB >>> select FB_CFB_FILLRECT >>> select FB_CFB_COPYAREA >>> select FB_CFB_IMAGEBLIT >>> ------------------------------------------------------------------------------- >>> >>> >>> Git bisection log: >>> >>> ------------------------------------------------------------------------------- >>> git bisect start >>> # good: [50e7a31d30e8221632675abed3be306382324ca2] media: Fix Media Controller API config checks >>> git bisect good 50e7a31d30e8221632675abed3be306382324ca2 >>> # bad: [e73f0f0ee7541171d89f2e2491130c7771ba58d3] Linux 5.14-rc1 >>> git bisect bad e73f0f0ee7541171d89f2e2491130c7771ba58d3 >>> # bad: [e058a84bfddc42ba356a2316f2cf1141974625c9] Merge tag 'drm-next-2021-07-01' of git://anongit.freedesktop.org/drm/drm >>> git bisect bad e058a84bfddc42ba356a2316f2cf1141974625c9 >>> # good: [a6eaf3850cb171c328a8b0db6d3c79286a1eba9d] Merge tag 'sched-urgent-2021-06-30' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip >>> git bisect good a6eaf3850cb171c328a8b0db6d3c79286a1eba9d >>> # good: [007b312c6f294770de01fbc0643610145012d244] Merge tag 'mac80211-next-for-net-next-2021-06-25' of git://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211-next >>> git bisect good 007b312c6f294770de01fbc0643610145012d244 >>> # good: [18703923a66aecf6f7ded0e16d22eb412ddae72f] drm/amdgpu: Fix incorrect register offsets for Sienna Cichlid >>> git bisect good 18703923a66aecf6f7ded0e16d22eb412ddae72f >>> # bad: [334200bf52f0637a5ab8331c557dfcecbb9c30fa] Merge tag 'drm-msm-next-2021-06-23b' of https://gitlab.freedesktop.org/drm/msm into drm-next >>> git bisect bad 334200bf52f0637a5ab8331c557dfcecbb9c30fa >>> # bad: [c707b73f0cfb1acc94a20389aecde65e6385349b] Merge tag 'amd-drm-next-5.14-2021-06-09' of https://gitlab.freedesktop.org/agd5f/linux into drm-next >>> git bisect bad c707b73f0cfb1acc94a20389aecde65e6385349b >>> # good: [caa18dd6dd9305d52943a6b59f410cbc960ad0a0] drm/amd/display: force CP to DESIRED when removing display >>> git bisect good caa18dd6dd9305d52943a6b59f410cbc960ad0a0 >>> # bad: [691cf8cd7a531dbfcc29d09a23c509a86fd9b24f] drm/amdgpu: use correct rounding macro for 64-bit >>> git bisect bad 691cf8cd7a531dbfcc29d09a23c509a86fd9b24f >>> # bad: [2fdcb55dfc86835e4845e3f422180b5596d23cb4] drm/amdkfd: use resource cursor in svm_migrate_copy_to_vram v2 >>> git bisect bad 2fdcb55dfc86835e4845e3f422180b5596d23cb4 >>> # bad: [6c3f953381e526a1623d4575660afae8b19ffa20] drm/sti/sti_hqvdp: Fix incorrectly named function 'sti_hqvdp_vtg_cb()' >>> git bisect bad 6c3f953381e526a1623d4575660afae8b19ffa20 >>> # bad: [5ea4dba68305d9648b9dba30036cc36d4e877bca] drm/msm/a6xx: add CONFIG_QCOM_LLCC dependency >>> git bisect bad 5ea4dba68305d9648b9dba30036cc36d4e877bca >>> # good: [4a888ba03fd97d1cb0253581973533965bf348c4] drm/vgem/vgem_drv: Standard comment blocks should not use kernel-doc format >>> git bisect good 4a888ba03fd97d1cb0253581973533965bf348c4 >>> # good: [c5ef15ae09637fb51ae43e1d1d98329d67dd4fd6] video: fbdev: atyfb: mach64_cursor.c: deleted the repeated word >>> git bisect good c5ef15ae09637fb51ae43e1d1d98329d67dd4fd6 >>> # bad: [f611b1e7624ccdbd495c19e9805629e22265aa16] drm: Avoid circular dependencies for CONFIG_FB >>> git bisect bad f611b1e7624ccdbd495c19e9805629e22265aa16 >>> # good: [ff323d6d72e1e4971c8ba9e2f3cf8afc48f22383] video: fbdev: mb862xx: use DEVICE_ATTR_RO macro >>> git bisect good ff323d6d72e1e4971c8ba9e2f3cf8afc48f22383 >>> # first bad commit: [f611b1e7624ccdbd495c19e9805629e22265aa16] drm: Avoid circular dependencies for CONFIG_FB >>> ------------------------------------------------------------------------------- >>> >>> >>> -=-=-=-=-=-=-=-=-=-=-=- >>> Groups.io Links: You receive all messages sent to this group. >>> View/Reply Online (#13992): https://groups.io/g/kernelci-results/message/13992 >>> Mute This Topic: https://groups.io/mt/84176294/924702 >>> Group Owner: kernelci-results+owner@groups.io >>> Unsubscribe: https://groups.io/g/kernelci-results/unsub [guillaume.tucker@collabora.com] >>> -=-=-=-=-=-=-=-=-=-=-=- >>> >>> >> > ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: media/master bisection: v4l2-compliance-vivid.device-presence on qemu_x86_64 2021-07-29 11:21 ` Guillaume Tucker @ 2021-07-29 11:30 ` Hans Verkuil 0 siblings, 0 replies; 10+ messages in thread From: Hans Verkuil @ 2021-07-29 11:30 UTC (permalink / raw) To: Guillaume Tucker Cc: Kees Cook, kernelci-results, kernel, Linux Media Mailing List On 29/07/2021 13:21, Guillaume Tucker wrote: > +collabora > > On 29/07/2021 08:25, Hans Verkuil wrote: >> On 29/07/2021 09:05, Guillaume Tucker wrote: >>> Hello, >>> >>> FYI - This bisection was run because the KernelCI v4l2-compliance >>> tests on vivid failed to find a media device. Regression details >>> can be found here: >>> >>> https://linux.kernelci.org/test/job/media/branch/master/kernel/v5.14-rc1/plan/v4l2-compliance-vivid/ >>> >>> This doesn't really seem to be a kernel config issue per se, the >>> driver just wasn't built because of the DRM Kconfig change. >>> Instead I've added CONFIG_FB to the fragment used by KernelCI to >>> enable the vivid driver: >>> >>> https://github.com/kernelci/kernelci-core/pull/776/files >>> >>> Does that sound like the best approach? Trying to enable >>> CONFIG_FB in the vivid Kconfig causes cyclic dependencies and >>> seems backwards, so I thought that was the way to go. >> >> Yes, that's the right approach. >> >> I read that they disabled CONFIG_FB by default, so this is the fallout >> of that change. I wonder if I should change vivid so that it no longer >> depends on CONFIG_FB and instead just disables the bits that depend on >> that if it isn't set. I think it's a fair amount of work, though. > > Well I had a look and it's not that bad, unless I'm missing > something else: > > https://lore.kernel.org/linux-media/bf74a4670438864ca2e6bde47121554490350729.1627557341.git.guillaume.tucker@collabora.com/T/#u That's a lot easier than I expected. I'll take a look at the patch you posted. Regards, Hans > > I've run some initial KernelCI tests by hand with this change, > both with CONFIG_FB=y and without: > > https://lava.collabora.co.uk/scheduler/job/4276515 (with CONFIG_FB=y) > https://lava.collabora.co.uk/scheduler/job/4276493 (without CONFIG_FB) > > It builds fine and the results seem OK in both cases. If this > patch looks good to you then we could have both builds also > enabled on kernelci.org for the media tree, to test > v4l2-compliance on vivid with and without CONFIG_FB enabled. > > Best wishes, > Guillaume > > >>> The drm-tip tree is not currently covered by KernelCI, I guess it >>> would have caught the issue before it landed in mainline. We're >>> planning to enable it again, mainly to run IGT but it seems like >>> some basic checks for drivers that depend on some DRM configs >>> would be useful too. Maybe doing that on linux-next too would be >>> useful. >>> >>> Best wishes, >>> Guillaume >>> >>> >>> On 13/07/2021 12:43, KernelCI bot wrote: >>>> * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * >>>> * This automated bisection report was sent to you on the basis * >>>> * that you may be involved with the breaking commit it has * >>>> * found. No manual investigation has been done to verify it, * >>>> * and the root cause of the problem may be somewhere else. * >>>> * * >>>> * If you do send a fix, please include this trailer: * >>>> * Reported-by: "kernelci.org bot" <bot@kernelci.org> * >>>> * * >>>> * Hope this helps! * >>>> * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * >>>> >>>> media/master bisection: v4l2-compliance-vivid.device-presence on qemu_x86_64 >>>> >>>> Summary: >>>> Start: e73f0f0ee754 Linux 5.14-rc1 >>>> Plain log: https://storage.kernelci.org/media/master/v5.14-rc1/x86_64/x86_64_defconfig+virtualvideo/gcc-8/lab-collabora/v4l2-compliance-vivid-qemu_x86_64.txt >>>> HTML log: https://storage.kernelci.org/media/master/v5.14-rc1/x86_64/x86_64_defconfig+virtualvideo/gcc-8/lab-collabora/v4l2-compliance-vivid-qemu_x86_64.html >>>> Result: f611b1e7624c drm: Avoid circular dependencies for CONFIG_FB >>>> >>>> Checks: >>>> revert: PASS >>>> verify: PASS >>>> >>>> Parameters: >>>> Tree: media >>>> URL: https://git.linuxtv.org/media_tree.git >>>> Branch: master >>>> Target: qemu_x86_64 >>>> CPU arch: x86_64 >>>> Lab: lab-collabora >>>> Compiler: gcc-8 >>>> Config: x86_64_defconfig+virtualvideo >>>> Test case: v4l2-compliance-vivid.device-presence >>>> >>>> Breaking commit found: >>>> >>>> ------------------------------------------------------------------------------- >>>> commit f611b1e7624ccdbd495c19e9805629e22265aa16 >>>> Author: Kees Cook <keescook@chromium.org> >>>> Date: Wed Jun 2 14:52:50 2021 -0700 >>>> >>>> drm: Avoid circular dependencies for CONFIG_FB >>>> >>>> When cleaning up other drm config dependencies, it is too easy to create >>>> larger problems. Instead, mark CONFIG_FB as a "depends": >>>> >>>> drivers/gpu/drm/Kconfig:74:error: recursive dependency detected! >>>> >>>> Suggested-by: Arnd Bergmann <arnd@kernel.org> >>>> Link: https://lore.kernel.org/lkml/CAK8P3a3jUQs6c5tESSNMbqfuymewj9FhqRizyHcfOXf8Rgy-nA@mail.gmail.com/ >>>> Signed-off-by: Kees Cook <keescook@chromium.org> >>>> [danvet: Rebase, the symbol has changed.] >>>> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch> >>>> Link: https://patchwork.freedesktop.org/patch/msgid/20210602215252.695994-2-keescook@chromium.org >>>> >>>> diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig >>>> index 594ac6c3a1f4..56a55a6e6239 100644 >>>> --- a/drivers/gpu/drm/Kconfig >>>> +++ b/drivers/gpu/drm/Kconfig >>>> @@ -98,8 +98,8 @@ config DRM_DEBUG_DP_MST_TOPOLOGY_REFS >>>> config DRM_FBDEV_EMULATION >>>> bool "Enable legacy fbdev support for your modesetting driver" >>>> depends on DRM >>>> + depends on FB >>>> select DRM_KMS_HELPER >>>> - select FB >>>> select FB_CFB_FILLRECT >>>> select FB_CFB_COPYAREA >>>> select FB_CFB_IMAGEBLIT >>>> ------------------------------------------------------------------------------- >>>> >>>> >>>> Git bisection log: >>>> >>>> ------------------------------------------------------------------------------- >>>> git bisect start >>>> # good: [50e7a31d30e8221632675abed3be306382324ca2] media: Fix Media Controller API config checks >>>> git bisect good 50e7a31d30e8221632675abed3be306382324ca2 >>>> # bad: [e73f0f0ee7541171d89f2e2491130c7771ba58d3] Linux 5.14-rc1 >>>> git bisect bad e73f0f0ee7541171d89f2e2491130c7771ba58d3 >>>> # bad: [e058a84bfddc42ba356a2316f2cf1141974625c9] Merge tag 'drm-next-2021-07-01' of git://anongit.freedesktop.org/drm/drm >>>> git bisect bad e058a84bfddc42ba356a2316f2cf1141974625c9 >>>> # good: [a6eaf3850cb171c328a8b0db6d3c79286a1eba9d] Merge tag 'sched-urgent-2021-06-30' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip >>>> git bisect good a6eaf3850cb171c328a8b0db6d3c79286a1eba9d >>>> # good: [007b312c6f294770de01fbc0643610145012d244] Merge tag 'mac80211-next-for-net-next-2021-06-25' of git://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211-next >>>> git bisect good 007b312c6f294770de01fbc0643610145012d244 >>>> # good: [18703923a66aecf6f7ded0e16d22eb412ddae72f] drm/amdgpu: Fix incorrect register offsets for Sienna Cichlid >>>> git bisect good 18703923a66aecf6f7ded0e16d22eb412ddae72f >>>> # bad: [334200bf52f0637a5ab8331c557dfcecbb9c30fa] Merge tag 'drm-msm-next-2021-06-23b' of https://gitlab.freedesktop.org/drm/msm into drm-next >>>> git bisect bad 334200bf52f0637a5ab8331c557dfcecbb9c30fa >>>> # bad: [c707b73f0cfb1acc94a20389aecde65e6385349b] Merge tag 'amd-drm-next-5.14-2021-06-09' of https://gitlab.freedesktop.org/agd5f/linux into drm-next >>>> git bisect bad c707b73f0cfb1acc94a20389aecde65e6385349b >>>> # good: [caa18dd6dd9305d52943a6b59f410cbc960ad0a0] drm/amd/display: force CP to DESIRED when removing display >>>> git bisect good caa18dd6dd9305d52943a6b59f410cbc960ad0a0 >>>> # bad: [691cf8cd7a531dbfcc29d09a23c509a86fd9b24f] drm/amdgpu: use correct rounding macro for 64-bit >>>> git bisect bad 691cf8cd7a531dbfcc29d09a23c509a86fd9b24f >>>> # bad: [2fdcb55dfc86835e4845e3f422180b5596d23cb4] drm/amdkfd: use resource cursor in svm_migrate_copy_to_vram v2 >>>> git bisect bad 2fdcb55dfc86835e4845e3f422180b5596d23cb4 >>>> # bad: [6c3f953381e526a1623d4575660afae8b19ffa20] drm/sti/sti_hqvdp: Fix incorrectly named function 'sti_hqvdp_vtg_cb()' >>>> git bisect bad 6c3f953381e526a1623d4575660afae8b19ffa20 >>>> # bad: [5ea4dba68305d9648b9dba30036cc36d4e877bca] drm/msm/a6xx: add CONFIG_QCOM_LLCC dependency >>>> git bisect bad 5ea4dba68305d9648b9dba30036cc36d4e877bca >>>> # good: [4a888ba03fd97d1cb0253581973533965bf348c4] drm/vgem/vgem_drv: Standard comment blocks should not use kernel-doc format >>>> git bisect good 4a888ba03fd97d1cb0253581973533965bf348c4 >>>> # good: [c5ef15ae09637fb51ae43e1d1d98329d67dd4fd6] video: fbdev: atyfb: mach64_cursor.c: deleted the repeated word >>>> git bisect good c5ef15ae09637fb51ae43e1d1d98329d67dd4fd6 >>>> # bad: [f611b1e7624ccdbd495c19e9805629e22265aa16] drm: Avoid circular dependencies for CONFIG_FB >>>> git bisect bad f611b1e7624ccdbd495c19e9805629e22265aa16 >>>> # good: [ff323d6d72e1e4971c8ba9e2f3cf8afc48f22383] video: fbdev: mb862xx: use DEVICE_ATTR_RO macro >>>> git bisect good ff323d6d72e1e4971c8ba9e2f3cf8afc48f22383 >>>> # first bad commit: [f611b1e7624ccdbd495c19e9805629e22265aa16] drm: Avoid circular dependencies for CONFIG_FB >>>> ------------------------------------------------------------------------------- >>>> >>>> >>>> -=-=-=-=-=-=-=-=-=-=-=- >>>> Groups.io Links: You receive all messages sent to this group. >>>> View/Reply Online (#13992): https://groups.io/g/kernelci-results/message/13992 >>>> Mute This Topic: https://groups.io/mt/84176294/924702 >>>> Group Owner: kernelci-results+owner@groups.io >>>> Unsubscribe: https://groups.io/g/kernelci-results/unsub [guillaume.tucker@collabora.com] >>>> -=-=-=-=-=-=-=-=-=-=-=- >>>> >>>> >>> >> > ^ permalink raw reply [flat|nested] 10+ messages in thread
[parent not found: <5e960bf5.1c69fb81.8a349.6851@mx.google.com>]
* Re: media/master bisection: v4l2-compliance-vivid.device-presence on qemu_x86_64 [not found] <5e960bf5.1c69fb81.8a349.6851@mx.google.com> @ 2020-04-14 21:23 ` Guillaume Tucker 2020-04-14 21:33 ` Mauro Carvalho Chehab 0 siblings, 1 reply; 10+ messages in thread From: Guillaume Tucker @ 2020-04-14 21:23 UTC (permalink / raw) To: Mauro Carvalho Chehab Cc: Mauro Carvalho Chehab, linux-media, linux-kernel, kernel Please see the bisection report below about absence of the vivid driver, which caused v4l2-compliance to fail to run. Presumably we need to update the configuration fragment used by kernelci.org to enable platform drivers. Until now we've been using this: CONFIG_MEDIA_SUPPORT=y CONFIG_MEDIA_CAMERA_SUPPORT=y CONFIG_VIDEO_DEV=y CONFIG_VIDEO_V4L2=y CONFIG_V4L_TEST_DRIVERS=y CONFIG_VIDEO_VIVID=y CONFIG_VIDEO_VIVID_MAX_DEVS=64 Do we simply need to add this one in v5.7 onwards? CONFIG_MEDIA_PLATFORM_SUPPORT=y Thanks, Guillaume On 14/04/2020 20:16, kernelci.org bot wrote: > * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * > * This automated bisection report was sent to you on the basis * > * that you may be involved with the breaking commit it has * > * found. No manual investigation has been done to verify it, * > * and the root cause of the problem may be somewhere else. * > * * > * If you do send a fix, please include this trailer: * > * Reported-by: "kernelci.org bot" <bot@kernelci.org> * > * * > * Hope this helps! * > * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * > > media/master bisection: v4l2-compliance-vivid.device-presence on qemu_x86_64 > > Summary: > Start: ba445b7ff43b3 media: dt-bindings: rockchip-vpu: Convert bindings to json-schema > Plain log: https://storage.kernelci.org//media/master/v5.7-rc1-63-gba445b7ff43b/x86_64/x86_64_defconfig+virtualvideo/gcc-8/lab-collabora/v4l2-compliance-vivid-qemu_x86_64.txt > HTML log: https://storage.kernelci.org//media/master/v5.7-rc1-63-gba445b7ff43b/x86_64/x86_64_defconfig+virtualvideo/gcc-8/lab-collabora/v4l2-compliance-vivid-qemu_x86_64.html > Result: 06b93644f4d10 media: Kconfig: add an option to filter in/out platform drivers > > Checks: > revert: PASS > verify: PASS > > Parameters: > Tree: media > URL: https://git.linuxtv.org/media_tree.git > Branch: master > Target: qemu_x86_64 > CPU arch: x86_64 > Lab: lab-collabora > Compiler: gcc-8 > Config: x86_64_defconfig+virtualvideo > Test case: v4l2-compliance-vivid.device-presence > > Breaking commit found: > > ------------------------------------------------------------------------------- > commit 06b93644f4d102bdfc297159121acc1de794d68d > Author: Mauro Carvalho Chehab <mchehab+huawei@kernel.org> > Date: Tue Mar 24 10:27:15 2020 +0100 > > media: Kconfig: add an option to filter in/out platform drivers > > Most systems don't need support for those, while others only > need those, instead of the others. > > So, add an option to filter in/out platform drivers. > > Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org> > > diff --git a/drivers/media/Kconfig b/drivers/media/Kconfig > index 9dfea5c4b6ab7..2b6ea8beb9199 100644 > --- a/drivers/media/Kconfig > +++ b/drivers/media/Kconfig > @@ -87,6 +87,18 @@ config MEDIA_CEC_SUPPORT > Say Y when you have an HDMI receiver, transmitter or a USB CEC > adapter that supports HDMI CEC. > > +config MEDIA_PLATFORM_SUPPORT > + bool "Platform-specific devices support" > + help > + Enable support for complex cameras, codecs, and other hardware > + that are integrated at the CPU, GPU or on Image Signalling Processor > + and don't use PCI, USB or Firewire buses. > + > + This is found on Embedded hardware (SoC), on V4L2 codecs and > + on some GPU and newer CPU chipsets. > + > + Say Y when you want to be able so see such devices. > + > source "drivers/media/cec/Kconfig" > > source "drivers/media/mc/Kconfig" > @@ -161,15 +173,14 @@ source "drivers/media/dvb-core/Kconfig" > > comment "Media drivers" > > -# > -# V4L platform/mem2mem drivers > -# > - > source "drivers/media/usb/Kconfig" > source "drivers/media/pci/Kconfig" > +source "drivers/media/radio/Kconfig" > + > +if MEDIA_PLATFORM_SUPPORT > source "drivers/media/platform/Kconfig" > source "drivers/media/mmc/Kconfig" > -source "drivers/media/radio/Kconfig" > +endif > > comment "Supported FireWire (IEEE 1394) Adapters" > depends on DVB_CORE && FIREWIRE > ------------------------------------------------------------------------------- > > > Git bisection log: > > ------------------------------------------------------------------------------- > git bisect start > # good: [2632e7b618a7730969f9782593c29ca53553aa22] media: venus: firmware: Ignore secure call error on first resume > git bisect good 2632e7b618a7730969f9782593c29ca53553aa22 > # bad: [ba445b7ff43b3e45836a9a290efdc3a36ea63941] media: dt-bindings: rockchip-vpu: Convert bindings to json-schema > git bisect bad ba445b7ff43b3e45836a9a290efdc3a36ea63941 > # good: [29d9f30d4ce6c7a38745a54a8cddface10013490] Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next > git bisect good 29d9f30d4ce6c7a38745a54a8cddface10013490 > # good: [e109f506074152b7241bcbd3949a099e776cb802] Merge tag 'mtd/for-5.7' of git://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux > git bisect good e109f506074152b7241bcbd3949a099e776cb802 > # good: [aa1a8ce533324d12696a9f4b71dbc5eb561a2e04] Merge tag 'trace-v5.7' of git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace > git bisect good aa1a8ce533324d12696a9f4b71dbc5eb561a2e04 > # good: [c7b6a566b98524baea6a244186e665d22b633545] mm/gup: Mark lock taken only after a successful retake > git bisect good c7b6a566b98524baea6a244186e665d22b633545 > # good: [e4da01d8333e500e15a674d75885a9dfcfd31e77] Merge tag 'powerpc-5.7-2' of git://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux > git bisect good e4da01d8333e500e15a674d75885a9dfcfd31e77 > # good: [6900433e0fbca146d8170bdf876271cdf3053021] Merge tag 'for-linus-5.7-1' of git://github.com/cminyard/linux-ipmi > git bisect good 6900433e0fbca146d8170bdf876271cdf3053021 > # good: [b753101a4ac0b906064a72feec43f5b80a1fe2e5] Merge tag 'kbuild-v5.7-2' of git://git.kernel.org/pub/scm/linux/kernel/git/masahiroy/linux-kbuild > git bisect good b753101a4ac0b906064a72feec43f5b80a1fe2e5 > # bad: [4b32216adb010a364f23a055c45e06e839b089f9] media: split test drivers from platform directory > git bisect bad 4b32216adb010a364f23a055c45e06e839b089f9 > # good: [20e2aa812620439d010a3f78ba4e05bc0b3e2861] Merge tag 'perf-urgent-2020-04-12' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip > git bisect good 20e2aa812620439d010a3f78ba4e05bc0b3e2861 > # good: [0785249f8b93836986e9d1bdeefd2a2c13f160af] Merge tag 'timers-urgent-2020-04-12' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip > git bisect good 0785249f8b93836986e9d1bdeefd2a2c13f160af > # good: [3b50142d8528e1efc1c07f69c540f926c58ab3ad] MAINTAINERS: sort field names for all entries > git bisect good 3b50142d8528e1efc1c07f69c540f926c58ab3ad > # bad: [06b93644f4d102bdfc297159121acc1de794d68d] media: Kconfig: add an option to filter in/out platform drivers > git bisect bad 06b93644f4d102bdfc297159121acc1de794d68d > # good: [d9d6e1f3d5bbca799910072b2110963250e0b9c6] media: dvb-usb: auto-select CYPRESS_FIRMWARE > git bisect good d9d6e1f3d5bbca799910072b2110963250e0b9c6 > # first bad commit: [06b93644f4d102bdfc297159121acc1de794d68d] media: Kconfig: add an option to filter in/out platform drivers > ------------------------------------------------------------------------------- > ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: media/master bisection: v4l2-compliance-vivid.device-presence on qemu_x86_64 2020-04-14 21:23 ` Guillaume Tucker @ 2020-04-14 21:33 ` Mauro Carvalho Chehab 2020-04-14 21:43 ` Guillaume Tucker 0 siblings, 1 reply; 10+ messages in thread From: Mauro Carvalho Chehab @ 2020-04-14 21:33 UTC (permalink / raw) To: Guillaume Tucker; +Cc: Mauro Carvalho Chehab, linux-media, linux-kernel, kernel Em Tue, 14 Apr 2020 22:23:52 +0100 Guillaume Tucker <guillaume.tucker@collabora.com> escreveu: > Please see the bisection report below about absence of the vivid > driver, which caused v4l2-compliance to fail to run. > > Presumably we need to update the configuration fragment used by > kernelci.org to enable platform drivers. Until now we've been > using this: > > CONFIG_MEDIA_SUPPORT=y > CONFIG_MEDIA_CAMERA_SUPPORT=y > CONFIG_VIDEO_DEV=y > CONFIG_VIDEO_V4L2=y > CONFIG_V4L_TEST_DRIVERS=y > CONFIG_VIDEO_VIVID=y > CONFIG_VIDEO_VIVID_MAX_DEVS=64 > > Do we simply need to add this one in v5.7 onwards? > > CONFIG_MEDIA_PLATFORM_SUPPORT=y No, this shouldn't be needed. Helen sent us a patch that should likely fix it: https://git.linuxtv.org/media_tree.git/commit/?id=860b511766a3d95308a942ac09a34e4d1839e706 Could you please check if this solves the issue? Thanks, Mauro > > > On 14/04/2020 20:16, kernelci.org bot wrote: > > * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * > > * This automated bisection report was sent to you on the basis * > > * that you may be involved with the breaking commit it has * > > * found. No manual investigation has been done to verify it, * > > * and the root cause of the problem may be somewhere else. * > > * * > > * If you do send a fix, please include this trailer: * > > * Reported-by: "kernelci.org bot" <bot@kernelci.org> * > > * * > > * Hope this helps! * > > * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * > > > > media/master bisection: v4l2-compliance-vivid.device-presence on qemu_x86_64 > > > > Summary: > > Start: ba445b7ff43b3 media: dt-bindings: rockchip-vpu: Convert bindings to json-schema > > Plain log: https://storage.kernelci.org//media/master/v5.7-rc1-63-gba445b7ff43b/x86_64/x86_64_defconfig+virtualvideo/gcc-8/lab-collabora/v4l2-compliance-vivid-qemu_x86_64.txt > > HTML log: https://storage.kernelci.org//media/master/v5.7-rc1-63-gba445b7ff43b/x86_64/x86_64_defconfig+virtualvideo/gcc-8/lab-collabora/v4l2-compliance-vivid-qemu_x86_64.html > > Result: 06b93644f4d10 media: Kconfig: add an option to filter in/out platform drivers > > > > Checks: > > revert: PASS > > verify: PASS > > > > Parameters: > > Tree: media > > URL: https://git.linuxtv.org/media_tree.git > > Branch: master > > Target: qemu_x86_64 > > CPU arch: x86_64 > > Lab: lab-collabora > > Compiler: gcc-8 > > Config: x86_64_defconfig+virtualvideo > > Test case: v4l2-compliance-vivid.device-presence > > > > Breaking commit found: > > > > ------------------------------------------------------------------------------- > > commit 06b93644f4d102bdfc297159121acc1de794d68d > > Author: Mauro Carvalho Chehab <mchehab+huawei@kernel.org> > > Date: Tue Mar 24 10:27:15 2020 +0100 > > > > media: Kconfig: add an option to filter in/out platform drivers > > > > Most systems don't need support for those, while others only > > need those, instead of the others. > > > > So, add an option to filter in/out platform drivers. > > > > Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org> > > > > diff --git a/drivers/media/Kconfig b/drivers/media/Kconfig > > index 9dfea5c4b6ab7..2b6ea8beb9199 100644 > > --- a/drivers/media/Kconfig > > +++ b/drivers/media/Kconfig > > @@ -87,6 +87,18 @@ config MEDIA_CEC_SUPPORT > > Say Y when you have an HDMI receiver, transmitter or a USB CEC > > adapter that supports HDMI CEC. > > > > +config MEDIA_PLATFORM_SUPPORT > > + bool "Platform-specific devices support" > > + help > > + Enable support for complex cameras, codecs, and other hardware > > + that are integrated at the CPU, GPU or on Image Signalling Processor > > + and don't use PCI, USB or Firewire buses. > > + > > + This is found on Embedded hardware (SoC), on V4L2 codecs and > > + on some GPU and newer CPU chipsets. > > + > > + Say Y when you want to be able so see such devices. > > + > > source "drivers/media/cec/Kconfig" > > > > source "drivers/media/mc/Kconfig" > > @@ -161,15 +173,14 @@ source "drivers/media/dvb-core/Kconfig" > > > > comment "Media drivers" > > > > -# > > -# V4L platform/mem2mem drivers > > -# > > - > > source "drivers/media/usb/Kconfig" > > source "drivers/media/pci/Kconfig" > > +source "drivers/media/radio/Kconfig" > > + > > +if MEDIA_PLATFORM_SUPPORT > > source "drivers/media/platform/Kconfig" > > source "drivers/media/mmc/Kconfig" > > -source "drivers/media/radio/Kconfig" > > +endif > > > > comment "Supported FireWire (IEEE 1394) Adapters" > > depends on DVB_CORE && FIREWIRE > > ------------------------------------------------------------------------------- > > > > > > Git bisection log: > > > > ------------------------------------------------------------------------------- > > git bisect start > > # good: [2632e7b618a7730969f9782593c29ca53553aa22] media: venus: firmware: Ignore secure call error on first resume > > git bisect good 2632e7b618a7730969f9782593c29ca53553aa22 > > # bad: [ba445b7ff43b3e45836a9a290efdc3a36ea63941] media: dt-bindings: rockchip-vpu: Convert bindings to json-schema > > git bisect bad ba445b7ff43b3e45836a9a290efdc3a36ea63941 > > # good: [29d9f30d4ce6c7a38745a54a8cddface10013490] Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next > > git bisect good 29d9f30d4ce6c7a38745a54a8cddface10013490 > > # good: [e109f506074152b7241bcbd3949a099e776cb802] Merge tag 'mtd/for-5.7' of git://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux > > git bisect good e109f506074152b7241bcbd3949a099e776cb802 > > # good: [aa1a8ce533324d12696a9f4b71dbc5eb561a2e04] Merge tag 'trace-v5.7' of git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace > > git bisect good aa1a8ce533324d12696a9f4b71dbc5eb561a2e04 > > # good: [c7b6a566b98524baea6a244186e665d22b633545] mm/gup: Mark lock taken only after a successful retake > > git bisect good c7b6a566b98524baea6a244186e665d22b633545 > > # good: [e4da01d8333e500e15a674d75885a9dfcfd31e77] Merge tag 'powerpc-5.7-2' of git://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux > > git bisect good e4da01d8333e500e15a674d75885a9dfcfd31e77 > > # good: [6900433e0fbca146d8170bdf876271cdf3053021] Merge tag 'for-linus-5.7-1' of git://github.com/cminyard/linux-ipmi > > git bisect good 6900433e0fbca146d8170bdf876271cdf3053021 > > # good: [b753101a4ac0b906064a72feec43f5b80a1fe2e5] Merge tag 'kbuild-v5.7-2' of git://git.kernel.org/pub/scm/linux/kernel/git/masahiroy/linux-kbuild > > git bisect good b753101a4ac0b906064a72feec43f5b80a1fe2e5 > > # bad: [4b32216adb010a364f23a055c45e06e839b089f9] media: split test drivers from platform directory > > git bisect bad 4b32216adb010a364f23a055c45e06e839b089f9 > > # good: [20e2aa812620439d010a3f78ba4e05bc0b3e2861] Merge tag 'perf-urgent-2020-04-12' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip > > git bisect good 20e2aa812620439d010a3f78ba4e05bc0b3e2861 > > # good: [0785249f8b93836986e9d1bdeefd2a2c13f160af] Merge tag 'timers-urgent-2020-04-12' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip > > git bisect good 0785249f8b93836986e9d1bdeefd2a2c13f160af > > # good: [3b50142d8528e1efc1c07f69c540f926c58ab3ad] MAINTAINERS: sort field names for all entries > > git bisect good 3b50142d8528e1efc1c07f69c540f926c58ab3ad > > # bad: [06b93644f4d102bdfc297159121acc1de794d68d] media: Kconfig: add an option to filter in/out platform drivers > > git bisect bad 06b93644f4d102bdfc297159121acc1de794d68d > > # good: [d9d6e1f3d5bbca799910072b2110963250e0b9c6] media: dvb-usb: auto-select CYPRESS_FIRMWARE > > git bisect good d9d6e1f3d5bbca799910072b2110963250e0b9c6 > > # first bad commit: [06b93644f4d102bdfc297159121acc1de794d68d] media: Kconfig: add an option to filter in/out platform drivers > > ------------------------------------------------------------------------------- > > > Thanks, Mauro ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: media/master bisection: v4l2-compliance-vivid.device-presence on qemu_x86_64 2020-04-14 21:33 ` Mauro Carvalho Chehab @ 2020-04-14 21:43 ` Guillaume Tucker 2020-04-15 9:28 ` Guillaume Tucker 0 siblings, 1 reply; 10+ messages in thread From: Guillaume Tucker @ 2020-04-14 21:43 UTC (permalink / raw) To: Mauro Carvalho Chehab Cc: Mauro Carvalho Chehab, linux-media, linux-kernel, kernel On 14/04/2020 22:33, Mauro Carvalho Chehab wrote: > Em Tue, 14 Apr 2020 22:23:52 +0100 > Guillaume Tucker <guillaume.tucker@collabora.com> escreveu: > >> Please see the bisection report below about absence of the vivid >> driver, which caused v4l2-compliance to fail to run. >> >> Presumably we need to update the configuration fragment used by >> kernelci.org to enable platform drivers. Until now we've been >> using this: >> >> CONFIG_MEDIA_SUPPORT=y >> CONFIG_MEDIA_CAMERA_SUPPORT=y >> CONFIG_VIDEO_DEV=y >> CONFIG_VIDEO_V4L2=y >> CONFIG_V4L_TEST_DRIVERS=y >> CONFIG_VIDEO_VIVID=y >> CONFIG_VIDEO_VIVID_MAX_DEVS=64 >> >> Do we simply need to add this one in v5.7 onwards? >> >> CONFIG_MEDIA_PLATFORM_SUPPORT=y > > No, this shouldn't be needed. > > Helen sent us a patch that should likely fix it: > > https://git.linuxtv.org/media_tree.git/commit/?id=860b511766a3d95308a942ac09a34e4d1839e706 > > Could you please check if this solves the issue? I see, thanks. This revision is being built and tested at the moment, I'll check the results when they land in my inbox. Guillaume >> On 14/04/2020 20:16, kernelci.org bot wrote: >>> * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * >>> * This automated bisection report was sent to you on the basis * >>> * that you may be involved with the breaking commit it has * >>> * found. No manual investigation has been done to verify it, * >>> * and the root cause of the problem may be somewhere else. * >>> * * >>> * If you do send a fix, please include this trailer: * >>> * Reported-by: "kernelci.org bot" <bot@kernelci.org> * >>> * * >>> * Hope this helps! * >>> * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * >>> >>> media/master bisection: v4l2-compliance-vivid.device-presence on qemu_x86_64 >>> >>> Summary: >>> Start: ba445b7ff43b3 media: dt-bindings: rockchip-vpu: Convert bindings to json-schema >>> Plain log: https://storage.kernelci.org//media/master/v5.7-rc1-63-gba445b7ff43b/x86_64/x86_64_defconfig+virtualvideo/gcc-8/lab-collabora/v4l2-compliance-vivid-qemu_x86_64.txt >>> HTML log: https://storage.kernelci.org//media/master/v5.7-rc1-63-gba445b7ff43b/x86_64/x86_64_defconfig+virtualvideo/gcc-8/lab-collabora/v4l2-compliance-vivid-qemu_x86_64.html >>> Result: 06b93644f4d10 media: Kconfig: add an option to filter in/out platform drivers >>> >>> Checks: >>> revert: PASS >>> verify: PASS >>> >>> Parameters: >>> Tree: media >>> URL: https://git.linuxtv.org/media_tree.git >>> Branch: master >>> Target: qemu_x86_64 >>> CPU arch: x86_64 >>> Lab: lab-collabora >>> Compiler: gcc-8 >>> Config: x86_64_defconfig+virtualvideo >>> Test case: v4l2-compliance-vivid.device-presence >>> >>> Breaking commit found: >>> >>> ------------------------------------------------------------------------------- >>> commit 06b93644f4d102bdfc297159121acc1de794d68d >>> Author: Mauro Carvalho Chehab <mchehab+huawei@kernel.org> >>> Date: Tue Mar 24 10:27:15 2020 +0100 >>> >>> media: Kconfig: add an option to filter in/out platform drivers >>> >>> Most systems don't need support for those, while others only >>> need those, instead of the others. >>> >>> So, add an option to filter in/out platform drivers. >>> >>> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org> >>> >>> diff --git a/drivers/media/Kconfig b/drivers/media/Kconfig >>> index 9dfea5c4b6ab7..2b6ea8beb9199 100644 >>> --- a/drivers/media/Kconfig >>> +++ b/drivers/media/Kconfig >>> @@ -87,6 +87,18 @@ config MEDIA_CEC_SUPPORT >>> Say Y when you have an HDMI receiver, transmitter or a USB CEC >>> adapter that supports HDMI CEC. >>> >>> +config MEDIA_PLATFORM_SUPPORT >>> + bool "Platform-specific devices support" >>> + help >>> + Enable support for complex cameras, codecs, and other hardware >>> + that are integrated at the CPU, GPU or on Image Signalling Processor >>> + and don't use PCI, USB or Firewire buses. >>> + >>> + This is found on Embedded hardware (SoC), on V4L2 codecs and >>> + on some GPU and newer CPU chipsets. >>> + >>> + Say Y when you want to be able so see such devices. >>> + >>> source "drivers/media/cec/Kconfig" >>> >>> source "drivers/media/mc/Kconfig" >>> @@ -161,15 +173,14 @@ source "drivers/media/dvb-core/Kconfig" >>> >>> comment "Media drivers" >>> >>> -# >>> -# V4L platform/mem2mem drivers >>> -# >>> - >>> source "drivers/media/usb/Kconfig" >>> source "drivers/media/pci/Kconfig" >>> +source "drivers/media/radio/Kconfig" >>> + >>> +if MEDIA_PLATFORM_SUPPORT >>> source "drivers/media/platform/Kconfig" >>> source "drivers/media/mmc/Kconfig" >>> -source "drivers/media/radio/Kconfig" >>> +endif >>> >>> comment "Supported FireWire (IEEE 1394) Adapters" >>> depends on DVB_CORE && FIREWIRE >>> ------------------------------------------------------------------------------- >>> >>> >>> Git bisection log: >>> >>> ------------------------------------------------------------------------------- >>> git bisect start >>> # good: [2632e7b618a7730969f9782593c29ca53553aa22] media: venus: firmware: Ignore secure call error on first resume >>> git bisect good 2632e7b618a7730969f9782593c29ca53553aa22 >>> # bad: [ba445b7ff43b3e45836a9a290efdc3a36ea63941] media: dt-bindings: rockchip-vpu: Convert bindings to json-schema >>> git bisect bad ba445b7ff43b3e45836a9a290efdc3a36ea63941 >>> # good: [29d9f30d4ce6c7a38745a54a8cddface10013490] Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next >>> git bisect good 29d9f30d4ce6c7a38745a54a8cddface10013490 >>> # good: [e109f506074152b7241bcbd3949a099e776cb802] Merge tag 'mtd/for-5.7' of git://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux >>> git bisect good e109f506074152b7241bcbd3949a099e776cb802 >>> # good: [aa1a8ce533324d12696a9f4b71dbc5eb561a2e04] Merge tag 'trace-v5.7' of git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace >>> git bisect good aa1a8ce533324d12696a9f4b71dbc5eb561a2e04 >>> # good: [c7b6a566b98524baea6a244186e665d22b633545] mm/gup: Mark lock taken only after a successful retake >>> git bisect good c7b6a566b98524baea6a244186e665d22b633545 >>> # good: [e4da01d8333e500e15a674d75885a9dfcfd31e77] Merge tag 'powerpc-5.7-2' of git://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux >>> git bisect good e4da01d8333e500e15a674d75885a9dfcfd31e77 >>> # good: [6900433e0fbca146d8170bdf876271cdf3053021] Merge tag 'for-linus-5.7-1' of git://github.com/cminyard/linux-ipmi >>> git bisect good 6900433e0fbca146d8170bdf876271cdf3053021 >>> # good: [b753101a4ac0b906064a72feec43f5b80a1fe2e5] Merge tag 'kbuild-v5.7-2' of git://git.kernel.org/pub/scm/linux/kernel/git/masahiroy/linux-kbuild >>> git bisect good b753101a4ac0b906064a72feec43f5b80a1fe2e5 >>> # bad: [4b32216adb010a364f23a055c45e06e839b089f9] media: split test drivers from platform directory >>> git bisect bad 4b32216adb010a364f23a055c45e06e839b089f9 >>> # good: [20e2aa812620439d010a3f78ba4e05bc0b3e2861] Merge tag 'perf-urgent-2020-04-12' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip >>> git bisect good 20e2aa812620439d010a3f78ba4e05bc0b3e2861 >>> # good: [0785249f8b93836986e9d1bdeefd2a2c13f160af] Merge tag 'timers-urgent-2020-04-12' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip >>> git bisect good 0785249f8b93836986e9d1bdeefd2a2c13f160af >>> # good: [3b50142d8528e1efc1c07f69c540f926c58ab3ad] MAINTAINERS: sort field names for all entries >>> git bisect good 3b50142d8528e1efc1c07f69c540f926c58ab3ad >>> # bad: [06b93644f4d102bdfc297159121acc1de794d68d] media: Kconfig: add an option to filter in/out platform drivers >>> git bisect bad 06b93644f4d102bdfc297159121acc1de794d68d >>> # good: [d9d6e1f3d5bbca799910072b2110963250e0b9c6] media: dvb-usb: auto-select CYPRESS_FIRMWARE >>> git bisect good d9d6e1f3d5bbca799910072b2110963250e0b9c6 >>> # first bad commit: [06b93644f4d102bdfc297159121acc1de794d68d] media: Kconfig: add an option to filter in/out platform drivers >>> ------------------------------------------------------------------------------- >>> >> > > > > Thanks, > Mauro > ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: media/master bisection: v4l2-compliance-vivid.device-presence on qemu_x86_64 2020-04-14 21:43 ` Guillaume Tucker @ 2020-04-15 9:28 ` Guillaume Tucker 2020-04-15 9:36 ` Guillaume Tucker 0 siblings, 1 reply; 10+ messages in thread From: Guillaume Tucker @ 2020-04-15 9:28 UTC (permalink / raw) To: Mauro Carvalho Chehab; +Cc: linux-media, linux-kernel, kernel On 14/04/2020 22:43, Guillaume Tucker wrote: > On 14/04/2020 22:33, Mauro Carvalho Chehab wrote: >> Em Tue, 14 Apr 2020 22:23:52 +0100 >> Guillaume Tucker <guillaume.tucker@collabora.com> escreveu: >> >>> Please see the bisection report below about absence of the vivid >>> driver, which caused v4l2-compliance to fail to run. >>> >>> Presumably we need to update the configuration fragment used by >>> kernelci.org to enable platform drivers. Until now we've been >>> using this: >>> >>> CONFIG_MEDIA_SUPPORT=y >>> CONFIG_MEDIA_CAMERA_SUPPORT=y >>> CONFIG_VIDEO_DEV=y >>> CONFIG_VIDEO_V4L2=y >>> CONFIG_V4L_TEST_DRIVERS=y >>> CONFIG_VIDEO_VIVID=y >>> CONFIG_VIDEO_VIVID_MAX_DEVS=64 >>> >>> Do we simply need to add this one in v5.7 onwards? >>> >>> CONFIG_MEDIA_PLATFORM_SUPPORT=y >> >> No, this shouldn't be needed. >> >> Helen sent us a patch that should likely fix it: >> >> https://git.linuxtv.org/media_tree.git/commit/?id=860b511766a3d95308a942ac09a34e4d1839e706 >> >> Could you please check if this solves the issue? > > I see, thanks. This revision is being built and tested at the > moment, I'll check the results when they land in my inbox. Helen's patch was needed, but there were still a couple of issues. First we need to enable this extra option now in the config fragment: CONFIG_MEDIA_TEST_SUPPORT=y as test_drivers/Kconfig starts with "if MEDIA_TEST_SUPPORT". Then this Kconfig was included when MEDIA_PLATFORM_SUPPORT was enabled rather than MEDIA_TEST_SUPPORT in media/Kconfig. So I've just sent a patch to fix this dependency, and now it appears to be generating the correct config. I did a full v4l2-compliance run with the vivid driver on my local setup and it all passed. Guillaume >>> On 14/04/2020 20:16, kernelci.org bot wrote: >>>> * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * >>>> * This automated bisection report was sent to you on the basis * >>>> * that you may be involved with the breaking commit it has * >>>> * found. No manual investigation has been done to verify it, * >>>> * and the root cause of the problem may be somewhere else. * >>>> * * >>>> * If you do send a fix, please include this trailer: * >>>> * Reported-by: "kernelci.org bot" <bot@kernelci.org> * >>>> * * >>>> * Hope this helps! * >>>> * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * >>>> >>>> media/master bisection: v4l2-compliance-vivid.device-presence on qemu_x86_64 >>>> >>>> Summary: >>>> Start: ba445b7ff43b3 media: dt-bindings: rockchip-vpu: Convert bindings to json-schema >>>> Plain log: https://storage.kernelci.org//media/master/v5.7-rc1-63-gba445b7ff43b/x86_64/x86_64_defconfig+virtualvideo/gcc-8/lab-collabora/v4l2-compliance-vivid-qemu_x86_64.txt >>>> HTML log: https://storage.kernelci.org//media/master/v5.7-rc1-63-gba445b7ff43b/x86_64/x86_64_defconfig+virtualvideo/gcc-8/lab-collabora/v4l2-compliance-vivid-qemu_x86_64.html >>>> Result: 06b93644f4d10 media: Kconfig: add an option to filter in/out platform drivers >>>> >>>> Checks: >>>> revert: PASS >>>> verify: PASS >>>> >>>> Parameters: >>>> Tree: media >>>> URL: https://git.linuxtv.org/media_tree.git >>>> Branch: master >>>> Target: qemu_x86_64 >>>> CPU arch: x86_64 >>>> Lab: lab-collabora >>>> Compiler: gcc-8 >>>> Config: x86_64_defconfig+virtualvideo >>>> Test case: v4l2-compliance-vivid.device-presence >>>> >>>> Breaking commit found: >>>> >>>> ------------------------------------------------------------------------------- >>>> commit 06b93644f4d102bdfc297159121acc1de794d68d >>>> Author: Mauro Carvalho Chehab <mchehab+huawei@kernel.org> >>>> Date: Tue Mar 24 10:27:15 2020 +0100 >>>> >>>> media: Kconfig: add an option to filter in/out platform drivers >>>> >>>> Most systems don't need support for those, while others only >>>> need those, instead of the others. >>>> >>>> So, add an option to filter in/out platform drivers. >>>> >>>> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org> >>>> >>>> diff --git a/drivers/media/Kconfig b/drivers/media/Kconfig >>>> index 9dfea5c4b6ab7..2b6ea8beb9199 100644 >>>> --- a/drivers/media/Kconfig >>>> +++ b/drivers/media/Kconfig >>>> @@ -87,6 +87,18 @@ config MEDIA_CEC_SUPPORT >>>> Say Y when you have an HDMI receiver, transmitter or a USB CEC >>>> adapter that supports HDMI CEC. >>>> >>>> +config MEDIA_PLATFORM_SUPPORT >>>> + bool "Platform-specific devices support" >>>> + help >>>> + Enable support for complex cameras, codecs, and other hardware >>>> + that are integrated at the CPU, GPU or on Image Signalling Processor >>>> + and don't use PCI, USB or Firewire buses. >>>> + >>>> + This is found on Embedded hardware (SoC), on V4L2 codecs and >>>> + on some GPU and newer CPU chipsets. >>>> + >>>> + Say Y when you want to be able so see such devices. >>>> + >>>> source "drivers/media/cec/Kconfig" >>>> >>>> source "drivers/media/mc/Kconfig" >>>> @@ -161,15 +173,14 @@ source "drivers/media/dvb-core/Kconfig" >>>> >>>> comment "Media drivers" >>>> >>>> -# >>>> -# V4L platform/mem2mem drivers >>>> -# >>>> - >>>> source "drivers/media/usb/Kconfig" >>>> source "drivers/media/pci/Kconfig" >>>> +source "drivers/media/radio/Kconfig" >>>> + >>>> +if MEDIA_PLATFORM_SUPPORT >>>> source "drivers/media/platform/Kconfig" >>>> source "drivers/media/mmc/Kconfig" >>>> -source "drivers/media/radio/Kconfig" >>>> +endif >>>> >>>> comment "Supported FireWire (IEEE 1394) Adapters" >>>> depends on DVB_CORE && FIREWIRE >>>> ------------------------------------------------------------------------------- >>>> >>>> >>>> Git bisection log: >>>> >>>> ------------------------------------------------------------------------------- >>>> git bisect start >>>> # good: [2632e7b618a7730969f9782593c29ca53553aa22] media: venus: firmware: Ignore secure call error on first resume >>>> git bisect good 2632e7b618a7730969f9782593c29ca53553aa22 >>>> # bad: [ba445b7ff43b3e45836a9a290efdc3a36ea63941] media: dt-bindings: rockchip-vpu: Convert bindings to json-schema >>>> git bisect bad ba445b7ff43b3e45836a9a290efdc3a36ea63941 >>>> # good: [29d9f30d4ce6c7a38745a54a8cddface10013490] Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next >>>> git bisect good 29d9f30d4ce6c7a38745a54a8cddface10013490 >>>> # good: [e109f506074152b7241bcbd3949a099e776cb802] Merge tag 'mtd/for-5.7' of git://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux >>>> git bisect good e109f506074152b7241bcbd3949a099e776cb802 >>>> # good: [aa1a8ce533324d12696a9f4b71dbc5eb561a2e04] Merge tag 'trace-v5.7' of git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace >>>> git bisect good aa1a8ce533324d12696a9f4b71dbc5eb561a2e04 >>>> # good: [c7b6a566b98524baea6a244186e665d22b633545] mm/gup: Mark lock taken only after a successful retake >>>> git bisect good c7b6a566b98524baea6a244186e665d22b633545 >>>> # good: [e4da01d8333e500e15a674d75885a9dfcfd31e77] Merge tag 'powerpc-5.7-2' of git://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux >>>> git bisect good e4da01d8333e500e15a674d75885a9dfcfd31e77 >>>> # good: [6900433e0fbca146d8170bdf876271cdf3053021] Merge tag 'for-linus-5.7-1' of git://github.com/cminyard/linux-ipmi >>>> git bisect good 6900433e0fbca146d8170bdf876271cdf3053021 >>>> # good: [b753101a4ac0b906064a72feec43f5b80a1fe2e5] Merge tag 'kbuild-v5.7-2' of git://git.kernel.org/pub/scm/linux/kernel/git/masahiroy/linux-kbuild >>>> git bisect good b753101a4ac0b906064a72feec43f5b80a1fe2e5 >>>> # bad: [4b32216adb010a364f23a055c45e06e839b089f9] media: split test drivers from platform directory >>>> git bisect bad 4b32216adb010a364f23a055c45e06e839b089f9 >>>> # good: [20e2aa812620439d010a3f78ba4e05bc0b3e2861] Merge tag 'perf-urgent-2020-04-12' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip >>>> git bisect good 20e2aa812620439d010a3f78ba4e05bc0b3e2861 >>>> # good: [0785249f8b93836986e9d1bdeefd2a2c13f160af] Merge tag 'timers-urgent-2020-04-12' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip >>>> git bisect good 0785249f8b93836986e9d1bdeefd2a2c13f160af >>>> # good: [3b50142d8528e1efc1c07f69c540f926c58ab3ad] MAINTAINERS: sort field names for all entries >>>> git bisect good 3b50142d8528e1efc1c07f69c540f926c58ab3ad >>>> # bad: [06b93644f4d102bdfc297159121acc1de794d68d] media: Kconfig: add an option to filter in/out platform drivers >>>> git bisect bad 06b93644f4d102bdfc297159121acc1de794d68d >>>> # good: [d9d6e1f3d5bbca799910072b2110963250e0b9c6] media: dvb-usb: auto-select CYPRESS_FIRMWARE >>>> git bisect good d9d6e1f3d5bbca799910072b2110963250e0b9c6 >>>> # first bad commit: [06b93644f4d102bdfc297159121acc1de794d68d] media: Kconfig: add an option to filter in/out platform drivers >>>> ------------------------------------------------------------------------------- >>>> >>> >> >> >> >> Thanks, >> Mauro >> > ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: media/master bisection: v4l2-compliance-vivid.device-presence on qemu_x86_64 2020-04-15 9:28 ` Guillaume Tucker @ 2020-04-15 9:36 ` Guillaume Tucker 2020-04-15 12:21 ` Mauro Carvalho Chehab 0 siblings, 1 reply; 10+ messages in thread From: Guillaume Tucker @ 2020-04-15 9:36 UTC (permalink / raw) To: Mauro Carvalho Chehab; +Cc: linux-media, linux-kernel, kernel On 15/04/2020 10:28, Guillaume Tucker wrote: > On 14/04/2020 22:43, Guillaume Tucker wrote: >> On 14/04/2020 22:33, Mauro Carvalho Chehab wrote: >>> Em Tue, 14 Apr 2020 22:23:52 +0100 >>> Guillaume Tucker <guillaume.tucker@collabora.com> escreveu: >>> >>>> Please see the bisection report below about absence of the vivid >>>> driver, which caused v4l2-compliance to fail to run. >>>> >>>> Presumably we need to update the configuration fragment used by >>>> kernelci.org to enable platform drivers. Until now we've been >>>> using this: >>>> >>>> CONFIG_MEDIA_SUPPORT=y >>>> CONFIG_MEDIA_CAMERA_SUPPORT=y >>>> CONFIG_VIDEO_DEV=y >>>> CONFIG_VIDEO_V4L2=y >>>> CONFIG_V4L_TEST_DRIVERS=y >>>> CONFIG_VIDEO_VIVID=y >>>> CONFIG_VIDEO_VIVID_MAX_DEVS=64 >>>> >>>> Do we simply need to add this one in v5.7 onwards? >>>> >>>> CONFIG_MEDIA_PLATFORM_SUPPORT=y >>> >>> No, this shouldn't be needed. >>> >>> Helen sent us a patch that should likely fix it: >>> >>> https://git.linuxtv.org/media_tree.git/commit/?id=860b511766a3d95308a942ac09a34e4d1839e706 >>> >>> Could you please check if this solves the issue? >> >> I see, thanks. This revision is being built and tested at the >> moment, I'll check the results when they land in my inbox. > > Helen's patch was needed, but there were still a couple of > issues. First we need to enable this extra option now in the > config fragment: > > CONFIG_MEDIA_TEST_SUPPORT=y > > as test_drivers/Kconfig starts with "if MEDIA_TEST_SUPPORT". Actually, this "if" seems redundant now in test_drivers/Kconfig with my patch to include the file conditionally... Please let me know if we should also drop it and I'll send a v2, or if this should be fixed in a different way. Guillaume > Then this Kconfig was included when MEDIA_PLATFORM_SUPPORT was > enabled rather than MEDIA_TEST_SUPPORT in media/Kconfig. So I've > just sent a patch to fix this dependency, and now it appears to > be generating the correct config. I did a full v4l2-compliance > run with the vivid driver on my local setup and it all passed. > > Guillaume > >>>> On 14/04/2020 20:16, kernelci.org bot wrote: >>>>> * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * >>>>> * This automated bisection report was sent to you on the basis * >>>>> * that you may be involved with the breaking commit it has * >>>>> * found. No manual investigation has been done to verify it, * >>>>> * and the root cause of the problem may be somewhere else. * >>>>> * * >>>>> * If you do send a fix, please include this trailer: * >>>>> * Reported-by: "kernelci.org bot" <bot@kernelci.org> * >>>>> * * >>>>> * Hope this helps! * >>>>> * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * >>>>> >>>>> media/master bisection: v4l2-compliance-vivid.device-presence on qemu_x86_64 >>>>> >>>>> Summary: >>>>> Start: ba445b7ff43b3 media: dt-bindings: rockchip-vpu: Convert bindings to json-schema >>>>> Plain log: https://storage.kernelci.org//media/master/v5.7-rc1-63-gba445b7ff43b/x86_64/x86_64_defconfig+virtualvideo/gcc-8/lab-collabora/v4l2-compliance-vivid-qemu_x86_64.txt >>>>> HTML log: https://storage.kernelci.org//media/master/v5.7-rc1-63-gba445b7ff43b/x86_64/x86_64_defconfig+virtualvideo/gcc-8/lab-collabora/v4l2-compliance-vivid-qemu_x86_64.html >>>>> Result: 06b93644f4d10 media: Kconfig: add an option to filter in/out platform drivers >>>>> >>>>> Checks: >>>>> revert: PASS >>>>> verify: PASS >>>>> >>>>> Parameters: >>>>> Tree: media >>>>> URL: https://git.linuxtv.org/media_tree.git >>>>> Branch: master >>>>> Target: qemu_x86_64 >>>>> CPU arch: x86_64 >>>>> Lab: lab-collabora >>>>> Compiler: gcc-8 >>>>> Config: x86_64_defconfig+virtualvideo >>>>> Test case: v4l2-compliance-vivid.device-presence >>>>> >>>>> Breaking commit found: >>>>> >>>>> ------------------------------------------------------------------------------- >>>>> commit 06b93644f4d102bdfc297159121acc1de794d68d >>>>> Author: Mauro Carvalho Chehab <mchehab+huawei@kernel.org> >>>>> Date: Tue Mar 24 10:27:15 2020 +0100 >>>>> >>>>> media: Kconfig: add an option to filter in/out platform drivers >>>>> >>>>> Most systems don't need support for those, while others only >>>>> need those, instead of the others. >>>>> >>>>> So, add an option to filter in/out platform drivers. >>>>> >>>>> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org> >>>>> >>>>> diff --git a/drivers/media/Kconfig b/drivers/media/Kconfig >>>>> index 9dfea5c4b6ab7..2b6ea8beb9199 100644 >>>>> --- a/drivers/media/Kconfig >>>>> +++ b/drivers/media/Kconfig >>>>> @@ -87,6 +87,18 @@ config MEDIA_CEC_SUPPORT >>>>> Say Y when you have an HDMI receiver, transmitter or a USB CEC >>>>> adapter that supports HDMI CEC. >>>>> >>>>> +config MEDIA_PLATFORM_SUPPORT >>>>> + bool "Platform-specific devices support" >>>>> + help >>>>> + Enable support for complex cameras, codecs, and other hardware >>>>> + that are integrated at the CPU, GPU or on Image Signalling Processor >>>>> + and don't use PCI, USB or Firewire buses. >>>>> + >>>>> + This is found on Embedded hardware (SoC), on V4L2 codecs and >>>>> + on some GPU and newer CPU chipsets. >>>>> + >>>>> + Say Y when you want to be able so see such devices. >>>>> + >>>>> source "drivers/media/cec/Kconfig" >>>>> >>>>> source "drivers/media/mc/Kconfig" >>>>> @@ -161,15 +173,14 @@ source "drivers/media/dvb-core/Kconfig" >>>>> >>>>> comment "Media drivers" >>>>> >>>>> -# >>>>> -# V4L platform/mem2mem drivers >>>>> -# >>>>> - >>>>> source "drivers/media/usb/Kconfig" >>>>> source "drivers/media/pci/Kconfig" >>>>> +source "drivers/media/radio/Kconfig" >>>>> + >>>>> +if MEDIA_PLATFORM_SUPPORT >>>>> source "drivers/media/platform/Kconfig" >>>>> source "drivers/media/mmc/Kconfig" >>>>> -source "drivers/media/radio/Kconfig" >>>>> +endif >>>>> >>>>> comment "Supported FireWire (IEEE 1394) Adapters" >>>>> depends on DVB_CORE && FIREWIRE >>>>> ------------------------------------------------------------------------------- >>>>> >>>>> >>>>> Git bisection log: >>>>> >>>>> ------------------------------------------------------------------------------- >>>>> git bisect start >>>>> # good: [2632e7b618a7730969f9782593c29ca53553aa22] media: venus: firmware: Ignore secure call error on first resume >>>>> git bisect good 2632e7b618a7730969f9782593c29ca53553aa22 >>>>> # bad: [ba445b7ff43b3e45836a9a290efdc3a36ea63941] media: dt-bindings: rockchip-vpu: Convert bindings to json-schema >>>>> git bisect bad ba445b7ff43b3e45836a9a290efdc3a36ea63941 >>>>> # good: [29d9f30d4ce6c7a38745a54a8cddface10013490] Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next >>>>> git bisect good 29d9f30d4ce6c7a38745a54a8cddface10013490 >>>>> # good: [e109f506074152b7241bcbd3949a099e776cb802] Merge tag 'mtd/for-5.7' of git://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux >>>>> git bisect good e109f506074152b7241bcbd3949a099e776cb802 >>>>> # good: [aa1a8ce533324d12696a9f4b71dbc5eb561a2e04] Merge tag 'trace-v5.7' of git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace >>>>> git bisect good aa1a8ce533324d12696a9f4b71dbc5eb561a2e04 >>>>> # good: [c7b6a566b98524baea6a244186e665d22b633545] mm/gup: Mark lock taken only after a successful retake >>>>> git bisect good c7b6a566b98524baea6a244186e665d22b633545 >>>>> # good: [e4da01d8333e500e15a674d75885a9dfcfd31e77] Merge tag 'powerpc-5.7-2' of git://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux >>>>> git bisect good e4da01d8333e500e15a674d75885a9dfcfd31e77 >>>>> # good: [6900433e0fbca146d8170bdf876271cdf3053021] Merge tag 'for-linus-5.7-1' of git://github.com/cminyard/linux-ipmi >>>>> git bisect good 6900433e0fbca146d8170bdf876271cdf3053021 >>>>> # good: [b753101a4ac0b906064a72feec43f5b80a1fe2e5] Merge tag 'kbuild-v5.7-2' of git://git.kernel.org/pub/scm/linux/kernel/git/masahiroy/linux-kbuild >>>>> git bisect good b753101a4ac0b906064a72feec43f5b80a1fe2e5 >>>>> # bad: [4b32216adb010a364f23a055c45e06e839b089f9] media: split test drivers from platform directory >>>>> git bisect bad 4b32216adb010a364f23a055c45e06e839b089f9 >>>>> # good: [20e2aa812620439d010a3f78ba4e05bc0b3e2861] Merge tag 'perf-urgent-2020-04-12' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip >>>>> git bisect good 20e2aa812620439d010a3f78ba4e05bc0b3e2861 >>>>> # good: [0785249f8b93836986e9d1bdeefd2a2c13f160af] Merge tag 'timers-urgent-2020-04-12' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip >>>>> git bisect good 0785249f8b93836986e9d1bdeefd2a2c13f160af >>>>> # good: [3b50142d8528e1efc1c07f69c540f926c58ab3ad] MAINTAINERS: sort field names for all entries >>>>> git bisect good 3b50142d8528e1efc1c07f69c540f926c58ab3ad >>>>> # bad: [06b93644f4d102bdfc297159121acc1de794d68d] media: Kconfig: add an option to filter in/out platform drivers >>>>> git bisect bad 06b93644f4d102bdfc297159121acc1de794d68d >>>>> # good: [d9d6e1f3d5bbca799910072b2110963250e0b9c6] media: dvb-usb: auto-select CYPRESS_FIRMWARE >>>>> git bisect good d9d6e1f3d5bbca799910072b2110963250e0b9c6 >>>>> # first bad commit: [06b93644f4d102bdfc297159121acc1de794d68d] media: Kconfig: add an option to filter in/out platform drivers >>>>> ------------------------------------------------------------------------------- >>>>> >>>> >>> >>> >>> >>> Thanks, >>> Mauro >>> >> > > ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: media/master bisection: v4l2-compliance-vivid.device-presence on qemu_x86_64 2020-04-15 9:36 ` Guillaume Tucker @ 2020-04-15 12:21 ` Mauro Carvalho Chehab 0 siblings, 0 replies; 10+ messages in thread From: Mauro Carvalho Chehab @ 2020-04-15 12:21 UTC (permalink / raw) To: Guillaume Tucker; +Cc: linux-media, linux-kernel, kernel Em Wed, 15 Apr 2020 10:36:04 +0100 Guillaume Tucker <guillaume.tucker@collabora.com> escreveu: > On 15/04/2020 10:28, Guillaume Tucker wrote: > > On 14/04/2020 22:43, Guillaume Tucker wrote: > >> On 14/04/2020 22:33, Mauro Carvalho Chehab wrote: > >>> Em Tue, 14 Apr 2020 22:23:52 +0100 > >>> Guillaume Tucker <guillaume.tucker@collabora.com> escreveu: > >>> > >>>> Please see the bisection report below about absence of the vivid > >>>> driver, which caused v4l2-compliance to fail to run. > >>>> > >>>> Presumably we need to update the configuration fragment used by > >>>> kernelci.org to enable platform drivers. Until now we've been > >>>> using this: > >>>> > >>>> CONFIG_MEDIA_SUPPORT=y > >>>> CONFIG_MEDIA_CAMERA_SUPPORT=y > >>>> CONFIG_VIDEO_DEV=y > >>>> CONFIG_VIDEO_V4L2=y > >>>> CONFIG_V4L_TEST_DRIVERS=y > >>>> CONFIG_VIDEO_VIVID=y > >>>> CONFIG_VIDEO_VIVID_MAX_DEVS=64 > >>>> > >>>> Do we simply need to add this one in v5.7 onwards? > >>>> > >>>> CONFIG_MEDIA_PLATFORM_SUPPORT=y > >>> > >>> No, this shouldn't be needed. > >>> > >>> Helen sent us a patch that should likely fix it: > >>> > >>> https://git.linuxtv.org/media_tree.git/commit/?id=860b511766a3d95308a942ac09a34e4d1839e706 > >>> > >>> Could you please check if this solves the issue? > >> > >> I see, thanks. This revision is being built and tested at the > >> moment, I'll check the results when they land in my inbox. > > > > Helen's patch was needed, but there were still a couple of > > issues. First we need to enable this extra option now in the > > config fragment: > > > > CONFIG_MEDIA_TEST_SUPPORT=y Yes. Another option would be to do: # MEDIA_SUPPORT_FILTER is not set With this option (enabled by default if EMBEDDED or EXPERT), all CONFIG_MEDIA_*_SUPPORT will be selected[1]. [1] except for CONFIG_MEDIA_CEC_SUPPORT. This doesn't depend on MEDIA_SUPPORT anymore. > > > > as test_drivers/Kconfig starts with "if MEDIA_TEST_SUPPORT". > > Actually, this "if" seems redundant now in test_drivers/Kconfig > with my patch to include the file conditionally... Please let me > know if we should also drop it and I'll send a v2, or if this > should be fixed in a different way. Just one "if MEDIA_TEST_SUPPORT" at the main media/Kconfig should be enough. Feel free to send a v2. Thanks, Mauro ^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2021-07-29 11:31 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <60ed7c49.1c69fb81.518d4.80d2@mx.google.com>
2021-07-29 7:05 ` media/master bisection: v4l2-compliance-vivid.device-presence on qemu_x86_64 Guillaume Tucker
2021-07-29 7:25 ` Hans Verkuil
2021-07-29 11:21 ` Guillaume Tucker
2021-07-29 11:30 ` Hans Verkuil
[not found] <5e960bf5.1c69fb81.8a349.6851@mx.google.com>
2020-04-14 21:23 ` Guillaume Tucker
2020-04-14 21:33 ` Mauro Carvalho Chehab
2020-04-14 21:43 ` Guillaume Tucker
2020-04-15 9:28 ` Guillaume Tucker
2020-04-15 9:36 ` Guillaume Tucker
2020-04-15 12:21 ` Mauro Carvalho Chehab
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.