All of lore.kernel.org
 help / color / mirror / Atom feed
From: Laurent Vivier <laurent@vivier.eu>
To: David CARLIER <devnexen@gmail.com>,
	qemu-trivial@nongnu.org, qemu-devel <qemu-devel@nongnu.org>,
	Thomas Huth <thuth@redhat.com>,
	Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH 1/1] util/getauxval: Porting to FreeBSD getauxval feature
Date: Fri, 12 Jun 2020 09:13:22 +0200	[thread overview]
Message-ID: <e7df4877-7700-ea36-ceb0-3bf84fec8df8@vivier.eu> (raw)
In-Reply-To: <CA+XhMqwHSBd_TSFqipO6bn=hVSV8+Mdm3y=_i6gQoGBxRsjS0g@mail.gmail.com>

Le 11/06/2020 à 23:10, David CARLIER a écrit :
> 
Hi,

please don't put your patch in attachements, you can use "git
send-email" if your emailer doesn't allow it.

https://wiki.qemu.org/Contribute/SubmitAPatch#Do_not_send_as_an_attachment

I think your patch is not correct, you put a "#if defined(__linux__)" in
a block that is followed by "#elif defined(__linux__)" and there is no
return value if none of the "defined()" is true.

I think you should not modify the configure and add directly a "#if
defined(__FreeBSD__)" at the beginning of getauxval.c to define your
function.

Thanks,
Laurent


  reply	other threads:[~2020-06-12  7:14 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-11 21:10 [PATCH 1/1] util/getauxval: Porting to FreeBSD getauxval feature David CARLIER
2020-06-12  7:13 ` Laurent Vivier [this message]
2020-06-12  8:46   ` David CARLIER
2020-06-12  9:15     ` Laurent Vivier
2020-06-12  9:45     ` Paolo Bonzini
  -- strict thread matches above, loose matches on Subject: below --
2020-05-24 12:09 David CARLIER
2020-05-26  7:21 ` Thomas Huth
2020-05-26  7:37   ` David CARLIER

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e7df4877-7700-ea36-ceb0-3bf84fec8df8@vivier.eu \
    --to=laurent@vivier.eu \
    --cc=devnexen@gmail.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.