From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754382AbeEaKNd (ORCPT ); Thu, 31 May 2018 06:13:33 -0400 Received: from lelnx194.ext.ti.com ([198.47.27.80]:55128 "EHLO lelnx194.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754207AbeEaKNa (ORCPT ); Thu, 31 May 2018 06:13:30 -0400 Subject: Re: [PATCH v2 3/6] clk: ti: dra7: Add clkctrl clock data for the mcan clocks To: Rob Herring CC: , , , , , , , , References: <20180530141133.3711-1-faiz_abbas@ti.com> <20180530141133.3711-4-faiz_abbas@ti.com> <20180531040350.GA25132@rob-hp-laptop> From: Faiz Abbas Message-ID: Date: Thu, 31 May 2018 15:44:43 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20180531040350.GA25132@rob-hp-laptop> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Thursday 31 May 2018 09:33 AM, Rob Herring wrote: > On Wed, May 30, 2018 at 07:41:30PM +0530, Faiz Abbas wrote: >> Add clkctrl data for the m_can clocks and register it within the ... >> >> diff --git a/include/dt-bindings/clock/dra7.h b/include/dt-bindings/clock/dra7.h >> index 5e1061b15aed..d7549c57cac3 100644 >> --- a/include/dt-bindings/clock/dra7.h >> +++ b/include/dt-bindings/clock/dra7.h >> @@ -168,5 +168,6 @@ >> #define DRA7_COUNTER_32K_CLKCTRL DRA7_CLKCTRL_INDEX(0x50) >> #define DRA7_UART10_CLKCTRL DRA7_CLKCTRL_INDEX(0x80) >> #define DRA7_DCAN1_CLKCTRL DRA7_CLKCTRL_INDEX(0x88) >> +#define DRA7_ADC_CLKCTRL DRA7_CLKCTRL_INDEX(0xa0) > > ADC and mcan are the same thing? > The register to control MCAN clocks is called ADC_CLKCTRL, Yes. Thanks, Faiz From mboxrd@z Thu Jan 1 00:00:00 1970 From: Faiz Abbas Subject: Re: [PATCH v2 3/6] clk: ti: dra7: Add clkctrl clock data for the mcan clocks Date: Thu, 31 May 2018 15:44:43 +0530 Message-ID: References: <20180530141133.3711-1-faiz_abbas@ti.com> <20180530141133.3711-4-faiz_abbas@ti.com> <20180531040350.GA25132@rob-hp-laptop> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20180531040350.GA25132@rob-hp-laptop> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Rob Herring Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, bcousson@baylibre.com, tony@atomide.com, paul@pwsan.com, t-kristo@ti.com List-Id: devicetree@vger.kernel.org Hi, On Thursday 31 May 2018 09:33 AM, Rob Herring wrote: > On Wed, May 30, 2018 at 07:41:30PM +0530, Faiz Abbas wrote: >> Add clkctrl data for the m_can clocks and register it within the ... >> >> diff --git a/include/dt-bindings/clock/dra7.h b/include/dt-bindings/clock/dra7.h >> index 5e1061b15aed..d7549c57cac3 100644 >> --- a/include/dt-bindings/clock/dra7.h >> +++ b/include/dt-bindings/clock/dra7.h >> @@ -168,5 +168,6 @@ >> #define DRA7_COUNTER_32K_CLKCTRL DRA7_CLKCTRL_INDEX(0x50) >> #define DRA7_UART10_CLKCTRL DRA7_CLKCTRL_INDEX(0x80) >> #define DRA7_DCAN1_CLKCTRL DRA7_CLKCTRL_INDEX(0x88) >> +#define DRA7_ADC_CLKCTRL DRA7_CLKCTRL_INDEX(0xa0) > > ADC and mcan are the same thing? > The register to control MCAN clocks is called ADC_CLKCTRL, Yes. Thanks, Faiz From mboxrd@z Thu Jan 1 00:00:00 1970 From: faiz_abbas@ti.com (Faiz Abbas) Date: Thu, 31 May 2018 15:44:43 +0530 Subject: [PATCH v2 3/6] clk: ti: dra7: Add clkctrl clock data for the mcan clocks In-Reply-To: <20180531040350.GA25132@rob-hp-laptop> References: <20180530141133.3711-1-faiz_abbas@ti.com> <20180530141133.3711-4-faiz_abbas@ti.com> <20180531040350.GA25132@rob-hp-laptop> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi, On Thursday 31 May 2018 09:33 AM, Rob Herring wrote: > On Wed, May 30, 2018 at 07:41:30PM +0530, Faiz Abbas wrote: >> Add clkctrl data for the m_can clocks and register it within the ... >> >> diff --git a/include/dt-bindings/clock/dra7.h b/include/dt-bindings/clock/dra7.h >> index 5e1061b15aed..d7549c57cac3 100644 >> --- a/include/dt-bindings/clock/dra7.h >> +++ b/include/dt-bindings/clock/dra7.h >> @@ -168,5 +168,6 @@ >> #define DRA7_COUNTER_32K_CLKCTRL DRA7_CLKCTRL_INDEX(0x50) >> #define DRA7_UART10_CLKCTRL DRA7_CLKCTRL_INDEX(0x80) >> #define DRA7_DCAN1_CLKCTRL DRA7_CLKCTRL_INDEX(0x88) >> +#define DRA7_ADC_CLKCTRL DRA7_CLKCTRL_INDEX(0xa0) > > ADC and mcan are the same thing? > The register to control MCAN clocks is called ADC_CLKCTRL, Yes. Thanks, Faiz