From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932860AbcKVN5c (ORCPT ); Tue, 22 Nov 2016 08:57:32 -0500 Received: from mout.kundenserver.de ([217.72.192.75]:51032 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932305AbcKVN5a (ORCPT ); Tue, 22 Nov 2016 08:57:30 -0500 Subject: Re: [PATCH 5/5] usb: dwc2: fix kernel-doc for dwc2_set_param To: Felipe Balbi , John Youn , Vardan Mikayelyan , Greg Kroah-Hartman References: <1479677166-13114-1-git-send-email-stefan.wahren@i2se.com> <1479677166-13114-6-git-send-email-stefan.wahren@i2se.com> <87lgwbr9ef.fsf@linux.intel.com> Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org From: Stefan Wahren Message-ID: Date: Tue, 22 Nov 2016 14:57:16 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <87lgwbr9ef.fsf@linux.intel.com> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:+Ht2zv3kA1MT5qbQ0M0lkXM3iqARJua2UsIOBLoUwA74WVTGk6T pigKALfW5yXWWehTZjkKEcA04Kx2c+slEv7lxYmMz0M8QL7B6hNsTm290gSXI5YmRY1VlRg oFC24SWxKYHiKZqGPPNRp6urwub2P6aqzJUeEkg9oq0czCo5ZS0lZny9xgBUF0+D1Vx2QEq oXJiqKy7s2rfhbMPXgaSw== X-UI-Out-Filterresults: notjunk:1;V01:K0:D/V7rqRjZg0=:yIthmfqOLUxeJs1+fep9Ip vdPjqlKQNnxt+ld0y+OEfdweUoO8M9RRhNPsEKxN7FXyNGi9kvvwDf/Fm+QlV57SKpXtvXi2h vYQ5x4zXZvFNqvIzw6rDM27UJ/rpy1DCCbb799Ovdl5u4oiYucdG8SIhbZK7J9XHAzxiAtOiH OfnOVAd23fxjCKP5IPTkYN9ulTgpMXe5z+VmJPAA3IppJlyRSh7WvTPbY7NmecVWG8lUQ92KY sXi8dUIhSD7xwEdKHNOCqts4+EMYC8JzaAeBmRsvOrjGHwYNq5sCj2X0EDDNHqNg41V9gpqEc Lvi4oQeeT+AHvDBnfZ+G6q9cEwTjl1CMgZWMfXIPlBo+CpjX9o19db4ztF718qdthioGaQmTi oX+XVvOLH8eYsXFcfS5AIjiLDpkrOmLrvEHpTVFKmdRnWFvFLwYxB4tUpWxyOeIwJ4Ug6HMz3 EcIyAunPcr3bE5wqYFAlMgvkEGubAJdxDEFs+sW1TqYEDYjyCA+945phKbx8auVJ+b9Z7RnFD CNJuvklR8fXiBkWUzSUUuospxUsEJ7vHTht0VHwtwsD+s6vEL+iXfALyJIMidnHyXlOCzimMf 4QQIrzNre+09dgXabQksMAqe1sBRvuS9KFKSAB75qi/xGWBkTzRMwOySDY2rqb10+7hfqlxt4 4O2iu9vBWAc5JQ+7v8OnU9nNvWVzVlMCXlxgobBgZiMdkOyW9M6zXNAh3d6yyJwQIfNFFE0Av E+3uKdtWKxla7WLD Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Felipe, Am 22.11.2016 um 13:23 schrieb Felipe Balbi: > Hi, > > Stefan Wahren writes: >> Since there is no parameter @value replace it with @legacy. >> >> Fixes: 05ee799f202 ("usb: dwc2: Move gadget settings into core_params") >> Signed-off-by: Stefan Wahren >> --- >> drivers/usb/dwc2/params.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/usb/dwc2/params.c b/drivers/usb/dwc2/params.c >> index 11fe68a..10407cb 100644 >> --- a/drivers/usb/dwc2/params.c >> +++ b/drivers/usb/dwc2/params.c >> @@ -320,7 +320,7 @@ static void dwc2_set_core_param(void *param, u8 size, u64 value) >> * @size: The size of the core parameter in bytes, or 0 for bool. >> * >> * This function looks up @property and sets the @param to that value. >> - * If the property doesn't exist it uses the passed-in @value. It will >> + * If the property doesn't exist it uses the passed-in @legacy value. It will > This doesn't fix any bugs. you are right. I found this documentation bug while fixing the issues before. Since this is the last patch of the series, you could ignore it. And i resend it without fixes tag after the merge window. > Also, is @legacy a parameter? > |/** * dwc2_set_param() - Set a core parameter * * @hsotg: Programming view of the DWC_otg controller * @param: Pointer to the parameter to set * @lookup: True if the property should be looked up * @property: The device property to read * @legacy: The param value to set if @property is not available. This * will typically be the legacy value set in the static * params structure. * @def: The default value * @min: The minimum value * @max: The maximum value * @size: The size of the core parameter in bytes, or 0 for bool. * * This function looks up @property and sets the @param to that value. * If the property doesn't exist it uses the passed-in @value. It will * verify that the value falls between @min and @max. If it doesn't, * it will output an error and set the parameter to either @def or, * failing that, to @min. * * The @size is used to write to @param and to query the device * properties so that this same function can be used with different * types of parameters. */ static void dwc2_set_param(struct dwc2_hsotg *hsotg, void *param, bool lookup, char *property, u64 legacy, u64 def, u64 min, u64 max, u8 size)|