From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Guo, Jia" <jia.guo@intel.com>
Subject: Re: [PATCH V17 3/4] eal/linux: uevent parse and process
Date: Mon, 2 Apr 2018 12:20:19 +0800
Message-ID: <e820e081-5ed9-ac97-95d6-c4618e299646@intel.com>
References: <1522063256-3997-5-git-send-email-jia.guo@intel.com>
 <1522339205-27698-1-git-send-email-jia.guo@intel.com>
 <1522339205-27698-4-git-send-email-jia.guo@intel.com>
 <20180329095940.14205ef9@xeon-e3>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Cc: bruce.richardson@intel.com, ferruh.yigit@intel.com,
 konstantin.ananyev@intel.com, gaetan.rivet@6wind.com, jingjing.wu@intel.com,
 thomas@monjalon.net, motih@mellanox.com, harry.van.haaren@intel.com,
 jianfeng.tan@intel.com, jblunck@infradead.org, shreyansh.jain@nxp.com,
 dev@dpdk.org, helin.zhang@intel.com
To: Stephen Hemminger <stephen@networkplumber.org>
Return-path: <dev-bounces@dpdk.org>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by dpdk.org (Postfix) with ESMTP id 543876841
 for <dev@dpdk.org>; Mon,  2 Apr 2018 06:20:23 +0200 (CEST)
In-Reply-To: <20180329095940.14205ef9@xeon-e3>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>



On 3/30/2018 12:59 AM, Stephen Hemminger wrote:
> On Fri, 30 Mar 2018 00:00:04 +0800
> Jeff Guo <jia.guo@intel.com> wrote:
>
>> +	ret = ioctl(netlink_fd, FIONBIO, &nonblock);
>> +	if (ret != 0) {
>> +		RTE_LOG(ERR, EAL, "ioctl(FIONBIO) failed.\n");
>> +		goto err;
>> +	}
>> +	retu
> Since you use NOWAIT option, this is unnecessary.
i think you are right.