All of lore.kernel.org
 help / color / mirror / Atom feed
From: Luca Ceresoli <luca@lucaceresoli.net>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/qpid-proton: needs C++ and threads
Date: Mon, 23 May 2022 15:19:44 +0200	[thread overview]
Message-ID: <e828792d-8371-7fe1-bdd1-b7f729fa7097@lucaceresoli.net> (raw)
In-Reply-To: <20220521204348.1023965-1-fontaine.fabrice@gmail.com>

Hi Fabrice,

first, thanks for addressing this! It's been on my todo list for a long
time but never got the time do look into that.

On 21/05/22 22:43, Fabrice Fontaine wrote:
> qpid-proton needs C++ (and so threads due to proactor) to avoid the
> following build failure:
> 
> CMake Error at /nvmedata/autobuild/instance-3/output-1/host/share/cmake-3.18/Modules/CMakeTestCXXCompiler.cmake:59 (message):
>   The C++ compiler
> 
>     "/usr/bin/c++"
> 
>   is not able to compile a simple test program.
> 
> C++ check can't easily be removed:
> https://github.com/apache/qpid-proton/pull/366
> 
> Fixes:
>  - http://autobuild.buildroot.org/results/76f8deccc9c4eee29eddf42586cc28e96eec0827
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

If upstream does not provide _working_ support for building without C++,
then I would not spend much time in trying to do so.

My only question is whether you tried to upgrade to the latest version
and see whether non-C++ builds are supported there. I hope this would be
a quick test. If you did that and still non-C++ builds fail:

Reviewed-by: Luca Ceresoli <luca@lucaceresoli.net>

-- 
Luca
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2022-05-23 13:19 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-21 20:43 [Buildroot] [PATCH 1/1] package/qpid-proton: needs C++ and threads Fabrice Fontaine
2022-05-23 13:19 ` Luca Ceresoli [this message]
2022-06-04 14:52   ` Yann E. MORIN
2022-06-04 14:49 ` Yann E. MORIN
2022-06-07 15:44 ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e828792d-8371-7fe1-bdd1-b7f729fa7097@lucaceresoli.net \
    --to=luca@lucaceresoli.net \
    --cc=buildroot@buildroot.org \
    --cc=fontaine.fabrice@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.