All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael Opdenacker" <michael.opdenacker@bootlin.com>
To: Ross Burton <ross@burtonini.com>, docs@lists.yoctoproject.org
Subject: Re: [docs] [PATCH] kickstart: update busybox note regarding PARTUUID
Date: Wed, 21 Jul 2021 16:19:49 +0200	[thread overview]
Message-ID: <e82b8e4f-d068-b8a5-f201-4b96ac1d9470@bootlin.com> (raw)
In-Reply-To: <20210721125025.3996595-1-ross.burton@arm.com>

Hi Ross,

Thank you for this patch!
See my comments and questions below...

On 7/21/21 2:50 PM, Ross Burton wrote:
> As of oe-core c996cabf the default BusyBox configuration supports
> PARTUUID, so update the note to reflect this.
>
> Signed-off-by: Ross Burton <ross.burton@arm.com>
> ---
>  documentation/ref-manual/kickstart.rst | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/documentation/ref-manual/kickstart.rst b/documentation/ref-manual/kickstart.rst
> index fc723ccbe..9de3f763d 100644
> --- a/documentation/ref-manual/kickstart.rst
> +++ b/documentation/ref-manual/kickstart.rst
> @@ -54,8 +54,9 @@ must also provide one of the ``--ondrive``, ``--ondisk``, or
>  .. note::
>  
>     The mount program must understand the PARTUUID syntax you use with
> -   ``--use-uuid`` and non-root *mountpoint*, including swap. The BusyBox
> -   versions of these application are currently excluded.
> +   ``--use-uuid`` and non-root *mountpoint*, including swap. The default
> +   configuration of BusyBox in OpenEmbedded support this, but this may
> +   be disabled in custom configurations.

s/support/supports/ ... but I can update this by myself.

Written this way (not your fault, unless you wrote the initial text
too!), this suggests that "mount" has a "--use-uuid" option, but I can't
seem to use it.

Here's what works for me:
mount UUID=675e2a50-fd3b-43b7-aede-6714e2404070 /mnt/mount/

Reading further, I know understand that this corresponds to Wic's
option. Could we say "... you use with Wic's ``--use-uuid`` option for
non-root mountpoints" instead?

I'm proposing "for" instead of "and" here because I first believed the
text was talking about the "mountpoints" BusyBox command run as a
non-root user. I may be a little twisted, but I think that would be less
confusing.

Let me propose my own V2 for this patch, that may be easier to understand...

Cheers,

Michael.


>  
>  Here is an example that uses "/" as the mountpoint. The command uses
>  ``--ondisk`` to force the partition onto the ``sdb`` disk::
>
> 
>
-- 
Michael Opdenacker, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com


  reply	other threads:[~2021-07-21 14:19 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-21 12:50 Ross Burton
2021-07-21 14:19 ` Michael Opdenacker [this message]
     [not found] ` <1693D42FF18C1F82.16442@lists.yoctoproject.org>
2021-07-21 15:31   ` [docs] " Michael Opdenacker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e82b8e4f-d068-b8a5-f201-4b96ac1d9470@bootlin.com \
    --to=michael.opdenacker@bootlin.com \
    --cc=docs@lists.yoctoproject.org \
    --cc=ross@burtonini.com \
    --subject='Re: [docs] [PATCH] kickstart: update busybox note regarding PARTUUID' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.