From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=c+yg=TC=vger.kernel.org=linux-kernel-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,
	SIGNED_OFF_BY,SPF_PASS,T_DKIMWL_WL_HIGH autolearn=ham autolearn_force=no
	version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 7DE17C43219
	for <linux-kernel@archiver.kernel.org>; Thu,  2 May 2019 12:33:12 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by mail.kernel.org (Postfix) with ESMTP id 4933F205C9
	for <linux-kernel@archiver.kernel.org>; Thu,  2 May 2019 12:33:12 +0000 (UTC)
Authentication-Results: mail.kernel.org;
	dkim=pass (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="YUm4ZS0s"
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1726585AbfEBMdL (ORCPT
        <rfc822;linux-kernel@archiver.kernel.org>);
        Thu, 2 May 2019 08:33:11 -0400
Received: from hqemgate15.nvidia.com ([216.228.121.64]:7814 "EHLO
        hqemgate15.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1726267AbfEBMdK (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 2 May 2019 08:33:10 -0400
Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqemgate15.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA)
        id <B5ccae3660000>; Thu, 02 May 2019 05:32:38 -0700
Received: from hqmail.nvidia.com ([172.20.161.6])
  by hqpgpgate101.nvidia.com (PGP Universal service);
  Thu, 02 May 2019 05:33:09 -0700
X-PGP-Universal: processed;
        by hqpgpgate101.nvidia.com on Thu, 02 May 2019 05:33:09 -0700
Received: from [10.19.120.147] (10.124.1.5) by HQMAIL101.nvidia.com
 (172.20.187.10) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Thu, 2 May
 2019 12:33:08 +0000
Subject: Re: [PATCH v3 1/1] usb: xhci: Add Clear_TT_Buffer
To:     Mathias Nyman <mathias.nyman@linux.intel.com>,
        <mathias.nyman@intel.com>, <gregkh@linuxfoundation.org>
References: <1556593592-3078-1-git-send-email-jilin@nvidia.com>
 <f1688e22-05d9-ca43-5df2-2a5436631851@linux.intel.com>
CC:     <linux-usb@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        Alan Stern <stern@rowland.harvard.edu>
From:   Jim Lin <jilin@nvidia.com>
Message-ID: <e82d0e4b-3621-ed5b-b25c-ebf3feec91bd@nvidia.com>
Date:   Thu, 2 May 2019 20:32:56 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.2.0
MIME-Version: 1.0
In-Reply-To: <f1688e22-05d9-ca43-5df2-2a5436631851@linux.intel.com>
X-Originating-IP: [10.124.1.5]
X-ClientProxiedBy: HQMAIL104.nvidia.com (172.18.146.11) To
 HQMAIL101.nvidia.com (172.20.187.10)
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: quoted-printable
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1;
        t=1556800358; bh=ZS8vh8KD8anSfPWwEZxAwvj2iOB9xyaClvsaxRdp4e0=;
        h=X-PGP-Universal:Subject:To:References:CC:From:Message-ID:Date:
         User-Agent:MIME-Version:In-Reply-To:X-Originating-IP:
         X-ClientProxiedBy:Content-Type:Content-Transfer-Encoding;
        b=YUm4ZS0s9B2rGQNv6BXsxM0TguIl26kD0X296JliOvM/M2foKWqlE8EHk4IJiQzas
         CIk0H75bQ9EYAUjk2UNvTUJ+KBmLLbmhgrf14eBd7H7+FUnlNKoo7+/ugcviicO1ot
         /un0YxBTalQMM8k3JdF7Sem0/Ao52Im1gzFtDkEOk/IzFNQkkn6Bw1OqEV5Lsn39rV
         Lt0HpRr2PnxhbscpOORgNY/L9BEuCOsLQpPKqAue0sprjzcOxTkgtPwZp+e/jK2QdU
         b+uAuW+uvM0CCkFRSRpAIkeDImHn8PGViGwgmes/hhoka20pZ1+PE4Wwn4od4k4CyK
         J3mW3pTgd0pmg==
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org



On 2019=E5=B9=B405=E6=9C=8802=E6=97=A5 18:56, Mathias Nyman wrote:
> On 30.4.2019 6.06, Jim Lin wrote:
>> USB 2.0 specification chapter 11.17.5 says "as part of endpoint halt
>> processing for full-/low-speed endpoints connected via a TT, the host
>> software must use the Clear_TT_Buffer request to the TT to ensure
>> that the buffer is not in the busy state".
>
> Good point, xhci isn't making sure TT buffers get cleared when they=20
> should.
>
>>
>> In our case, a full-speed speaker (ConferenceCam) is behind a high-
>> speed hub (ConferenceCam Connect), sometimes once we get STALL on a
>> request we may continue to get STALL with the folllowing requests,
>> like Set_Interface.
>>
>> Here we add Clear_TT_Buffer for the following Set_Interface requests
>> to get ACK successfully.
>>
>> Signed-off-by: Jim Lin <jilin@nvidia.com>
>> ---
>> v2: xhci_clear_tt_buffer_complete: add static, shorter indentation
>>      , remove its claiming in xhci.h
>> v3: Add description for clearing_tt (xhci.h)
>>
>>   drivers/usb/host/xhci-ring.c | 28 ++++++++++++++++++++++++++++
>>   drivers/usb/host/xhci.c      |  7 +++++++
>>   drivers/usb/host/xhci.h      |  2 ++
>>   3 files changed, 37 insertions(+)
>>
>> diff --git a/drivers/usb/host/xhci-ring.c b/drivers/usb/host/xhci-ring.c
>> index 9215a28dad40..02b1ebad81e7 100644
>> --- a/drivers/usb/host/xhci-ring.c
>> +++ b/drivers/usb/host/xhci-ring.c
>> @@ -1786,6 +1786,33 @@ struct xhci_segment *trb_in_td(struct xhci_hcd=20
>> *xhci,
>>       return NULL;
>>   }
>>   +static void xhci_clear_hub_tt_buffer(struct xhci_hcd *xhci,
>> +    unsigned int slot_id, struct xhci_td *td)
>> +{
>> +    struct xhci_virt_device *dev;
>> +    struct xhci_slot_ctx *slot_ctx;
>> +    int saved_devnum;
>> +
>> +    /*
>> +     * As part of low/full-speed endpoint-halt processing
>> +     * we must clear the TT buffer (USB 2.0 specification 11.17.5).
>> +     */
>> +    if (td->urb->dev->tt && !usb_pipeint(td->urb->pipe) &&
>> +        (td->urb->dev->tt->hub !=3D xhci_to_hcd(xhci)->self.root_hub) &=
&
>> +        !xhci->clearing_tt) {
>> +        xhci->clearing_tt =3D 1;
>
> one xhci->clearing_tt under is not enough, there might be several HS=20
> hubs, or
> multi TT hubs with halted endpoints at the same time that need TT=20
> clearing.
>
> How about a flag per endpoint?
>
> For example Aadding a EP_CLEARING_TT flag for ep_state in struct=20
> xhci_virt_ep?
> just like EP_STOP_CMD_PENDING, or EP_HALTED
>
>> +        dev =3D xhci->devs[slot_id];
>> +        slot_ctx =3D xhci_get_slot_ctx(xhci, dev->out_ctx);
>> +        /* Update devnum temporarily for usb_hub_clear_tt_buffer */
>> +        saved_devnum =3D td->urb->dev->devnum;
>> +        td->urb->dev->devnum =3D (int) le32_to_cpu(slot_ctx->dev_state)=
 &
>> +            DEV_ADDR_MASK;
>
> Changing the struct usb_device devnum on the fly seems like a bit of a=20
> hack, and probably
> causes issues elsewhere. Devnum is tied to uevents, usbfs, sysfs etc.
>
> We need another solution, some options:
>
> - Let usb_hub_clear_tt_buffer() figure out address and not just use=20
> devnum if host =3D=3D xhci.
> - Add address to struct usb_device, (would have both address and=20
> devnum), use it when needed.
> - Provide address as parameter to usb_clear_tt_buffer() (api change,=20
> changes other host drivers)
> - Force devnum to be same as address, usb core can't choose address=20
> for xhci devices.
>
> -Mathias
Thanks for review. Will try.

--nvpublic

From mboxrd@z Thu Jan  1 00:00:00 1970
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: base64
Subject: [v3,1/1] usb: xhci: Add Clear_TT_Buffer
From: Jim Lin <jilin@nvidia.com>
Message-Id: <e82d0e4b-3621-ed5b-b25c-ebf3feec91bd@nvidia.com>
Date: Thu, 2 May 2019 20:32:56 +0800
To: Mathias Nyman <mathias.nyman@linux.intel.com>, mathias.nyman@intel.com, gregkh@linuxfoundation.org
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Alan Stern <stern@rowland.harvard.edu>
List-ID: <linux-usb.vger.kernel.org>

T24gMjAxOeW5tDA15pyIMDLml6UgMTg6NTYsIE1hdGhpYXMgTnltYW4gd3JvdGU6Cj4gT24gMzAu
NC4yMDE5IDYuMDYsIEppbSBMaW4gd3JvdGU6Cj4+IFVTQiAyLjAgc3BlY2lmaWNhdGlvbiBjaGFw
dGVyIDExLjE3LjUgc2F5cyAiYXMgcGFydCBvZiBlbmRwb2ludCBoYWx0Cj4+IHByb2Nlc3Npbmcg
Zm9yIGZ1bGwtL2xvdy1zcGVlZCBlbmRwb2ludHMgY29ubmVjdGVkIHZpYSBhIFRULCB0aGUgaG9z
dAo+PiBzb2Z0d2FyZSBtdXN0IHVzZSB0aGUgQ2xlYXJfVFRfQnVmZmVyIHJlcXVlc3QgdG8gdGhl
IFRUIHRvIGVuc3VyZQo+PiB0aGF0IHRoZSBidWZmZXIgaXMgbm90IGluIHRoZSBidXN5IHN0YXRl
Ii4KPgo+IEdvb2QgcG9pbnQsIHhoY2kgaXNuJ3QgbWFraW5nIHN1cmUgVFQgYnVmZmVycyBnZXQg
Y2xlYXJlZCB3aGVuIHRoZXkgCj4gc2hvdWxkLgo+Cj4+Cj4+IEluIG91ciBjYXNlLCBhIGZ1bGwt
c3BlZWQgc3BlYWtlciAoQ29uZmVyZW5jZUNhbSkgaXMgYmVoaW5kIGEgaGlnaC0KPj4gc3BlZWQg
aHViIChDb25mZXJlbmNlQ2FtIENvbm5lY3QpLCBzb21ldGltZXMgb25jZSB3ZSBnZXQgU1RBTEwg
b24gYQo+PiByZXF1ZXN0IHdlIG1heSBjb250aW51ZSB0byBnZXQgU1RBTEwgd2l0aCB0aGUgZm9s
bGxvd2luZyByZXF1ZXN0cywKPj4gbGlrZSBTZXRfSW50ZXJmYWNlLgo+Pgo+PiBIZXJlIHdlIGFk
ZCBDbGVhcl9UVF9CdWZmZXIgZm9yIHRoZSBmb2xsb3dpbmcgU2V0X0ludGVyZmFjZSByZXF1ZXN0
cwo+PiB0byBnZXQgQUNLIHN1Y2Nlc3NmdWxseS4KPj4KPj4gU2lnbmVkLW9mZi1ieTogSmltIExp
biA8amlsaW5AbnZpZGlhLmNvbT4KPj4gLS0tCj4+IHYyOiB4aGNpX2NsZWFyX3R0X2J1ZmZlcl9j
b21wbGV0ZTogYWRkIHN0YXRpYywgc2hvcnRlciBpbmRlbnRhdGlvbgo+PiAgICAgICwgcmVtb3Zl
IGl0cyBjbGFpbWluZyBpbiB4aGNpLmgKPj4gdjM6IEFkZCBkZXNjcmlwdGlvbiBmb3IgY2xlYXJp
bmdfdHQgKHhoY2kuaCkKPj4KPj4gICBkcml2ZXJzL3VzYi9ob3N0L3hoY2ktcmluZy5jIHwgMjgg
KysrKysrKysrKysrKysrKysrKysrKysrKysrKwo+PiAgIGRyaXZlcnMvdXNiL2hvc3QveGhjaS5j
ICAgICAgfCAgNyArKysrKysrCj4+ICAgZHJpdmVycy91c2IvaG9zdC94aGNpLmggICAgICB8ICAy
ICsrCj4+ICAgMyBmaWxlcyBjaGFuZ2VkLCAzNyBpbnNlcnRpb25zKCspCj4+Cj4+IGRpZmYgLS1n
aXQgYS9kcml2ZXJzL3VzYi9ob3N0L3hoY2ktcmluZy5jIGIvZHJpdmVycy91c2IvaG9zdC94aGNp
LXJpbmcuYwo+PiBpbmRleCA5MjE1YTI4ZGFkNDAuLjAyYjFlYmFkODFlNyAxMDA2NDQKPj4gLS0t
IGEvZHJpdmVycy91c2IvaG9zdC94aGNpLXJpbmcuYwo+PiArKysgYi9kcml2ZXJzL3VzYi9ob3N0
L3hoY2ktcmluZy5jCj4+IEBAIC0xNzg2LDYgKzE3ODYsMzMgQEAgc3RydWN0IHhoY2lfc2VnbWVu
dCAqdHJiX2luX3RkKHN0cnVjdCB4aGNpX2hjZCAKPj4gKnhoY2ksCj4+ICAgICAgIHJldHVybiBO
VUxMOwo+PiAgIH0KPj4gICArc3RhdGljIHZvaWQgeGhjaV9jbGVhcl9odWJfdHRfYnVmZmVyKHN0
cnVjdCB4aGNpX2hjZCAqeGhjaSwKPj4gKyAgICB1bnNpZ25lZCBpbnQgc2xvdF9pZCwgc3RydWN0
IHhoY2lfdGQgKnRkKQo+PiArewo+PiArICAgIHN0cnVjdCB4aGNpX3ZpcnRfZGV2aWNlICpkZXY7
Cj4+ICsgICAgc3RydWN0IHhoY2lfc2xvdF9jdHggKnNsb3RfY3R4Owo+PiArICAgIGludCBzYXZl
ZF9kZXZudW07Cj4+ICsKPj4gKyAgICAvKgo+PiArICAgICAqIEFzIHBhcnQgb2YgbG93L2Z1bGwt
c3BlZWQgZW5kcG9pbnQtaGFsdCBwcm9jZXNzaW5nCj4+ICsgICAgICogd2UgbXVzdCBjbGVhciB0
aGUgVFQgYnVmZmVyIChVU0IgMi4wIHNwZWNpZmljYXRpb24gMTEuMTcuNSkuCj4+ICsgICAgICov
Cj4+ICsgICAgaWYgKHRkLT51cmItPmRldi0+dHQgJiYgIXVzYl9waXBlaW50KHRkLT51cmItPnBp
cGUpICYmCj4+ICsgICAgICAgICh0ZC0+dXJiLT5kZXYtPnR0LT5odWIgIT0geGhjaV90b19oY2Qo
eGhjaSktPnNlbGYucm9vdF9odWIpICYmCj4+ICsgICAgICAgICF4aGNpLT5jbGVhcmluZ190dCkg
ewo+PiArICAgICAgICB4aGNpLT5jbGVhcmluZ190dCA9IDE7Cj4KPiBvbmUgeGhjaS0+Y2xlYXJp
bmdfdHQgdW5kZXIgaXMgbm90IGVub3VnaCwgdGhlcmUgbWlnaHQgYmUgc2V2ZXJhbCBIUyAKPiBo
dWJzLCBvcgo+IG11bHRpIFRUIGh1YnMgd2l0aCBoYWx0ZWQgZW5kcG9pbnRzIGF0IHRoZSBzYW1l
IHRpbWUgdGhhdCBuZWVkIFRUIAo+IGNsZWFyaW5nLgo+Cj4gSG93IGFib3V0IGEgZmxhZyBwZXIg
ZW5kcG9pbnQ/Cj4KPiBGb3IgZXhhbXBsZSBBYWRkaW5nIGEgRVBfQ0xFQVJJTkdfVFQgZmxhZyBm
b3IgZXBfc3RhdGUgaW4gc3RydWN0IAo+IHhoY2lfdmlydF9lcD8KPiBqdXN0IGxpa2UgRVBfU1RP
UF9DTURfUEVORElORywgb3IgRVBfSEFMVEVECj4KPj4gKyAgICAgICAgZGV2ID0geGhjaS0+ZGV2
c1tzbG90X2lkXTsKPj4gKyAgICAgICAgc2xvdF9jdHggPSB4aGNpX2dldF9zbG90X2N0eCh4aGNp
LCBkZXYtPm91dF9jdHgpOwo+PiArICAgICAgICAvKiBVcGRhdGUgZGV2bnVtIHRlbXBvcmFyaWx5
IGZvciB1c2JfaHViX2NsZWFyX3R0X2J1ZmZlciAqLwo+PiArICAgICAgICBzYXZlZF9kZXZudW0g
PSB0ZC0+dXJiLT5kZXYtPmRldm51bTsKPj4gKyAgICAgICAgdGQtPnVyYi0+ZGV2LT5kZXZudW0g
PSAoaW50KSBsZTMyX3RvX2NwdShzbG90X2N0eC0+ZGV2X3N0YXRlKSAmCj4+ICsgICAgICAgICAg
ICBERVZfQUREUl9NQVNLOwo+Cj4gQ2hhbmdpbmcgdGhlIHN0cnVjdCB1c2JfZGV2aWNlIGRldm51
bSBvbiB0aGUgZmx5IHNlZW1zIGxpa2UgYSBiaXQgb2YgYSAKPiBoYWNrLCBhbmQgcHJvYmFibHkK
PiBjYXVzZXMgaXNzdWVzIGVsc2V3aGVyZS4gRGV2bnVtIGlzIHRpZWQgdG8gdWV2ZW50cywgdXNi
ZnMsIHN5c2ZzIGV0Yy4KPgo+IFdlIG5lZWQgYW5vdGhlciBzb2x1dGlvbiwgc29tZSBvcHRpb25z
Ogo+Cj4gLSBMZXQgdXNiX2h1Yl9jbGVhcl90dF9idWZmZXIoKSBmaWd1cmUgb3V0IGFkZHJlc3Mg
YW5kIG5vdCBqdXN0IHVzZSAKPiBkZXZudW0gaWYgaG9zdCA9PSB4aGNpLgo+IC0gQWRkIGFkZHJl
c3MgdG8gc3RydWN0IHVzYl9kZXZpY2UsICh3b3VsZCBoYXZlIGJvdGggYWRkcmVzcyBhbmQgCj4g
ZGV2bnVtKSwgdXNlIGl0IHdoZW4gbmVlZGVkLgo+IC0gUHJvdmlkZSBhZGRyZXNzIGFzIHBhcmFt
ZXRlciB0byB1c2JfY2xlYXJfdHRfYnVmZmVyKCkgKGFwaSBjaGFuZ2UsIAo+IGNoYW5nZXMgb3Ro
ZXIgaG9zdCBkcml2ZXJzKQo+IC0gRm9yY2UgZGV2bnVtIHRvIGJlIHNhbWUgYXMgYWRkcmVzcywg
dXNiIGNvcmUgY2FuJ3QgY2hvb3NlIGFkZHJlc3MgCj4gZm9yIHhoY2kgZGV2aWNlcy4KPgo+IC1N
YXRoaWFzClRoYW5rcyBmb3IgcmV2aWV3LiBXaWxsIHRyeS4KCi0tbnZwdWJsaWMK