From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: virtio-comment-return-1783-cohuck=redhat.com@lists.oasis-open.org Sender: List-Post: List-Help: List-Unsubscribe: List-Subscribe: Received: from lists.oasis-open.org (oasis-open.org [10.110.1.242]) by lists.oasis-open.org (Postfix) with ESMTP id 5570E9860E0 for ; Tue, 23 Mar 2021 13:20:41 +0000 (UTC) References: <20210323090449.527947-1-arseny.krasnov@kaspersky.com> From: Arseny Krasnov Message-ID: Date: Tue, 23 Mar 2021 16:20:37 +0300 MIME-Version: 1.0 In-Reply-To: Subject: [virtio-comment] Re: [RFC PATCH v2] virtio-vsock: use C style defines for constants Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Content-Language: en-US To: Stefan Hajnoczi Cc: cohuck@redhat.com, virtio-comment@lists.oasis-open.org, Stefano Garzarella , "Michael S. Tsirkin" , Jason Wang , "David S. Miller" , Jakub Kicinski , Jorgen Hansen , Norbert Slusarek , Colin Ian King , Andra Paraschiv , Jeff Vander Stoep , Alexander Popov , virtualization@lists.linux-foundation.org, oxffffaa@gmail.com List-ID: On 23.03.2021 15:43, Stefan Hajnoczi wrote: > On Tue, Mar 23, 2021 at 12:04:44PM +0300, Arseny Krasnov wrote: >> This: >> 1) Replaces enums with C style defines. > Why? Please include the rationale for this change in the commit > description. Ack > >> @@ -227,6 +226,11 @@ \subsubsection{Stream Sockets}\label{sec:Device Types / Socket Device / Device O >> hints are permanent once sent and successive packets with bits clear do not >> reset them. >> >> +\begin{lstlisting} >> +#define VIRTIO_VSOCK_SHUTDOWN_RECEIVE_BIT 0 >> +#define VIRTIO_VSOCK_SHUTDOWN_SEND_BIT 1 >> +\end{lstlisting} > Please reference these constants in the text. This publicly archived list offers a means to provide input to the OASIS Virtual I/O Device (VIRTIO) TC. In order to verify user consent to the Feedback License terms and to minimize spam in the list archive, subscription is required before posting. Subscribe: virtio-comment-subscribe@lists.oasis-open.org Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org List help: virtio-comment-help@lists.oasis-open.org List archive: https://lists.oasis-open.org/archives/virtio-comment/ Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists Committee: https://www.oasis-open.org/committees/virtio/ Join OASIS: https://www.oasis-open.org/join/