All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH mm] tracing: incorrect isolate_mote_t cast in mm_vmscan_lru_isolate
@ 2022-05-11  9:46 Vasily Averin
  2022-05-15 22:10 ` Steven Rostedt
  0 siblings, 1 reply; 2+ messages in thread
From: Vasily Averin @ 2022-05-11  9:46 UTC (permalink / raw)
  To: Steven Rostedt, Ingo Molnar, Andrew Morton; +Cc: kernel, linux-kernel, linux-mm

Fixes following sparse warnings:

  CHECK   mm/vmscan.c
mm/vmscan.c: note: in included file (through
include/trace/trace_events.h, include/trace/define_trace.h,
include/trace/events/vmscan.h):
./include/trace/events/vmscan.h:281:1: sparse: warning:
 cast to restricted isolate_mode_t
./include/trace/events/vmscan.h:281:1: sparse: warning:
 restricted isolate_mode_t degrades to integer

Signed-off-by: Vasily Averin <vvs@openvz.org>
---
 include/trace/events/vmscan.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/trace/events/vmscan.h b/include/trace/events/vmscan.h
index 408c86244d64..d2123dd960d5 100644
--- a/include/trace/events/vmscan.h
+++ b/include/trace/events/vmscan.h
@@ -297,7 +297,7 @@ TRACE_EVENT(mm_vmscan_lru_isolate,
 		__field(unsigned long, nr_scanned)
 		__field(unsigned long, nr_skipped)
 		__field(unsigned long, nr_taken)
-		__field(isolate_mode_t, isolate_mode)
+		__field(unsigned int, isolate_mode)
 		__field(int, lru)
 	),
 
@@ -308,7 +308,7 @@ TRACE_EVENT(mm_vmscan_lru_isolate,
 		__entry->nr_scanned = nr_scanned;
 		__entry->nr_skipped = nr_skipped;
 		__entry->nr_taken = nr_taken;
-		__entry->isolate_mode = isolate_mode;
+		__entry->isolate_mode = (__force unsigned int)isolate_mode;
 		__entry->lru = lru;
 	),
 
-- 
2.31.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH mm] tracing: incorrect isolate_mote_t cast in mm_vmscan_lru_isolate
  2022-05-11  9:46 [PATCH mm] tracing: incorrect isolate_mote_t cast in mm_vmscan_lru_isolate Vasily Averin
@ 2022-05-15 22:10 ` Steven Rostedt
  0 siblings, 0 replies; 2+ messages in thread
From: Steven Rostedt @ 2022-05-15 22:10 UTC (permalink / raw)
  To: Vasily Averin; +Cc: Ingo Molnar, Andrew Morton, kernel, linux-kernel, linux-mm

On Wed, 11 May 2022 12:46:53 +0300
Vasily Averin <vvs@openvz.org> wrote:

> Fixes following sparse warnings:
> 
>   CHECK   mm/vmscan.c
> mm/vmscan.c: note: in included file (through
> include/trace/trace_events.h, include/trace/define_trace.h,
> include/trace/events/vmscan.h):
> ./include/trace/events/vmscan.h:281:1: sparse: warning:
>  cast to restricted isolate_mode_t
> ./include/trace/events/vmscan.h:281:1: sparse: warning:
>  restricted isolate_mode_t degrades to integer
> 
> Signed-off-by: Vasily Averin <vvs@openvz.org>

Acked-by: Steven Rostedt (Google) <rostedt@goodmis.org>

-- Steve

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-05-15 22:11 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-11  9:46 [PATCH mm] tracing: incorrect isolate_mote_t cast in mm_vmscan_lru_isolate Vasily Averin
2022-05-15 22:10 ` Steven Rostedt

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.