From mboxrd@z Thu Jan  1 00:00:00 1970
From: Rasmus Villemoes <rasmus.villemoes@prevas.dk>
Date: Tue, 2 Jun 2020 21:44:23 +0200
Subject: [PATCH v2 00/10] new rtc methods, rtc command, and tests
In-Reply-To: <CAPnjgZ0GrrPxtV2wJookY7et-kN80kze19pzR5-4Mx2oF3NLxg@mail.gmail.com>
References: <20200504212032.3759-1-rasmus.villemoes@prevas.dk>
 <20200519220117.24448-1-rasmus.villemoes@prevas.dk>
 <efb2e85b-5d40-9800-2d46-713ad1ba4646@prevas.dk>
 <CAPnjgZ0GrrPxtV2wJookY7et-kN80kze19pzR5-4Mx2oF3NLxg@mail.gmail.com>
Message-ID: <e85faf46-c83d-217e-be06-6f92a5ed0cb8@prevas.dk>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 02/06/2020 21.29, Simon Glass wrote:
> Hi Rasmus,
> 
> On Tue, 2 Jun 2020 at 12:40, Rasmus Villemoes
> <rasmus.villemoes@prevas.dk> wrote:
>>
>> Urgh. The name rtc_read() is already used for a local helper by a number
>> of rtc drivers (also rtc_write, for somewhat fewer drivers). So I can
>> still call the methods ->read and ->write, but the functions will need
>> another name. Probably dm_rtc_read/dm_rtc_write, since this is only for
>> DM-enabled drivers anyway, and matches the existing dm_rtc_get/dm_rtc_set.
> 
> The conflict is OK, since at some point those drivers will be updated
> to DM or removed. I'd rather avoid the dm_ prefix if not necessary.

There are some DM-enabled drivers that still use those names as local
helpers, e.g. rx8025.c and pt7c4338.c.

Rasmus