From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66BE7C433EF for ; Mon, 28 Mar 2022 22:50:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230145AbiC1WwO (ORCPT ); Mon, 28 Mar 2022 18:52:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43828 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230204AbiC1WwM (ORCPT ); Mon, 28 Mar 2022 18:52:12 -0400 Received: from ssl.serverraum.org (ssl.serverraum.org [176.9.125.105]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A875C184B7B; Mon, 28 Mar 2022 15:50:30 -0700 (PDT) Received: from ssl.serverraum.org (web.serverraum.org [172.16.0.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ssl.serverraum.org (Postfix) with ESMTPSA id EB8752223A; Tue, 29 Mar 2022 00:50:28 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=walle.cc; s=mail2016061301; t=1648507829; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=I3gaFBZ3yrJ/2YMqtccYFL35SLVJmtDTn3J7H7rEt9c=; b=hWLUxypQgRZr78sXGVpo5Nkeun38pUDKWStQjgtG3J/2yyhkxgX4DFujkPn4hTI/Bx9W5r rPUNcD6anjzaWJ0NHiohCJr6wYCFRjhY2syHsUDQMgGkrB0AyG52ohTbwzoq4BN5kzJJ1k VAvt5lWjB+Xa/BkuE3u8OrAfYMiYQPA= MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Tue, 29 Mar 2022 00:50:28 +0200 From: Michael Walle To: Guenter Roeck Cc: Andrew Lunn , Xu Yilun , Tom Rix , Jean Delvare , Heiner Kallweit , Russell King , "David S . Miller" , Jakub Kicinski , Paolo Abeni , linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH v1 0/2] hwmon: introduce hwmon_sanitize() In-Reply-To: References: <20220328115226.3042322-1-michael@walle.cc> User-Agent: Roundcube Webmail/1.4.13 Message-ID: X-Sender: michael@walle.cc Precedence: bulk List-ID: X-Mailing-List: linux-hwmon@vger.kernel.org Am 2022-03-28 18:27, schrieb Guenter Roeck: > On 3/28/22 05:56, Andrew Lunn wrote: >>> I'm not sure how to handle this correctly, as this touches both the >>> network tree and the hwmon tree. Also, the GPY PHY temperature senors >>> driver would use it. >> >> There are a few options: >> >> 1) Get the hwmon_sanitize_name() merged into hwmon, ask for a stable >> branch, and get it merged into netdev net-next. >> >> 2) Have the hwmon maintainers ACK the change and agree that it can be >> merged via netdev. >> >> Probably the second option is easiest, and since it is not touching >> the core of hwmon, it is unlikely to cause merge conflicts. >> > > No, it isn't the easiest solution because it also modifies a hwmon > driver to use it. So that leaves us with option 1? The next version will contain the additional patch which moves the hwmon_is_bad_char() from the include to the core and make it private. That will then need an immutable branch from netdev to get merged back into hwmon before that patch can be applied, right? -michael