From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2CD6AC28CC5 for ; Thu, 6 Jun 2019 01:35:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0A7BE20866 for ; Thu, 6 Jun 2019 01:35:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726728AbfFFBfL (ORCPT ); Wed, 5 Jun 2019 21:35:11 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:18088 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726581AbfFFBfK (ORCPT ); Wed, 5 Jun 2019 21:35:10 -0400 Received: from DGGEMS411-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id 16A7F8394FA83C5D5F22; Thu, 6 Jun 2019 09:35:08 +0800 (CST) Received: from [127.0.0.1] (10.177.96.203) by DGGEMS411-HUB.china.huawei.com (10.3.19.211) with Microsoft SMTP Server id 14.3.439.0; Thu, 6 Jun 2019 09:34:59 +0800 Subject: Re: [PATCH] scsi: libsas, lldds: Use dev_is_expander() To: John Garry , , , , , , CC: , , References: <1559751143-168560-1-git-send-email-john.garry@huawei.com> From: Jason Yan Message-ID: Date: Thu, 6 Jun 2019 09:34:56 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.5.0 MIME-Version: 1.0 In-Reply-To: <1559751143-168560-1-git-send-email-john.garry@huawei.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Originating-IP: [10.177.96.203] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2019/6/6 0:12, John Garry wrote: > Many times in libsas, and in LLDDs which use libsas, the check for an > expander device is re-implemented or open coded. > > Use dev_is_expander() instead. We rename this from > sas_dev_type_is_expander() to not spill so many lines in referencing. > > Signed-off-by: John Garry Cannot agree more， Reviewed-by: Jason Yan From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Yan Subject: Re: [PATCH] scsi: libsas, lldds: Use dev_is_expander() Date: Thu, 6 Jun 2019 09:34:56 +0800 Message-ID: References: <1559751143-168560-1-git-send-email-john.garry@huawei.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: <1559751143-168560-1-git-send-email-john.garry@huawei.com> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: John Garry , jejb@linux.ibm.com, martin.petersen@oracle.com, intel-linux-scu@intel.com, artur.paszkiewicz@intel.com, jinpu.wang@profitbricks.com, lindar_liu@usish.com Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, hare@suse.de List-Id: linux-scsi@vger.kernel.org On 2019/6/6 0:12, John Garry wrote: > Many times in libsas, and in LLDDs which use libsas, the check for an > expander device is re-implemented or open coded. > > Use dev_is_expander() instead. We rename this from > sas_dev_type_is_expander() to not spill so many lines in referencing. > > Signed-off-by: John Garry Cannot agree more， Reviewed-by: Jason Yan