From: Matthias-Christian Ott <ott@mirix.org>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Petko Manolov <petkan@nucleusys.com>,
linux-usb@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH] net: usb: pegasus: Do not drop long Ethernet frames
Date: Sun, 26 Dec 2021 23:21:19 +0100 [thread overview]
Message-ID: <e8c4c087-f6f1-eb41-e433-6a73264281b7@mirix.org> (raw)
In-Reply-To: <YciY8Useao5hfIAF@lunn.ch>
On 26/12/2021 17:31, Andrew Lunn wrote:
>>> I've nothing against this patch, but if you are working on the driver,
>>> it would be nice to replace these hex numbers with #defines using BIT,
>>> or FIELD. It will make the code more readable.
>>
>> Replacing the constants with macros is on my list of things that I want
>> to do. In this case, I did not do it because I wanted to a have small
>> patch that gets easily accepted and allows me to figure out the current
>> process to submit patches after years of inactivity.
>
> Agreed, keep fixes simple.
>
> A few other hints. If you consider this a fix which should be back
> ported, please add a Fixes: tag, where the issue started. This can be
> back as far as the first commit for the driver. Fixes should also be
> sent to the net tree, not net-next. See the netdev FAQ about the two
> different trees.
I made a v2 of the patch and also added the prefix flag to indicate that
the patch is destined for the "next" tree. There is still something that
can be improved a about it, please let me know. Otherwise, I will also
resend the other patch that I sent for the driver to indicate that it is
destined for the "next" tree.
Kind regards,
Matthias-Christian Ott
next prev parent reply other threads:[~2021-12-26 22:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-26 13:29 [PATCH] net: usb: pegasus: Do not drop long Ethernet frames Matthias-Christian Ott
2021-12-26 15:39 ` Andrew Lunn
2021-12-26 16:01 ` Matthias-Christian Ott
2021-12-26 16:31 ` Andrew Lunn
2021-12-26 22:21 ` Matthias-Christian Ott [this message]
2021-12-26 22:28 ` Petko Manolov
2021-12-27 9:56 ` Sergei Shtylyov
2022-01-02 14:22 ` Matthias-Christian Ott
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e8c4c087-f6f1-eb41-e433-6a73264281b7@mirix.org \
--to=ott@mirix.org \
--cc=andrew@lunn.ch \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=petkan@nucleusys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.