From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933060AbcLSObK (ORCPT ); Mon, 19 Dec 2016 09:31:10 -0500 Received: from mail.free-electrons.com ([62.4.15.54]:45681 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755289AbcLSOaN (ORCPT ); Mon, 19 Dec 2016 09:30:13 -0500 Subject: Re: [PATCH v2] ARM: dts: sun8i: add opp-v2 table for A33 To: Icenowy Zheng , Chen-Yu Tsai , Maxime Ripard References: <20161215182754.33921-1-icenowy@aosc.xyz> <20161219084652.kiqdkiewu5tujlyd@lukather> <11975791482156406@web2g.yandex.ru> Cc: Hans de Goede , devicetree , linux-arm-kernel , linux-kernel , linux-clk , linux-sunxi From: Quentin Schulz Message-ID: Date: Mon, 19 Dec 2016 15:30:10 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <11975791482156406@web2g.yandex.ru> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 19/12/2016 15:06, Icenowy Zheng wrote: > > > 19.12.2016, 16:54, "Chen-Yu Tsai" : >> On Mon, Dec 19, 2016 at 4:46 PM, Maxime Ripard >> wrote: >>> On Fri, Dec 16, 2016 at 02:27:54AM +0800, Icenowy Zheng wrote: >>>> An operating point table is needed for the cpu frequency adjusting to >>>> work. >>>> >>>> The operating point table is converted from the common value in >>>> extracted script.fex from many A33 board/tablets. >>>> >>>> Signed-off-by: Icenowy Zheng >>>> --- >>>> Changes since v1: >>>> - Fix format problem (blank lines). >>>> - Removed the 1.344GHz operating point, as it's overvoltage and overclocked. >>>> >>>> This patch depends on the following patchset: >>>> >>>> http://lists.infradead.org/pipermail/linux-arm-kernel/2016-December/473962.html >>>> >>>> It's the v2 of the [PATCH 4/6] in this patchset. >>>> >>>> I think this operating point table may also apply to A23, as there's no >>>> difference except the points over 1.2GHz between A23 and A33's stock dvfs table. >>>> >>>> But as A23 CCU may not have the necessary fixes, I won't add the table to A23 >>>> now. >>>> >>>> Chen-Yu, could you test the CCU fixes I described in the patchset above on A23, >>>> then test this operating points table? >>>> >>>> If it's necessary, you can send out the CCU fixes and add one more patch that >>>> moves this opp-v2 table to sun8i-a23-a33.dtsi . >>>> >>>> arch/arm/boot/dts/sun8i-a33.dtsi | 35 +++++++++++++++++++++++++++++++++++ >>>> 1 file changed, 35 insertions(+) >>>> >>>> diff --git a/arch/arm/boot/dts/sun8i-a33.dtsi b/arch/arm/boot/dts/sun8i-a33.dtsi >>>> index 504996cbee29..0f5b2af72981 100644 >>>> --- a/arch/arm/boot/dts/sun8i-a33.dtsi >>>> +++ b/arch/arm/boot/dts/sun8i-a33.dtsi >>>> @@ -46,7 +46,42 @@ >>>> #include >>>> >>>> / { >>>> + cpu0_opp_table: opp_table0 { >>>> + compatible = "operating-points-v2"; >>>> + opp-shared; >>>> + >>>> + opp@648000000 { >>>> + opp-hz = /bits/ 64 <648000000>; >>>> + opp-microvolt = <1040000>; >>>> + clock-latency-ns = <244144>; /* 8 32k periods */ >>>> + }; >>>> + >>>> + opp@816000000 { >>>> + opp-hz = /bits/ 64 <816000000>; >>>> + opp-microvolt = <1100000>; >>>> + clock-latency-ns = <244144>; /* 8 32k periods */ >>>> + }; >>>> + >>>> + opp@1008000000 { >>>> + opp-hz = /bits/ 64 <1008000000>; >>>> + opp-microvolt = <1200000>; >>>> + clock-latency-ns = <244144>; /* 8 32k periods */ >>>> + }; >>>> + >>>> + opp@1200000000 { >>>> + opp-hz = /bits/ 64 <1200000000>; >>>> + opp-microvolt = <1320000>; >>>> + clock-latency-ns = <244144>; /* 8 32k periods */ >>>> + }; >>>> + }; >>>> + Also, there are a lot more operating points for the A33, see: https://github.com/QSchulz/linux/blob/v4.9-rc4_adc_a31_v7/cpufreq_a33/arch/arm/boot/dts/sun8i-a33.dtsi#L323-L340 They are present in the Allwinner Linux source code and in the fex of all A33-based boards. Is there a reason for not adding all opp? Quentin -- Quentin Schulz, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com From mboxrd@z Thu Jan 1 00:00:00 1970 From: Quentin Schulz Subject: Re: [PATCH v2] ARM: dts: sun8i: add opp-v2 table for A33 Date: Mon, 19 Dec 2016 15:30:10 +0100 Message-ID: References: <20161215182754.33921-1-icenowy@aosc.xyz> <20161219084652.kiqdkiewu5tujlyd@lukather> <11975791482156406@web2g.yandex.ru> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <11975791482156406@web2g.yandex.ru> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Icenowy Zheng , Chen-Yu Tsai , Maxime Ripard Cc: devicetree , linux-kernel , Hans de Goede , linux-sunxi , linux-clk , linux-arm-kernel List-Id: devicetree@vger.kernel.org On 19/12/2016 15:06, Icenowy Zheng wrote: > > > 19.12.2016, 16:54, "Chen-Yu Tsai" : >> On Mon, Dec 19, 2016 at 4:46 PM, Maxime Ripard >> wrote: >>> On Fri, Dec 16, 2016 at 02:27:54AM +0800, Icenowy Zheng wrote: >>>> An operating point table is needed for the cpu frequency adjusting to >>>> work. >>>> >>>> The operating point table is converted from the common value in >>>> extracted script.fex from many A33 board/tablets. >>>> >>>> Signed-off-by: Icenowy Zheng >>>> --- >>>> Changes since v1: >>>> - Fix format problem (blank lines). >>>> - Removed the 1.344GHz operating point, as it's overvoltage and overclocked. >>>> >>>> This patch depends on the following patchset: >>>> >>>> http://lists.infradead.org/pipermail/linux-arm-kernel/2016-December/473962.html >>>> >>>> It's the v2 of the [PATCH 4/6] in this patchset. >>>> >>>> I think this operating point table may also apply to A23, as there's no >>>> difference except the points over 1.2GHz between A23 and A33's stock dvfs table. >>>> >>>> But as A23 CCU may not have the necessary fixes, I won't add the table to A23 >>>> now. >>>> >>>> Chen-Yu, could you test the CCU fixes I described in the patchset above on A23, >>>> then test this operating points table? >>>> >>>> If it's necessary, you can send out the CCU fixes and add one more patch that >>>> moves this opp-v2 table to sun8i-a23-a33.dtsi . >>>> >>>> arch/arm/boot/dts/sun8i-a33.dtsi | 35 +++++++++++++++++++++++++++++++++++ >>>> 1 file changed, 35 insertions(+) >>>> >>>> diff --git a/arch/arm/boot/dts/sun8i-a33.dtsi b/arch/arm/boot/dts/sun8i-a33.dtsi >>>> index 504996cbee29..0f5b2af72981 100644 >>>> --- a/arch/arm/boot/dts/sun8i-a33.dtsi >>>> +++ b/arch/arm/boot/dts/sun8i-a33.dtsi >>>> @@ -46,7 +46,42 @@ >>>> #include >>>> >>>> / { >>>> + cpu0_opp_table: opp_table0 { >>>> + compatible = "operating-points-v2"; >>>> + opp-shared; >>>> + >>>> + opp@648000000 { >>>> + opp-hz = /bits/ 64 <648000000>; >>>> + opp-microvolt = <1040000>; >>>> + clock-latency-ns = <244144>; /* 8 32k periods */ >>>> + }; >>>> + >>>> + opp@816000000 { >>>> + opp-hz = /bits/ 64 <816000000>; >>>> + opp-microvolt = <1100000>; >>>> + clock-latency-ns = <244144>; /* 8 32k periods */ >>>> + }; >>>> + >>>> + opp@1008000000 { >>>> + opp-hz = /bits/ 64 <1008000000>; >>>> + opp-microvolt = <1200000>; >>>> + clock-latency-ns = <244144>; /* 8 32k periods */ >>>> + }; >>>> + >>>> + opp@1200000000 { >>>> + opp-hz = /bits/ 64 <1200000000>; >>>> + opp-microvolt = <1320000>; >>>> + clock-latency-ns = <244144>; /* 8 32k periods */ >>>> + }; >>>> + }; >>>> + Also, there are a lot more operating points for the A33, see: https://github.com/QSchulz/linux/blob/v4.9-rc4_adc_a31_v7/cpufreq_a33/arch/arm/boot/dts/sun8i-a33.dtsi#L323-L340 They are present in the Allwinner Linux source code and in the fex of all A33-based boards. Is there a reason for not adding all opp? Quentin -- Quentin Schulz, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Subject: Re: [PATCH v2] ARM: dts: sun8i: add opp-v2 table for A33 To: Icenowy Zheng , Chen-Yu Tsai , Maxime Ripard References: <20161215182754.33921-1-icenowy@aosc.xyz> <20161219084652.kiqdkiewu5tujlyd@lukather> <11975791482156406@web2g.yandex.ru> From: Quentin Schulz Message-ID: Date: Mon, 19 Dec 2016 15:30:10 +0100 MIME-Version: 1.0 In-Reply-To: <11975791482156406@web2g.yandex.ru> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree , linux-kernel , Hans de Goede , linux-sunxi , linux-clk , linux-arm-kernel Content-Type: text/plain; charset="us-ascii" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+mturquette=baylibre.com@lists.infradead.org List-ID: On 19/12/2016 15:06, Icenowy Zheng wrote: > > > 19.12.2016, 16:54, "Chen-Yu Tsai" : >> On Mon, Dec 19, 2016 at 4:46 PM, Maxime Ripard >> wrote: >>> On Fri, Dec 16, 2016 at 02:27:54AM +0800, Icenowy Zheng wrote: >>>> An operating point table is needed for the cpu frequency adjusting to >>>> work. >>>> >>>> The operating point table is converted from the common value in >>>> extracted script.fex from many A33 board/tablets. >>>> >>>> Signed-off-by: Icenowy Zheng >>>> --- >>>> Changes since v1: >>>> - Fix format problem (blank lines). >>>> - Removed the 1.344GHz operating point, as it's overvoltage and overclocked. >>>> >>>> This patch depends on the following patchset: >>>> >>>> http://lists.infradead.org/pipermail/linux-arm-kernel/2016-December/473962.html >>>> >>>> It's the v2 of the [PATCH 4/6] in this patchset. >>>> >>>> I think this operating point table may also apply to A23, as there's no >>>> difference except the points over 1.2GHz between A23 and A33's stock dvfs table. >>>> >>>> But as A23 CCU may not have the necessary fixes, I won't add the table to A23 >>>> now. >>>> >>>> Chen-Yu, could you test the CCU fixes I described in the patchset above on A23, >>>> then test this operating points table? >>>> >>>> If it's necessary, you can send out the CCU fixes and add one more patch that >>>> moves this opp-v2 table to sun8i-a23-a33.dtsi . >>>> >>>> arch/arm/boot/dts/sun8i-a33.dtsi | 35 +++++++++++++++++++++++++++++++++++ >>>> 1 file changed, 35 insertions(+) >>>> >>>> diff --git a/arch/arm/boot/dts/sun8i-a33.dtsi b/arch/arm/boot/dts/sun8i-a33.dtsi >>>> index 504996cbee29..0f5b2af72981 100644 >>>> --- a/arch/arm/boot/dts/sun8i-a33.dtsi >>>> +++ b/arch/arm/boot/dts/sun8i-a33.dtsi >>>> @@ -46,7 +46,42 @@ >>>> #include >>>> >>>> / { >>>> + cpu0_opp_table: opp_table0 { >>>> + compatible = "operating-points-v2"; >>>> + opp-shared; >>>> + >>>> + opp@648000000 { >>>> + opp-hz = /bits/ 64 <648000000>; >>>> + opp-microvolt = <1040000>; >>>> + clock-latency-ns = <244144>; /* 8 32k periods */ >>>> + }; >>>> + >>>> + opp@816000000 { >>>> + opp-hz = /bits/ 64 <816000000>; >>>> + opp-microvolt = <1100000>; >>>> + clock-latency-ns = <244144>; /* 8 32k periods */ >>>> + }; >>>> + >>>> + opp@1008000000 { >>>> + opp-hz = /bits/ 64 <1008000000>; >>>> + opp-microvolt = <1200000>; >>>> + clock-latency-ns = <244144>; /* 8 32k periods */ >>>> + }; >>>> + >>>> + opp@1200000000 { >>>> + opp-hz = /bits/ 64 <1200000000>; >>>> + opp-microvolt = <1320000>; >>>> + clock-latency-ns = <244144>; /* 8 32k periods */ >>>> + }; >>>> + }; >>>> + Also, there are a lot more operating points for the A33, see: https://github.com/QSchulz/linux/blob/v4.9-rc4_adc_a31_v7/cpufreq_a33/arch/arm/boot/dts/sun8i-a33.dtsi#L323-L340 They are present in the Allwinner Linux source code and in the fex of all A33-based boards. Is there a reason for not adding all opp? Quentin -- Quentin Schulz, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 From: quentin.schulz@free-electrons.com (Quentin Schulz) Date: Mon, 19 Dec 2016 15:30:10 +0100 Subject: [PATCH v2] ARM: dts: sun8i: add opp-v2 table for A33 In-Reply-To: <11975791482156406@web2g.yandex.ru> References: <20161215182754.33921-1-icenowy@aosc.xyz> <20161219084652.kiqdkiewu5tujlyd@lukather> <11975791482156406@web2g.yandex.ru> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 19/12/2016 15:06, Icenowy Zheng wrote: > > > 19.12.2016, 16:54, "Chen-Yu Tsai" : >> On Mon, Dec 19, 2016 at 4:46 PM, Maxime Ripard >> wrote: >>> On Fri, Dec 16, 2016 at 02:27:54AM +0800, Icenowy Zheng wrote: >>>> An operating point table is needed for the cpu frequency adjusting to >>>> work. >>>> >>>> The operating point table is converted from the common value in >>>> extracted script.fex from many A33 board/tablets. >>>> >>>> Signed-off-by: Icenowy Zheng >>>> --- >>>> Changes since v1: >>>> - Fix format problem (blank lines). >>>> - Removed the 1.344GHz operating point, as it's overvoltage and overclocked. >>>> >>>> This patch depends on the following patchset: >>>> >>>> http://lists.infradead.org/pipermail/linux-arm-kernel/2016-December/473962.html >>>> >>>> It's the v2 of the [PATCH 4/6] in this patchset. >>>> >>>> I think this operating point table may also apply to A23, as there's no >>>> difference except the points over 1.2GHz between A23 and A33's stock dvfs table. >>>> >>>> But as A23 CCU may not have the necessary fixes, I won't add the table to A23 >>>> now. >>>> >>>> Chen-Yu, could you test the CCU fixes I described in the patchset above on A23, >>>> then test this operating points table? >>>> >>>> If it's necessary, you can send out the CCU fixes and add one more patch that >>>> moves this opp-v2 table to sun8i-a23-a33.dtsi . >>>> >>>> arch/arm/boot/dts/sun8i-a33.dtsi | 35 +++++++++++++++++++++++++++++++++++ >>>> 1 file changed, 35 insertions(+) >>>> >>>> diff --git a/arch/arm/boot/dts/sun8i-a33.dtsi b/arch/arm/boot/dts/sun8i-a33.dtsi >>>> index 504996cbee29..0f5b2af72981 100644 >>>> --- a/arch/arm/boot/dts/sun8i-a33.dtsi >>>> +++ b/arch/arm/boot/dts/sun8i-a33.dtsi >>>> @@ -46,7 +46,42 @@ >>>> #include >>>> >>>> / { >>>> + cpu0_opp_table: opp_table0 { >>>> + compatible = "operating-points-v2"; >>>> + opp-shared; >>>> + >>>> + opp at 648000000 { >>>> + opp-hz = /bits/ 64 <648000000>; >>>> + opp-microvolt = <1040000>; >>>> + clock-latency-ns = <244144>; /* 8 32k periods */ >>>> + }; >>>> + >>>> + opp at 816000000 { >>>> + opp-hz = /bits/ 64 <816000000>; >>>> + opp-microvolt = <1100000>; >>>> + clock-latency-ns = <244144>; /* 8 32k periods */ >>>> + }; >>>> + >>>> + opp at 1008000000 { >>>> + opp-hz = /bits/ 64 <1008000000>; >>>> + opp-microvolt = <1200000>; >>>> + clock-latency-ns = <244144>; /* 8 32k periods */ >>>> + }; >>>> + >>>> + opp at 1200000000 { >>>> + opp-hz = /bits/ 64 <1200000000>; >>>> + opp-microvolt = <1320000>; >>>> + clock-latency-ns = <244144>; /* 8 32k periods */ >>>> + }; >>>> + }; >>>> + Also, there are a lot more operating points for the A33, see: https://github.com/QSchulz/linux/blob/v4.9-rc4_adc_a31_v7/cpufreq_a33/arch/arm/boot/dts/sun8i-a33.dtsi#L323-L340 They are present in the Allwinner Linux source code and in the fex of all A33-based boards. Is there a reason for not adding all opp? Quentin -- Quentin Schulz, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com