From mboxrd@z Thu Jan 1 00:00:00 1970 From: Xiao Guangrong Subject: Re: [PATCH v2 0/8] nvdimm: hotplug support Date: Fri, 19 Aug 2016 11:46:38 +0800 Message-ID: References: <1470984850-66891-1-git-send-email-guangrong.xiao@linux.intel.com> <20160818185438.GA7799@omniknight.lm.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: Paolo Bonzini , Igor Mammedov , Gleb Natapov , mtosatti@redhat.com, stefanha@redhat.com, "Michael S. Tsirkin" , rth@twiddle.net, ehabkost@redhat.com, KVM list , qemu-devel@nongnu.org To: Vishal Verma , Dan Williams Return-path: Received: from mga11.intel.com ([192.55.52.93]:36142 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752511AbcHSDvk (ORCPT ); Thu, 18 Aug 2016 23:51:40 -0400 In-Reply-To: Sender: kvm-owner@vger.kernel.org List-ID: On 08/19/2016 11:40 AM, Xiao Guangrong wrote: > > > On 08/19/2016 02:54 AM, Vishal Verma wrote: >> On 08/18, Dan Williams wrote: >>> [ adding Vishal who implemented the kernel side of nvdimm hotplug support ] >>> >>> On Thu, Aug 11, 2016 at 11:54 PM, Xiao Guangrong >>> wrote: >>>> This patchset is against commit c597dc90fbcd6 (virtio-net: allow increasing >>>> rx queue siz) on pci branch of Michael's git tree and can be found at: >>>> https://github.com/xiaogr/qemu.git nvdimm-hotplug-v2 >>>> >>>> Changelog in v2: >>>> Fixed signed integer overflow pointed out by Stefan Hajnoczi >>>> >>>> This patchset enables nvdimm hotplug support, it is used as pc-dimm hotplug, >>>> for example, a new nvdimm device can be plugged as follows: >>>> object_add memory-backend-file,id=mem3,size=10G,mem-path=/home/eric/nvdimm3 >>>> device_add nvdimm,id=nvdimm3,memdev=mem3 >>>> >>>> and unplug it as follows: >>>> device_del nvdimm3 >>>> object_del mem3 >>> >>> Did you test this against the Linux NFIT hotplug support? We just >>> found that the Linux driver is not properly registering for ACPI0012 >>> event notification. Is a notification sent on a 'device_add' event? >> >> I've just sent out a patch that should fix this: >> https://lists.01.org/pipermail/linux-nvdimm/2016-August/006637.html >> > > Interesting. I am using the kvm tree, queue branch, the top commit is > 8ff7b956471f: > Merge tag 'kvm-s390-next-4.8-2' of git://git.kernel.org/pub/scm/linux/kernel > > It works. It triggers 'notify' event, not 'device add'. From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42053) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1baaqO-00048F-RT for qemu-devel@nongnu.org; Thu, 18 Aug 2016 23:51:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1baaqK-000606-Mn for qemu-devel@nongnu.org; Thu, 18 Aug 2016 23:51:43 -0400 Received: from mga14.intel.com ([192.55.52.115]:53282) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1baaqK-000602-GA for qemu-devel@nongnu.org; Thu, 18 Aug 2016 23:51:40 -0400 References: <1470984850-66891-1-git-send-email-guangrong.xiao@linux.intel.com> <20160818185438.GA7799@omniknight.lm.intel.com> From: Xiao Guangrong Message-ID: Date: Fri, 19 Aug 2016 11:46:38 +0800 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 0/8] nvdimm: hotplug support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Vishal Verma , Dan Williams Cc: Paolo Bonzini , Igor Mammedov , Gleb Natapov , mtosatti@redhat.com, stefanha@redhat.com, "Michael S. Tsirkin" , rth@twiddle.net, ehabkost@redhat.com, KVM list , qemu-devel@nongnu.org On 08/19/2016 11:40 AM, Xiao Guangrong wrote: > > > On 08/19/2016 02:54 AM, Vishal Verma wrote: >> On 08/18, Dan Williams wrote: >>> [ adding Vishal who implemented the kernel side of nvdimm hotplug support ] >>> >>> On Thu, Aug 11, 2016 at 11:54 PM, Xiao Guangrong >>> wrote: >>>> This patchset is against commit c597dc90fbcd6 (virtio-net: allow increasing >>>> rx queue siz) on pci branch of Michael's git tree and can be found at: >>>> https://github.com/xiaogr/qemu.git nvdimm-hotplug-v2 >>>> >>>> Changelog in v2: >>>> Fixed signed integer overflow pointed out by Stefan Hajnoczi >>>> >>>> This patchset enables nvdimm hotplug support, it is used as pc-dimm hotplug, >>>> for example, a new nvdimm device can be plugged as follows: >>>> object_add memory-backend-file,id=mem3,size=10G,mem-path=/home/eric/nvdimm3 >>>> device_add nvdimm,id=nvdimm3,memdev=mem3 >>>> >>>> and unplug it as follows: >>>> device_del nvdimm3 >>>> object_del mem3 >>> >>> Did you test this against the Linux NFIT hotplug support? We just >>> found that the Linux driver is not properly registering for ACPI0012 >>> event notification. Is a notification sent on a 'device_add' event? >> >> I've just sent out a patch that should fix this: >> https://lists.01.org/pipermail/linux-nvdimm/2016-August/006637.html >> > > Interesting. I am using the kvm tree, queue branch, the top commit is > 8ff7b956471f: > Merge tag 'kvm-s390-next-4.8-2' of git://git.kernel.org/pub/scm/linux/kernel > > It works. It triggers 'notify' event, not 'device add'.