From mboxrd@z Thu Jan 1 00:00:00 1970 From: Phil Turmel Subject: Re: hung grow Date: Tue, 10 Oct 2017 10:15:07 -0400 Message-ID: References: <7e23d39b-aebb-0852-c98f-758bd99d3eb9@turmel.org> <89992d1f-172f-9fc6-3a1e-50df34e11d3b@turmel.org> <87po9xyv0r.fsf@notabene.neil.brown.name> <87d15xymgc.fsf@notabene.neil.brown.name> <0d4987d9-e8ff-0cdb-6e45-7f962b75c189@turmel.org> <3e5766b0-1437-2857-4806-264386d1633f@youngman.org.uk> <6d4b7055-c26c-951e-b63c-273a7fe447b8@turmel.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Content-Language: en-GB Sender: linux-raid-owner@vger.kernel.org To: Curt Cc: Anthony Youngman , NeilBrown , linux-raid@vger.kernel.org List-Id: linux-raid.ids On 10/10/2017 10:11 AM, Curt wrote: >> >> I've never seen this before, and don't have time at the moment >> to read the code to understand what it means. > I did a search and here's the comment before the code I found spits > out that error message. I don't know if it's useful to you > /* reshape_position is a little messy. > * Its value must be a multiple of the larger > * chunk size, and of the "after" data disks. > * So when reverting we need to change it to > * be a multiple of the new "after" data disks, > * which is the old "before". > * If it isn't already a multiple of 'before', > * the only thing we could do would be > * copy some block around on the disks, which > * is easy to get wrong. > * So we reject a revert-reshape unless the > * alignment is good. > */ > if (reshape_sectors % reshape_chunk) > > That doesn't read good for me. Yup. >> Probably. But yeah, "fit state". That's the magic. /-: >> > What are the chances if I just do an assemble and let it try to grow > again that it will complete without issue? Then assuming it completes, > that I will have most my data still? Yeah, try without the revert. You don't have to wait for the reshape to finish to grab your critical files off of it. In fact, you might want to freeze the reshape to minimize the chance of hitting a not-yet-found URE. Phil