Re: [OE-core] [PATCH] layer.conf: fix adwaita-icon-theme signature change problem

["Changqing Li" <changqing.li@windriver.com>]

On 7/23/20 4:35 PM, Khem Raj wrote:
> infact the error is not limited to just one theme recipe but all which
> inherit this class see
>
> http://jenkins.nas-admin.org/view/OE/job/oe_world_workspace-compare-signatures/980/console
>
> so are we forcing same kind of fix everywhere ? seems a bit of kludge to me

Yes,  I also noticed that  there are several recipes under other layer 
have same problem,

and that's why I say this fix maybe not a good idea.  but signatures 
generated very early,

SIGGEN_EXCLUDE_SAFE_RECIPE_DEPS not work if set in the 
gtk-icon-cache.bbclass.

Any other good idea? Thanks.

>
> On Wed, Jul 22, 2020 at 11:55 PM Changqing Li
> <changqing.li@windriver.com> wrote:
>> From: Changqing Li <changqing.li@windriver.com>
>>
>> allarch package adwaita-icon-theme inherit both allarch and
>> gtk-icon-cache, since commit 31e3d34c8a9c3e8481aa837aa0bf52adf095fe62
>> [gtk-icon-cache.bbclass: add runtime dependency], it start depend on
>> non-allarch packages gdk-pixbuf and gtk+3, which make it's signature
>> changes when machine changed.
>>
>> like for task do_prepare_recipe_sysroot:
>> "Hash for dependent task
>> gdk-pixbuf/gdk-pixbuf_2.40.0.bb:do_populate_sysroot changed from
>> a72aba8432699c8ce4ca1f71833ef14a89ffde0ea4063e37b9d819fdb1e407f4 to
>> 1ad4e1bd76921b71482657f3b017184e9ade8e2a0b9f43ad64ed2dda83b1520f"
>>
>> the only way to fix this is remove the task dependency.
>> SIGGEN_EXCLUDE_SAFE_RECIPE_DEPS not work in class, so add it in
>> layer.conf.
>>
>> Maybe we have other recipes under other layers have similar problem, we
>> can only add one by one to its layer.conf, seems not a good idea. but
>> add *->pixbuf will influence other packages
>>
>> Signed-off-by: Changqing Li <changqing.li@windriver.com>
>> ---
>>   meta/conf/layer.conf | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/meta/conf/layer.conf b/meta/conf/layer.conf
>> index 098ef12ac6..c115c87043 100644
>> --- a/meta/conf/layer.conf
>> +++ b/meta/conf/layer.conf
>> @@ -80,6 +80,8 @@ SIGGEN_EXCLUDE_SAFE_RECIPE_DEPS += " \
>>     weston-init->kbd \
>>     connman->xl2tpd \
>>     lttng-tools->lttng-modules \
>> +  adwaita-icon-theme->gdk-pixbuf \
>> +  adwaita-icon-theme->gtk+3 \
>>   "
>>
>>   # Avoid adding bison-native to the sysroot without a specific
>> --
>> 2.17.1
>>
>>