All of lore.kernel.org
 help / color / mirror / Atom feed
From: Josef Bacik <jbacik@fb.com>
To: Chandan Rajendra <chandan@linux.vnet.ibm.com>,
	<linux-btrfs@vger.kernel.org>
Cc: <dsterba@suse.cz>, <clm@fb.com>, <chandan@mykolab.com>
Subject: Re: [PATCH V18 00/18] Allow I/O on blocks whose size is less than page size
Date: Tue, 26 Apr 2016 11:22:14 -0400	[thread overview]
Message-ID: <e8e4fc53-93ee-cd46-474d-02fe935802ea@fb.com> (raw)
In-Reply-To: <1461677237-7703-1-git-send-email-chandan@linux.vnet.ibm.com>

On 04/26/2016 09:26 AM, Chandan Rajendra wrote:
> Btrfs assumes block size to be the same as the machine's page
> size. This would mean that a Btrfs instance created on a 4k page size
> machine (e.g. x86) will not be mountable on machines with larger page
> sizes (e.g. PPC64/AARCH64). This patchset aims to resolve this
> incompatibility.
>
> This patchset continues with the work posted previously at
> https://urldefense.proofpoint.com/v2/url?u=http-3A__thread.gmane.org_gmane.comp.file-2Dsystems.btrfs_55257&d=CwIBAg&c=5VD0RTtNlTh3ycd41b3MUw&r=sDzg6MvHymKOUgI8SFIm4Q&m=HOo9J04GyB-3WnF7O0oScGWuin-MaYuh9OMQrAFNE-0&s=ZGXiVRRSCQha83XunflDOkpffSfDEy8OKzFHRud6oXw&e= .
>
> I have reverted the upstream commit "btrfs: fix lockups from
> btrfs_clear_path_blocking" (f82c458a2c3ffb94b431fc6ad791a79df1b3713e)
> since this led to soft-lockups when the patch "Btrfs:
> subpagesize-blocksize: Prevent writes to an extent buffer when
> PG_writeback flag is set" is applied. During 2015's Vault Conference
> Btrfs meetup, Chris Mason had suggested that he will write up a
> suitable locking function to be used when writing dirty pages that map
> metadata blocks. Until we have a suitable locking function available,
> this patchset temporarily disables the commit
> f82c458a2c3ffb94b431fc6ad791a79df1b3713e.
>
> The commits for the Btrfs kernel module can be found at
> https://github.com/chandanr/linux/tree/btrfs/subpagesize-blocksize.
>
> To create a filesystem with block size < page size, a patched version
> of the Btrfs-progs package is required. The corresponding fixes for
> Btrfs-progs can be found at
> https://github.com/chandanr/btrfs-progs/tree/btrfs/subpagesize-blocksize.
>
> Fstests run status:
> 1. x86_64
>    - With 4k sectorsize, all the tests that succeed with the master
>      branch at git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux.git
>      branch also do so with the patches applied.
> 2. ppc64
>    - With 4k sectorsize, 16k nodesize and with "nospace_cache" mount
>      option, except for scrub and compression tests, all the tests
>      that succeed with the master branch at
>      git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux.git
>      branch also do so with the patches applied.
>    - With 64k sectorsize & nodesize, all the tests that succeed with
>      the master branch at
>      git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux.git
>      branch also do so with the patches applied.
>
> TODO:
> 1. The selftests code needs to be fixed to work in subpage-blocksize
>    scenario. I have currently disabled self-tests from my kernel
>    configuration. We can expect an mail from kbuild indicating a
>    build failure for self-tests code.
> 2. I am planning to fix Scrub & Compression via a separate patchset.
>

The selftests need to pass, I don't want to have to deal with kbuild 
failures and have to remember it's because selftests don't work right 
with sub page blocksizes.  Thanks,

Josef


  parent reply	other threads:[~2016-04-26 15:22 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-26 13:26 [PATCH V18 00/18] Allow I/O on blocks whose size is less than page size Chandan Rajendra
2016-04-26 13:27 ` [PATCH V18 01/18] Btrfs: subpage-blocksize: Fix whole page read Chandan Rajendra
2016-04-26 15:51   ` Josef Bacik
2016-04-27  5:24     ` Chandan Rajendra
2016-04-27 15:12       ` Josef Bacik
2016-04-26 13:27 ` [PATCH V18 02/18] Btrfs: subpage-blocksize: Fix whole page write Chandan Rajendra
2016-04-26 13:27 ` [PATCH V18 03/18] Btrfs: subpage-blocksize: Make sure delalloc range intersects with the locked page's range Chandan Rajendra
2016-04-26 13:27 ` [PATCH V18 04/18] Btrfs: subpage-blocksize: Define extent_buffer_head Chandan Rajendra
2016-04-26 13:27 ` [PATCH V18 05/18] Btrfs: subpage-blocksize: Read tree blocks whose size is < PAGE_SIZE Chandan Rajendra
2016-04-26 13:27 ` [PATCH V18 06/18] Btrfs: subpage-blocksize: Write only dirty extent buffers belonging to a page Chandan Rajendra
2016-04-26 13:27 ` [PATCH V18 07/18] Btrfs: subpage-blocksize: Allow mounting filesystems where sectorsize < PAGE_SIZE Chandan Rajendra
2016-04-26 13:27 ` [PATCH V18 08/18] Btrfs: subpage-blocksize: Deal with partial ordered extent allocations Chandan Rajendra
2016-04-26 13:27 ` [PATCH V18 09/18] Btrfs: subpage-blocksize: Explicitly track I/O status of blocks of an ordered extent Chandan Rajendra
2016-04-26 13:27 ` [PATCH V18 10/18] Btrfs: subpage-blocksize: btrfs_punch_hole: Fix uptodate blocks check Chandan Rajendra
2016-04-26 13:27 ` [PATCH V18 11/18] Btrfs: subpage-blocksize: Prevent writes to an extent buffer when PG_writeback flag is set Chandan Rajendra
2016-04-26 13:27 ` [PATCH V18 12/18] Revert "btrfs: fix lockups from btrfs_clear_path_blocking" Chandan Rajendra
2016-04-26 13:27 ` [PATCH V18 13/18] Btrfs: subpage-blocksize: Fix file defragmentation code Chandan Rajendra
2016-04-26 13:27 ` [PATCH V18 14/18] Btrfs: subpage-blocksize: extent_clear_unlock_delalloc: Prevent page from being unlocked more than once Chandan Rajendra
2016-04-26 13:27 ` [PATCH V18 15/18] Btrfs: subpage-blocksize: Enable dedupe ioctl Chandan Rajendra
2016-04-26 13:27 ` [PATCH V18 16/18] Btrfs: btrfs_clone: Flush dirty blocks of a page that do not map the clone range Chandan Rajendra
2016-04-26 13:27 ` [PATCH V18 17/18] Btrfs: subpage-blocksize: Make file extent relocate code subpage blocksize aware Chandan Rajendra
2016-04-26 13:27 ` [PATCH V18 18/18] Btrfs: subpage-blocksize: __btrfs_lookup_bio_sums: Set offset when moving to a new bio_vec Chandan Rajendra
2016-04-26 13:54 ` [PATCH V18 00/18] Allow I/O on blocks whose size is less than page size Filipe Manana
2016-04-26 15:18   ` Chandan Rajendra
2016-04-27 17:15     ` David Sterba
2016-04-28  4:31       ` Chandan Rajendra
2016-04-26 15:22 ` Josef Bacik [this message]
2016-04-27 17:18   ` David Sterba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e8e4fc53-93ee-cd46-474d-02fe935802ea@fb.com \
    --to=jbacik@fb.com \
    --cc=chandan@linux.vnet.ibm.com \
    --cc=chandan@mykolab.com \
    --cc=clm@fb.com \
    --cc=dsterba@suse.cz \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.