From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 365642020F932 for ; Tue, 20 Aug 2019 12:09:50 -0700 (PDT) Subject: Re: [PATCH v13 00/18] kunit: introduce KUnit, the Linux kernel unit testing framework References: <20190814055108.214253-1-brendanhiggins@google.com> <5b880f49-0213-1a6e-9c9f-153e6ab91eeb@kernel.org> <20190820182450.GA38078@google.com> From: shuah Message-ID: Date: Tue, 20 Aug 2019 13:08:28 -0600 MIME-Version: 1.0 In-Reply-To: <20190820182450.GA38078@google.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: Brendan Higgins Cc: pmladek@suse.com, linux-doc@vger.kernel.org, peterz@infradead.org, amir73il@gmail.com, dri-devel@lists.freedesktop.org, Alexander.Levin@microsoft.com, yamada.masahiro@socionext.com, mpe@ellerman.id.au, linux-kselftest@vger.kernel.org, frowand.list@gmail.com, robh@kernel.org, linux-nvdimm@lists.01.org, khilman@baylibre.com, knut.omang@oracle.com, kieran.bingham@ideasonboard.com, wfg@linux.intel.com, joel@jms.id.au, rientjes@google.com, jdike@addtoit.com, dan.carpenter@oracle.com, devicetree@vger.kernel.org, shuah , linux-kbuild@vger.kernel.org, Tim.Bird@sony.com, linux-um@lists.infradead.org, rostedt@goodmis.org, julia.lawall@lip6.fr, jpoimboe@redhat.com, Bjorn Helgaas , kunit-dev@googlegroups.com, tytso@mit.edu, richard@nod.at, sboyd@kernel.org, gregkh@linuxfoundation.org, rdunlap@infradead.org, linux-kernel@vger.kernel.org, mcgrof@kernel.org, daniel@ffwll.ch, keescook@google.com, linux-fsdevel@vger.kernel.org List-ID: On 8/20/19 12:24 PM, Brendan Higgins wrote: > On Tue, Aug 20, 2019 at 11:24:45AM -0600, shuah wrote: >> On 8/13/19 11:50 PM, Brendan Higgins wrote: >>> ## TL;DR >>> >>> This revision addresses comments from Stephen and Bjorn Helgaas. Most >>> changes are pretty minor stuff that doesn't affect the API in anyway. >>> One significant change, however, is that I added support for freeing >>> kunit_resource managed resources before the test case is finished via >>> kunit_resource_destroy(). Additionally, Bjorn pointed out that I broke >>> KUnit on certain configurations (like the default one for x86, whoops). >>> >>> Based on Stephen's feedback on the previous change, I think we are >>> pretty close. I am not expecting any significant changes from here on >>> out. >>> >> >> Hi Brendan, >> >> I found checkpatch errors in one or two patches. Can you fix those and >> send v14. > > Hi Shuah, > > Are you refering to the following errors? > > ERROR: Macros with complex values should be enclosed in parentheses > #144: FILE: include/kunit/test.h:456: > +#define KUNIT_BINARY_CLASS \ > + kunit_binary_assert, KUNIT_INIT_BINARY_ASSERT_STRUCT > > ERROR: Macros with complex values should be enclosed in parentheses > #146: FILE: include/kunit/test.h:458: > +#define KUNIT_BINARY_PTR_CLASS \ > + kunit_binary_ptr_assert, KUNIT_INIT_BINARY_PTR_ASSERT_STRUCT > > These values should *not* be in parentheses. I am guessing checkpatch is > getting confused and thinks that these are complex expressions, when > they are not. > > I ignored the errors since I figured checkpatch was complaining > erroneously. > > I could refactor the code to remove these macros entirely, but I think > the code is cleaner with them. > Please do. I am not veru sure what value these macros add. thanks, -- Shuah _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 710E5C3A589 for ; Tue, 20 Aug 2019 19:08:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 46A7A22DA9 for ; Tue, 20 Aug 2019 19:08:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1566328115; bh=EQcE7jgODYPqBxFha4axxuVZtCHbZv+lyg0wG/vxuqE=; h=Subject:To:Cc:References:From:Date:In-Reply-To:List-ID:From; b=T97FVgNqfRVH5a1eceh4bDW9d2ZVKRS94mRNSaQMVCKNtYjsk5qHYzeWGGlqBY7k7 g/Zv9nOmTp8eHHuU/nrdkUdBhWKncwoQCVOV6m/hbEoIkr7srCv3bjL+ynjjqH7QA9 5u0SXgeyw3yRVD5z1ulsriKS+SfU9t+3HLUCUhIM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730681AbfHTTIe (ORCPT ); Tue, 20 Aug 2019 15:08:34 -0400 Received: from mail.kernel.org ([198.145.29.99]:36644 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728185AbfHTTIe (ORCPT ); Tue, 20 Aug 2019 15:08:34 -0400 Received: from [192.168.1.112] (c-24-9-64-241.hsd1.co.comcast.net [24.9.64.241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id EDF8A2082F; Tue, 20 Aug 2019 19:08:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1566328112; bh=EQcE7jgODYPqBxFha4axxuVZtCHbZv+lyg0wG/vxuqE=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=V//JOo/nBlns1BIGxHPsWcL0jiR9TJx2KmCu8eYP4YNIYAdhdLuzoIx3vOjLgJOWf qywhT+G/ZqWkgzBVmgCpi40PPee/iCkXqnClTUaQ9H817cboZ6rQYsqsdhOXzkxXEe SSvE0tF9mSLKe15z7ad2lgpjVB8OR8ObBpC4AYuQ= Subject: Re: [PATCH v13 00/18] kunit: introduce KUnit, the Linux kernel unit testing framework To: Brendan Higgins Cc: frowand.list@gmail.com, gregkh@linuxfoundation.org, jpoimboe@redhat.com, keescook@google.com, kieran.bingham@ideasonboard.com, mcgrof@kernel.org, peterz@infradead.org, robh@kernel.org, sboyd@kernel.org, tytso@mit.edu, yamada.masahiro@socionext.com, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, kunit-dev@googlegroups.com, linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-nvdimm@lists.01.org, linux-um@lists.infradead.org, Alexander.Levin@microsoft.com, Tim.Bird@sony.com, amir73il@gmail.com, dan.carpenter@oracle.com, daniel@ffwll.ch, jdike@addtoit.com, joel@jms.id.au, julia.lawall@lip6.fr, khilman@baylibre.com, knut.omang@oracle.com, logang@deltatee.com, mpe@ellerman.id.au, pmladek@suse.com, rdunlap@infradead.org, richard@nod.at, rientjes@google.com, rostedt@goodmis.org, wfg@linux.intel.com, Bjorn Helgaas , shuah References: <20190814055108.214253-1-brendanhiggins@google.com> <5b880f49-0213-1a6e-9c9f-153e6ab91eeb@kernel.org> <20190820182450.GA38078@google.com> From: shuah Message-ID: Date: Tue, 20 Aug 2019 13:08:28 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190820182450.GA38078@google.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/20/19 12:24 PM, Brendan Higgins wrote: > On Tue, Aug 20, 2019 at 11:24:45AM -0600, shuah wrote: >> On 8/13/19 11:50 PM, Brendan Higgins wrote: >>> ## TL;DR >>> >>> This revision addresses comments from Stephen and Bjorn Helgaas. Most >>> changes are pretty minor stuff that doesn't affect the API in anyway. >>> One significant change, however, is that I added support for freeing >>> kunit_resource managed resources before the test case is finished via >>> kunit_resource_destroy(). Additionally, Bjorn pointed out that I broke >>> KUnit on certain configurations (like the default one for x86, whoops). >>> >>> Based on Stephen's feedback on the previous change, I think we are >>> pretty close. I am not expecting any significant changes from here on >>> out. >>> >> >> Hi Brendan, >> >> I found checkpatch errors in one or two patches. Can you fix those and >> send v14. > > Hi Shuah, > > Are you refering to the following errors? > > ERROR: Macros with complex values should be enclosed in parentheses > #144: FILE: include/kunit/test.h:456: > +#define KUNIT_BINARY_CLASS \ > + kunit_binary_assert, KUNIT_INIT_BINARY_ASSERT_STRUCT > > ERROR: Macros with complex values should be enclosed in parentheses > #146: FILE: include/kunit/test.h:458: > +#define KUNIT_BINARY_PTR_CLASS \ > + kunit_binary_ptr_assert, KUNIT_INIT_BINARY_PTR_ASSERT_STRUCT > > These values should *not* be in parentheses. I am guessing checkpatch is > getting confused and thinks that these are complex expressions, when > they are not. > > I ignored the errors since I figured checkpatch was complaining > erroneously. > > I could refactor the code to remove these macros entirely, but I think > the code is cleaner with them. > Please do. I am not veru sure what value these macros add. thanks, -- Shuah From mboxrd@z Thu Jan 1 00:00:00 1970 From: shuah Subject: Re: [PATCH v13 00/18] kunit: introduce KUnit, the Linux kernel unit testing framework Date: Tue, 20 Aug 2019 13:08:28 -0600 Message-ID: References: <20190814055108.214253-1-brendanhiggins@google.com> <5b880f49-0213-1a6e-9c9f-153e6ab91eeb@kernel.org> <20190820182450.GA38078@google.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20190820182450.GA38078@google.com> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Brendan Higgins Cc: frowand.list@gmail.com, gregkh@linuxfoundation.org, jpoimboe@redhat.com, keescook@google.com, kieran.bingham@ideasonboard.com, mcgrof@kernel.org, peterz@infradead.org, robh@kernel.org, sboyd@kernel.org, tytso@mit.edu, yamada.masahiro@socionext.com, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, kunit-dev@googlegroups.com, linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-nvdimm@lists.01.org, linux-um@lists.infradead.org, Alexander.Levin@microsoft.com, Tim.Bird@sony.com, amir73il@gmail.com, dan.carpenter@oracle.com, daniel@ffwll.ch, jdike@addtoit.com, joel@jms.id.au, julia.lawall@lip6.fr, khilman@baylibre.com, knut.omang@oracle.com, logang@deltatee.com, mp List-Id: devicetree@vger.kernel.org On 8/20/19 12:24 PM, Brendan Higgins wrote: > On Tue, Aug 20, 2019 at 11:24:45AM -0600, shuah wrote: >> On 8/13/19 11:50 PM, Brendan Higgins wrote: >>> ## TL;DR >>> >>> This revision addresses comments from Stephen and Bjorn Helgaas. Most >>> changes are pretty minor stuff that doesn't affect the API in anyway. >>> One significant change, however, is that I added support for freeing >>> kunit_resource managed resources before the test case is finished via >>> kunit_resource_destroy(). Additionally, Bjorn pointed out that I broke >>> KUnit on certain configurations (like the default one for x86, whoops). >>> >>> Based on Stephen's feedback on the previous change, I think we are >>> pretty close. I am not expecting any significant changes from here on >>> out. >>> >> >> Hi Brendan, >> >> I found checkpatch errors in one or two patches. Can you fix those and >> send v14. > > Hi Shuah, > > Are you refering to the following errors? > > ERROR: Macros with complex values should be enclosed in parentheses > #144: FILE: include/kunit/test.h:456: > +#define KUNIT_BINARY_CLASS \ > + kunit_binary_assert, KUNIT_INIT_BINARY_ASSERT_STRUCT > > ERROR: Macros with complex values should be enclosed in parentheses > #146: FILE: include/kunit/test.h:458: > +#define KUNIT_BINARY_PTR_CLASS \ > + kunit_binary_ptr_assert, KUNIT_INIT_BINARY_PTR_ASSERT_STRUCT > > These values should *not* be in parentheses. I am guessing checkpatch is > getting confused and thinks that these are complex expressions, when > they are not. > > I ignored the errors since I figured checkpatch was complaining > erroneously. > > I could refactor the code to remove these macros entirely, but I think > the code is cleaner with them. > Please do. I am not veru sure what value these macros add. thanks, -- Shuah From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1i09Uf-0005kt-FT for linux-um@lists.infradead.org; Tue, 20 Aug 2019 19:08:34 +0000 Subject: Re: [PATCH v13 00/18] kunit: introduce KUnit, the Linux kernel unit testing framework References: <20190814055108.214253-1-brendanhiggins@google.com> <5b880f49-0213-1a6e-9c9f-153e6ab91eeb@kernel.org> <20190820182450.GA38078@google.com> From: shuah Message-ID: Date: Tue, 20 Aug 2019 13:08:28 -0600 MIME-Version: 1.0 In-Reply-To: <20190820182450.GA38078@google.com> Content-Language: en-US List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-um" Errors-To: linux-um-bounces+geert=linux-m68k.org@lists.infradead.org To: Brendan Higgins Cc: pmladek@suse.com, linux-doc@vger.kernel.org, peterz@infradead.org, amir73il@gmail.com, dri-devel@lists.freedesktop.org, Alexander.Levin@microsoft.com, yamada.masahiro@socionext.com, mpe@ellerman.id.au, linux-kselftest@vger.kernel.org, frowand.list@gmail.com, robh@kernel.org, linux-nvdimm@lists.01.org, khilman@baylibre.com, knut.omang@oracle.com, kieran.bingham@ideasonboard.com, wfg@linux.intel.com, joel@jms.id.au, rientjes@google.com, jdike@addtoit.com, dan.carpenter@oracle.com, devicetree@vger.kernel.org, shuah , linux-kbuild@vger.kernel.org, Tim.Bird@sony.com, linux-um@lists.infradead.org, rostedt@goodmis.org, julia.lawall@lip6.fr, jpoimboe@redhat.com, Bjorn Helgaas , kunit-dev@googlegroups.com, tytso@mit.edu, richard@nod.at, sboyd@kernel.org, gregkh@linuxfoundation.org, rdunlap@infradead.org, linux-kernel@vger.kernel.org, mcgrof@kernel.org, daniel@ffwll.ch, keescook@google.com, linux-fsdevel@vger.kernel.org, logang@deltatee.com On 8/20/19 12:24 PM, Brendan Higgins wrote: > On Tue, Aug 20, 2019 at 11:24:45AM -0600, shuah wrote: >> On 8/13/19 11:50 PM, Brendan Higgins wrote: >>> ## TL;DR >>> >>> This revision addresses comments from Stephen and Bjorn Helgaas. Most >>> changes are pretty minor stuff that doesn't affect the API in anyway. >>> One significant change, however, is that I added support for freeing >>> kunit_resource managed resources before the test case is finished via >>> kunit_resource_destroy(). Additionally, Bjorn pointed out that I broke >>> KUnit on certain configurations (like the default one for x86, whoops). >>> >>> Based on Stephen's feedback on the previous change, I think we are >>> pretty close. I am not expecting any significant changes from here on >>> out. >>> >> >> Hi Brendan, >> >> I found checkpatch errors in one or two patches. Can you fix those and >> send v14. > > Hi Shuah, > > Are you refering to the following errors? > > ERROR: Macros with complex values should be enclosed in parentheses > #144: FILE: include/kunit/test.h:456: > +#define KUNIT_BINARY_CLASS \ > + kunit_binary_assert, KUNIT_INIT_BINARY_ASSERT_STRUCT > > ERROR: Macros with complex values should be enclosed in parentheses > #146: FILE: include/kunit/test.h:458: > +#define KUNIT_BINARY_PTR_CLASS \ > + kunit_binary_ptr_assert, KUNIT_INIT_BINARY_PTR_ASSERT_STRUCT > > These values should *not* be in parentheses. I am guessing checkpatch is > getting confused and thinks that these are complex expressions, when > they are not. > > I ignored the errors since I figured checkpatch was complaining > erroneously. > > I could refactor the code to remove these macros entirely, but I think > the code is cleaner with them. > Please do. I am not veru sure what value these macros add. thanks, -- Shuah _______________________________________________ linux-um mailing list linux-um@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-um