From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.9 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1E8EC433EF for ; Sun, 5 Sep 2021 08:05:07 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2958160F9F for ; Sun, 5 Sep 2021 08:05:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 2958160F9F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:56910 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mMn9F-0006OD-R6 for qemu-devel@archiver.kernel.org; Sun, 05 Sep 2021 04:05:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59154) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mMn8B-0004M9-FU for qemu-devel@nongnu.org; Sun, 05 Sep 2021 04:03:59 -0400 Received: from mail-wr1-x431.google.com ([2a00:1450:4864:20::431]:39742) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mMn86-0004qT-AB for qemu-devel@nongnu.org; Sun, 05 Sep 2021 04:03:58 -0400 Received: by mail-wr1-x431.google.com with SMTP id z4so4901155wrr.6 for ; Sun, 05 Sep 2021 01:03:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=ONDliamBoZzm2VL6YJKXlkz2ekKu0QeUOQxu5FK8uWY=; b=fu80oLwpeK7TKEI65D1qoNioFiLvMzIoq7dQIRF+JaFxGZyhVq6xm/vDEtD7qPjDLq 3reA1ABuU9bQXn6lLgHXqZzg/Y/4Kq08nduCbS8LkArs823QiQIPAWNxANNCpUM2UOZL Pf3RQN2S5KYMVlfInqBx+p2PIS1RNuw2X338NdXOrrcRTkXd8T3c3XpvN++70ZeaowdV Zr0NqA1k7la5NWkGCFFjF0Bemx7H3xTFnd7IDzxqyi2QAAK/eVOE782wcs+Kxel5JxOG e2SdgXvzaiB7aaHyXNm0I3fTuIxRacKJZe78QdLGWTW5l4p7OxK27UwG5HurFmIvv2Os +CtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ONDliamBoZzm2VL6YJKXlkz2ekKu0QeUOQxu5FK8uWY=; b=NYY2ILBOqc53bki7qis4rgN5PdX6Gzv613eE+/F/56vUW4TIHBFeCI8YrMeR+BmTia eVV6axVq+tVZebaEwsR+P9c/8wsZDWJdAHkfdjcYDuwMLolGhWJ+qdA6hwlDOTh1ggMA X6Rni475Jy1VRrruWpLanZw448orSr66XYWjj8H8P0a+TPMFFwSPWEB4B2/raw25FbSo jiSmPAzix/tdbnFUcejZChEBn9iUqmfQVnkAiq6Ub3iVJX/QuCYJZite+D6OZ7FPzqFR HcY0r/k96G8Dov7tPqRAAdAFNWw8WAs4T8ooNG+zKGJMOOggT5ZpMYxbNPA+Xs0rXJGF 7nJw== X-Gm-Message-State: AOAM531BVxGrsAQ+Gp+J3h/QOpei00ZLYhUa42JzjkmuXREqzpGeU0oT AFIKS41GNm2HGmlQfEfcV5yUpQ== X-Google-Smtp-Source: ABdhPJxix6RhZiSMjUriDnhnPBhNWFrKjpaNcNDniUGFS0Y1kLv6g64YZDzCEH7iDt0fEMuYMOEDAg== X-Received: by 2002:a5d:4f02:: with SMTP id c2mr7111384wru.311.1630829032148; Sun, 05 Sep 2021 01:03:52 -0700 (PDT) Received: from [192.168.8.105] (206.red-2-143-78.dynamicip.rima-tde.net. [2.143.78.206]) by smtp.gmail.com with ESMTPSA id m4sm3904664wmc.3.2021.09.05.01.03.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 05 Sep 2021 01:03:51 -0700 (PDT) Subject: Re: [PATCH v10 01/16] target/riscv: Introduce temporary in gen_add_uw() To: Philipp Tomsich , qemu-devel@nongnu.org References: <20210904203516.2570119-1-philipp.tomsich@vrull.eu> <20210904203516.2570119-2-philipp.tomsich@vrull.eu> From: Richard Henderson Message-ID: Date: Sun, 5 Sep 2021 10:03:44 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20210904203516.2570119-2-philipp.tomsich@vrull.eu> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2a00:1450:4864:20::431; envelope-from=richard.henderson@linaro.org; helo=mail-wr1-x431.google.com X-Spam_score_int: -54 X-Spam_score: -5.5 X-Spam_bar: ----- X-Spam_report: (-5.5 / 5.0 requ) BAYES_00=-1.9, DKIM_INVALID=0.1, DKIM_SIGNED=0.1, NICE_REPLY_A=-3.832, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kito Cheng , Alistair Francis Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 9/4/21 10:35 PM, Philipp Tomsich wrote: > Following the recent changes in translate.c, gen_add_uw() causes > failures on CF3 and SPEC2017 due to the reuse of arg1. Fix these > regressions by introducing a temporary. > > Signed-off-by: Philipp Tomsich > --- > > Changes in v10: > - new patch > > target/riscv/insn_trans/trans_rvb.c.inc | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) Fixes: 191d1dafae9c ("target/riscv: Add DisasExtend to gen_arith*") Reviewed-by: Richard Henderson r~