From: Stefan Berger <stefanb@linux.vnet.ibm.com>
To: "Eric Blake" <eblake@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@gmail.com>
Cc: kevin@koconnor.net, QEMU <qemu-devel@nongnu.org>,
"Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [Qemu-devel] [RFC PATCH 1/3] tpm: Implement virtual memory device for TPM PPI
Date: Fri, 12 Jan 2018 12:24:22 -0500 [thread overview]
Message-ID: <e8fcac38-dbca-eed3-61cf-f1e6ac9c30b9@linux.vnet.ibm.com> (raw)
In-Reply-To: <b1b83637-12cc-04d6-689f-c1d1759e810a@redhat.com>
On 01/12/2018 11:29 AM, Eric Blake wrote:
> On 01/12/2018 08:55 AM, Marc-André Lureau wrote:
>> Hi
>>
>> On Wed, Jan 10, 2018 at 7:35 PM, Stefan Berger
>> <stefanb@linux.vnet.ibm.com> wrote:
>>> Implement a virtual memory device for the TPM physical
>>> presence interface. The memory is located at 0xffff0000
>>> and used by ACPI to send messages to the firmware (BIOS).
>>>
>>> This device should be used by all TPM interfaces on x86 and
>>> can be added through by calling tpm_ppi_init_io().
>>>
>>> +#define DEBUG_PPI 1
>> to be switched to 0
>>
>>> +
>>> +#define DPRINTF(fmt, ...) do { \
>>> + if (DEBUG_PPI) { \
>>> + printf(fmt, ## __VA_ARGS__); \
>>> + } \
>>> +} while (0);
> Also, this falls foul of my pending patch to forbid trailing semicolons
> in do/while(0) macros:
> https://lists.gnu.org/archive/html/qemu-devel/2017-12/msg00246.html
>
> But even though it is not a trace point, at least you made sure -Wformat
> will avoid bit-rotting debug statements.
>
Fixing it.
next prev parent reply other threads:[~2018-01-12 17:25 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-10 18:35 [Qemu-devel] [RFC PATCH 0/3] Implement Pysical Presence Interface for TPM 1.2 and 2 Stefan Berger
2018-01-10 18:35 ` [Qemu-devel] [RFC PATCH 1/3] tpm: Implement virtual memory device for TPM PPI Stefan Berger
2018-01-12 14:55 ` Marc-André Lureau
2018-01-12 16:29 ` Eric Blake
2018-01-12 17:24 ` Stefan Berger [this message]
2018-01-12 18:23 ` Stefan Berger
2018-01-15 14:49 ` Stefan Berger
2018-01-10 18:35 ` [Qemu-devel] [RFC PATCH 2/3] acpi: implement aml_lless_equal Stefan Berger
2018-01-12 15:17 ` Marc-André Lureau
2018-01-12 19:42 ` Stefan Berger
2018-01-15 14:31 ` Igor Mammedov
2018-01-10 18:35 ` [Qemu-devel] [RFC PATCH 3/3] acpi: Build TPM Physical Presence interface Stefan Berger
2018-01-10 18:49 ` Stefan Berger
2018-01-12 16:07 ` Marc-André Lureau
2018-01-12 17:00 ` Stefan Berger
2018-01-12 20:16 ` Stefan Berger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e8fcac38-dbca-eed3-61cf-f1e6ac9c30b9@linux.vnet.ibm.com \
--to=stefanb@linux.vnet.ibm.com \
--cc=eblake@redhat.com \
--cc=kevin@koconnor.net \
--cc=marcandre.lureau@gmail.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.