From: Larry Finger <Larry.Finger@lwfinger.net>
To: Johan Hovold <johan@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
linux-staging@lists.linux.dev, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH 2/2] staging: r8712u: fix control-message timeout
Date: Mon, 25 Oct 2021 10:08:16 -0500 [thread overview]
Message-ID: <e9098c0e-e1fe-5d65-c111-1607d0a6a1a7@lwfinger.net> (raw)
In-Reply-To: <20211025120910.6339-3-johan@kernel.org>
On 10/25/21 07:09, Johan Hovold wrote:
> USB control-message timeouts are specified in milliseconds and should
> specifically not vary with CONFIG_HZ.
>
> Fixes: 2865d42c78a9 ("staging: r8712u: Add the new driver to the mainline kernel")
> Cc: stable@vger.kernel.org # 2.6.37
> Signed-off-by: Johan Hovold <johan@kernel.org>
> ---
> drivers/staging/rtl8712/usb_ops_linux.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Acked-by: Larry Finger <Larry.Finger@lwfinger.net>
>
> diff --git a/drivers/staging/rtl8712/usb_ops_linux.c b/drivers/staging/rtl8712/usb_ops_linux.c
> index 655497cead12..f984a5ab2c6f 100644
> --- a/drivers/staging/rtl8712/usb_ops_linux.c
> +++ b/drivers/staging/rtl8712/usb_ops_linux.c
> @@ -494,7 +494,7 @@ int r8712_usbctrl_vendorreq(struct intf_priv *pintfpriv, u8 request, u16 value,
> memcpy(pIo_buf, pdata, len);
> }
> status = usb_control_msg(udev, pipe, request, reqtype, value, index,
> - pIo_buf, len, HZ / 2);
> + pIo_buf, len, 500);
> if (status > 0) { /* Success this control transfer. */
> if (requesttype == 0x01) {
> /* For Control read transfer, we have to copy the read
>
prev parent reply other threads:[~2021-10-25 15:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-25 12:09 [PATCH 0/2] staging: fix control-message timeouts Johan Hovold
2021-10-25 12:09 ` [PATCH 1/2] staging: rtl8192u: " Johan Hovold
2021-10-25 15:06 ` Larry Finger
2021-10-25 15:41 ` Joe Perches
2021-10-25 15:41 ` [cocci] " Joe Perches
2021-10-25 15:51 ` Greg Kroah-Hartman
2021-10-25 15:51 ` [cocci] " Greg Kroah-Hartman
2021-10-25 16:20 ` Joe Perches
2021-10-25 16:20 ` [cocci] " Joe Perches
2021-10-25 12:09 ` [PATCH 2/2] staging: r8712u: fix control-message timeout Johan Hovold
2021-10-25 15:08 ` Larry Finger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e9098c0e-e1fe-5d65-c111-1607d0a6a1a7@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=florian.c.schilhabel@googlemail.com \
--cc=gregkh@linuxfoundation.org \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=linux-usb@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.