From: "Peter Kjellerstedt" <peter.kjellerstedt@axis.com>
To: Konrad Weihmann <kweihmann@outlook.com>,
"openembedded-core@lists.openembedded.org"
<openembedded-core@lists.openembedded.org>
Subject: Re: [OE-core] [PATCH v3] file: add PACKAGECONFIG for auto options
Date: Mon, 11 May 2020 08:12:25 +0000 [thread overview]
Message-ID: <e90a8171ae6541b595111605f5393f8e@XBOX03.axis.com> (raw)
In-Reply-To: <AM7PR05MB6881E5C621ACD529E1BB4F4CA8A00@AM7PR05MB6881.eurprd05.prod.outlook.com>
> -----Original Message-----
> From: openembedded-core@lists.openembedded.org <openembedded-
> core@lists.openembedded.org> On Behalf Of Konrad Weihmann
> Sent: den 10 maj 2020 22:30
> To: openembedded-core@lists.openembedded.org
> Cc: Konrad Weihmann <kweihmann@outlook.com>
> Subject: [OE-core] [PATCH v3] file: add PACKAGECONFIG for auto options
>
> A few options of file configure are set to auto, which can lead to
> unpredictable effects when something in the sysroot does provide
> things that satisfy the autotools checks.
> In the worst case this will lead to package-qa failures as libraries are
> not set in RDEPENDS but configured for the tool.
>
> To mitigate changes of accidental configure set explicit options via
> newly introduced PACKAGECONFIG variables for bzip, lzma and zlib
> support, where the default is just zlib, as it was before
>
> Signed-off-by: Konrad Weihmann <kweihmann@outlook.com>
> ---
> meta/recipes-devtools/file/file_5.38.bb | 10 ++++++++--
> 1 file changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/meta/recipes-devtools/file/file_5.38.bb b/meta/recipes-
> devtools/file/file_5.38.bb
> index b8f09107e8..f5ad568936 100644
> --- a/meta/recipes-devtools/file/file_5.38.bb
> +++ b/meta/recipes-devtools/file/file_5.38.bb
> @@ -8,8 +8,8 @@ SECTION = "console/utils"
> LICENSE = "BSD-2-Clause"
> LIC_FILES_CHKSUM =
> "file://COPYING;beginline=2;md5=0251eaec1188b20d9a72c502ecfdda1b"
>
> -DEPENDS = "zlib file-replacement-native"
> -DEPENDS_class-native = "zlib-native"
> +DEPENDS = "file-replacement-native"
> +DEPENDS_class-native = ""
>
> SRC_URI = "git://github.com/file/file.git"
>
> @@ -18,6 +18,12 @@ S = "${WORKDIR}/git"
>
> inherit autotools update-alternatives
>
> +PACKAGECONFIG ??= "zlib"
> +PACKAGECONFIG_class-native ??= "zlib"
Remove PACKAGECONFIG_class-native. It is not needed since it matches
PACKAGECONFIG.
> +PACKAGECONFIG[bz2] = "--enable-bzlib, --disable-bzlib, bzip2"
> +PACKAGECONFIG[lzma] = "--enable-xzlib, --disable-xzlib, xz"
> +PACKAGECONFIG[zlib] = "--enable-zlib, --disable-zlib, zlib"
> +
> EXTRA_OECONF += "--disable-libseccomp"
>
> ALTERNATIVE_${PN} = "file"
> --
> 2.20.1
//Peter
prev parent reply other threads:[~2020-05-11 8:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-10 20:29 [PATCH v3] file: add PACKAGECONFIG for auto options Konrad Weihmann
2020-05-11 8:12 ` Peter Kjellerstedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e90a8171ae6541b595111605f5393f8e@XBOX03.axis.com \
--to=peter.kjellerstedt@axis.com \
--cc=kweihmann@outlook.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.