All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sagi Grimberg <sagi@grimberg.me>
To: chengjike <chengjike.cheng@huawei.com>,
	kbusch@kernel.org, linux-nvme@lists.infradead.org,
	chaitanyak@nvidia.com
Cc: sunao.sun@huawei.com, jiangtao62@huawei.com
Subject: Re: [PATCH V3 nvme-cli 1/2] initialize disk "access" variable
Date: Tue, 28 Sep 2021 23:45:35 +0300	[thread overview]
Message-ID: <e916dbea-8796-5ed1-06f6-4d89c72f3b69@grimberg.me> (raw)
In-Reply-To: <20210928085050.4141-2-chengjike.cheng@huawei.com>


> (This is a prep patch, which provides functions for the next "patch 2/2")
> When it is failed to get nvme_id_ns data from NVMe Subsystem.

If there was a failure the nsid should be -1, and all the size info 
should be zero, that is enough of an indication that the ns is "faulty".

Also live/faulty is not a good terminology for path access.
Maybe full/partial or complete/incomplete.

I thought that this was about showing the completeness of the
path access for a given ns, regardless of failure of identify-ns...

Meaning that if I have a ns with 2 paths, where one is live and the
other is connecting/resetting then "Path Access" would be "incomplete"
or "partial".. Also in the case where all paths are live, but some
have ANA state "inaccessible" or "persistent loss" then "Path Access"
would be "partial" and only if all paths are "live" and ANA accessible
i.e. "optimized/non-optimized" it will show "full/complete" Path
Access...

Otherwise, I don't see the point in adding this information to
nvme list output.

_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme

  reply	other threads:[~2021-09-28 20:46 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-28  8:50 [PATCH V3 nvme-cli 0/2] add "Path Access" field in command "nvme list" chengjike
2021-09-28  8:50 ` [PATCH V3 nvme-cli 1/2] initialize disk "access" variable chengjike
2021-09-28 20:45   ` Sagi Grimberg [this message]
2021-09-28 21:18     ` Chaitanya Kulkarni
2021-10-08 12:23     ` Chengjike (ISSP)
2021-09-28  8:50 ` [PATCH V3 nvme-cli 2/2] add "Path Access" entry in command output chengjike

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e916dbea-8796-5ed1-06f6-4d89c72f3b69@grimberg.me \
    --to=sagi@grimberg.me \
    --cc=chaitanyak@nvidia.com \
    --cc=chengjike.cheng@huawei.com \
    --cc=jiangtao62@huawei.com \
    --cc=kbusch@kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=sunao.sun@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.