From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D30AEC433F5 for ; Mon, 10 Jan 2022 16:36:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237588AbiAJQgm (ORCPT ); Mon, 10 Jan 2022 11:36:42 -0500 Received: from foss.arm.com ([217.140.110.172]:36344 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237563AbiAJQgg (ORCPT ); Mon, 10 Jan 2022 11:36:36 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6FA512B; Mon, 10 Jan 2022 08:36:36 -0800 (PST) Received: from [10.57.11.80] (unknown [10.57.11.80]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 647943F5A1; Mon, 10 Jan 2022 08:36:35 -0800 (PST) Subject: Re: [PATCH] drm/panfrost: Update create_bo flags comment To: Alyssa Rosenzweig , dri-devel@lists.freedesktop.org Cc: Rob Herring , Tomeu Vizoso , David Airlie , Daniel Vetter , linux-kernel@vger.kernel.org References: <20220109163704.2564-1-alyssa.rosenzweig@collabora.com> From: Steven Price Message-ID: Date: Mon, 10 Jan 2022 16:36:33 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <20220109163704.2564-1-alyssa.rosenzweig@collabora.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/01/2022 16:37, Alyssa Rosenzweig wrote: > Update a comment stating create_bo took no flags, since it now takes a > bit mask of optional flags NOEXEC and HEAP. > > Signed-off-by: Alyssa Rosenzweig Reviewed-by: Steven Price I'll push this to drm-misc-next. Thanks, Steve > --- > include/uapi/drm/panfrost_drm.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/include/uapi/drm/panfrost_drm.h b/include/uapi/drm/panfrost_drm.h > index 061e700dd06c..9e40277d8185 100644 > --- a/include/uapi/drm/panfrost_drm.h > +++ b/include/uapi/drm/panfrost_drm.h > @@ -84,14 +84,14 @@ struct drm_panfrost_wait_bo { > __s64 timeout_ns; /* absolute */ > }; > > +/* Valid flags to pass to drm_panfrost_create_bo */ > #define PANFROST_BO_NOEXEC 1 > #define PANFROST_BO_HEAP 2 > > /** > * struct drm_panfrost_create_bo - ioctl argument for creating Panfrost BOs. > * > - * There are currently no values for the flags argument, but it may be > - * used in a future extension. > + * The flags argument is a bit mask of PANFROST_BO_* flags. > */ > struct drm_panfrost_create_bo { > __u32 size; > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8A70AC433F5 for ; Mon, 10 Jan 2022 16:36:38 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id CE89A10E908; Mon, 10 Jan 2022 16:36:37 +0000 (UTC) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by gabe.freedesktop.org (Postfix) with ESMTP id F2AC210E908 for ; Mon, 10 Jan 2022 16:36:36 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6FA512B; Mon, 10 Jan 2022 08:36:36 -0800 (PST) Received: from [10.57.11.80] (unknown [10.57.11.80]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 647943F5A1; Mon, 10 Jan 2022 08:36:35 -0800 (PST) Subject: Re: [PATCH] drm/panfrost: Update create_bo flags comment To: Alyssa Rosenzweig , dri-devel@lists.freedesktop.org References: <20220109163704.2564-1-alyssa.rosenzweig@collabora.com> From: Steven Price Message-ID: Date: Mon, 10 Jan 2022 16:36:33 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <20220109163704.2564-1-alyssa.rosenzweig@collabora.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , Tomeu Vizoso , linux-kernel@vger.kernel.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 09/01/2022 16:37, Alyssa Rosenzweig wrote: > Update a comment stating create_bo took no flags, since it now takes a > bit mask of optional flags NOEXEC and HEAP. > > Signed-off-by: Alyssa Rosenzweig Reviewed-by: Steven Price I'll push this to drm-misc-next. Thanks, Steve > --- > include/uapi/drm/panfrost_drm.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/include/uapi/drm/panfrost_drm.h b/include/uapi/drm/panfrost_drm.h > index 061e700dd06c..9e40277d8185 100644 > --- a/include/uapi/drm/panfrost_drm.h > +++ b/include/uapi/drm/panfrost_drm.h > @@ -84,14 +84,14 @@ struct drm_panfrost_wait_bo { > __s64 timeout_ns; /* absolute */ > }; > > +/* Valid flags to pass to drm_panfrost_create_bo */ > #define PANFROST_BO_NOEXEC 1 > #define PANFROST_BO_HEAP 2 > > /** > * struct drm_panfrost_create_bo - ioctl argument for creating Panfrost BOs. > * > - * There are currently no values for the flags argument, but it may be > - * used in a future extension. > + * The flags argument is a bit mask of PANFROST_BO_* flags. > */ > struct drm_panfrost_create_bo { > __u32 size; >