From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21028C433EF for ; Wed, 23 Feb 2022 09:02:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239177AbiBWJC2 (ORCPT ); Wed, 23 Feb 2022 04:02:28 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44486 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239193AbiBWJCY (ORCPT ); Wed, 23 Feb 2022 04:02:24 -0500 Received: from mail-wr1-x42d.google.com (mail-wr1-x42d.google.com [IPv6:2a00:1450:4864:20::42d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9B28243396 for ; Wed, 23 Feb 2022 01:01:51 -0800 (PST) Received: by mail-wr1-x42d.google.com with SMTP id s1so11990540wrg.10 for ; Wed, 23 Feb 2022 01:01:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind.com; s=google; h=message-id:date:mime-version:user-agent:reply-to:subject :content-language:to:cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=F3lw3AMJP9Ga81FBJryvKm8lxqU7b7R5OHLuGuLasjI=; b=C6DdE4N85D6pQFVHzn6jZFm/iv9eb8AsBCwZAW1eM85pLLDNB9yT311R4gWnv7CP8h Jz7EhgmZttIEccO9PNFEoTk/V3OZ8n9rYlrKtBQB7D4ShRsr57vYQciIKpvuwLM+Zddt UySsAWV7ta2uboNdN23fJp3aqNtO42BxdrwR30L0v00Oxv4Ef2a/PMMSXW9hzXIdwj3Q MJgGn2LsZVxxNcv/jUZivDKm1jgFH2Ix7obyjW71amWhoPFGay2s4Uonk9ur7PHqdMZC AMhwGscsGlsyIANAU2JuPU7jlXNjo4vKxuwDS3yeII1Gi0rRX8uoh8U7e0FWroCtx592 VPqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:reply-to :subject:content-language:to:cc:references:from:organization :in-reply-to:content-transfer-encoding; bh=F3lw3AMJP9Ga81FBJryvKm8lxqU7b7R5OHLuGuLasjI=; b=6FOXwTrUbkuGD+dOUQf6gjB5pj3w1Svqxu/YrrP5jf34Jbaj/1L8u+1r/nxtKHBfJ+ VvTgAagck7Eu1X6T2Hh9sMr4MnCVz88vu65/WYkLVnukx0N7NV9NCpt9IPQiLYgsFxF0 8/deTn7tTatrgsmgzo9ctRHrUnw+qIiMa92bfNGfBos2DJiDrHTkIZODHhL1ca1WhQI9 UAtuazeKzDeL4qJECOO5es2YM9vsXxqCbow9sDmh088SUo1nazsMtn8AOM3gZPzCgKxu YHU0F1wPkyMJ+PLLc4VpmthRKOSAnXT1rGqUTjYrc2hEgwesZdIwMV87eOB7AlBLNOyf HJSw== X-Gm-Message-State: AOAM5310xNIvhEbEUoykfg50/PW9qYS48b7qZBD+kvveR3I42rGulBmw fKFs9JYGMj/8gCioE6AJEPA+aw== X-Google-Smtp-Source: ABdhPJxYELuoQHan0HeRhlLsZKKFSMQGcVcyH9JgxnQ1M5L8G2CGHFGeTZBRhF60E1d9IGIp0TZ7UQ== X-Received: by 2002:a05:6000:1881:b0:1e8:f75c:591d with SMTP id a1-20020a056000188100b001e8f75c591dmr20669003wri.257.1645606910257; Wed, 23 Feb 2022 01:01:50 -0800 (PST) Received: from ?IPV6:2a01:e0a:b41:c160:5d35:a5e8:9cb4:e326? ([2a01:e0a:b41:c160:5d35:a5e8:9cb4:e326]) by smtp.gmail.com with ESMTPSA id b2sm37255686wri.35.2022.02.23.01.01.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 23 Feb 2022 01:01:49 -0800 (PST) Message-ID: Date: Wed, 23 Feb 2022 10:01:48 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Reply-To: nicolas.dichtel@6wind.com Subject: Re: [PATCH libnetfilter_queue] libnetfilter_queue: add support of skb->priority Content-Language: en-US To: Pablo Neira Ayuso , Florian Westphal Cc: netfilter-devel@vger.kernel.org, netdev@vger.kernel.org References: <20220204102637.4272-1-nicolas.dichtel@6wind.com> <8c08a4e0-83a0-9fc1-798b-dbd6a53f7231@6wind.com> <20220204120126.GB15954@breakpoint.cc> From: Nicolas Dichtel Organization: 6WIND In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Le 04/02/2022 à 15:20, Pablo Neira Ayuso a écrit : > On Fri, Feb 04, 2022 at 01:01:26PM +0100, Florian Westphal wrote: >> Nicolas Dichtel wrote: >>> >>> Le 04/02/2022 à 11:26, Nicolas Dichtel a écrit : >>>> Available since linux v5.18. >>>> >>>> Link: https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id= >>>> Signed-off-by: Nicolas Dichtel >>>> --- >>> >>> Should I send another patch for the 'set' part? >>> In this case, a nfq_set_verdict3(). The name is a bit ugly ;-) >>> Any suggestions? >> >> I think we should just let the old api die and tell users >> to use the mnl interface, that allows to add the new attribute >> as soon as its available. > > We have to provide a simple API based on mnl which ressembles the > existing old API. > > Feedback in these years is that there are a users that do not need to > know about netlink details / advanced handling. If I understand well, libnetfilter_queue is deprecated? If this is right, maybe it could be advertised on the project page: https://netfilter.org/projects/libnetfilter_queue/index.html Regards, Nicolas