From: Jens Axboe <axboe@kernel.dk>
To: Hao Xu <haoxu@linux.alibaba.com>, io-uring@vger.kernel.org
Cc: stable@vger.kernel.org
Subject: Re: [PATCH 1/2] io_uring: check tctx->in_idle when decrementing inflight_tracked
Date: Fri, 10 Dec 2021 06:47:02 -0700 [thread overview]
Message-ID: <e93fe3ce-e690-3118-62a3-aeec3bfaadee@kernel.dk> (raw)
In-Reply-To: <2c527587-36c4-900b-bda6-1357d9bb5ba0@linux.alibaba.com>
On 12/10/21 12:21 AM, Hao Xu wrote:
>
> 在 2021/12/9 下午11:59, Jens Axboe 写道:
>> If we have someone potentially waiting for tracked requests to finish,
>> ensure that we check in_idle and wake them up appropriately.
>>
>> Cc: stable@vger.kernel.org
>> Signed-off-by: Jens Axboe <axboe@kernel.dk>
>> ---
>
> Hi Jens,
>
> I saw every/several( in batching cases) io_clean_op() followed by an
> io_put_task() which does the same thing
>
> as this patch, so it seems this one is not neccessary? Correct me if I'm
> wrong since I haven't touch this code for
Hard to deduce as it also depends on whether it's the task itself or not.
Making it explicit is better imho.
--
Jens Axboe
next prev parent reply other threads:[~2021-12-10 13:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-09 15:59 [PATCHSET 0/2] Cancelation fixes Jens Axboe
2021-12-09 15:59 ` [PATCH 1/2] io_uring: check tctx->in_idle when decrementing inflight_tracked Jens Axboe
2021-12-10 7:21 ` Hao Xu
2021-12-10 13:47 ` Jens Axboe [this message]
2021-12-09 15:59 ` [PATCH 2/2] io_uring: ensure task_work gets run as part of cancelations Jens Axboe
2021-12-09 16:16 ` [PATCH v2 " Jens Axboe
2021-12-10 3:29 ` Hao Xu
2021-12-10 4:22 ` Jens Axboe
2021-12-10 7:31 ` Hao Xu
2021-12-10 13:45 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e93fe3ce-e690-3118-62a3-aeec3bfaadee@kernel.dk \
--to=axboe@kernel.dk \
--cc=haoxu@linux.alibaba.com \
--cc=io-uring@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.