From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756915AbdDRCxq (ORCPT ); Mon, 17 Apr 2017 22:53:46 -0400 Received: from mail.netline.ch ([148.251.143.178]:48011 "EHLO netline-mail3.netline.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755669AbdDRCxn (ORCPT ); Mon, 17 Apr 2017 22:53:43 -0400 Subject: Re: [RfC PATCH] drm: fourcc byteorder: brings header file comments in line with reality. To: Ilia Mirkin , Pekka Paalanen Cc: Daniel Vetter , amd-gfx@lists.freedesktop.org, Gerd Hoffmann , "dri-devel@lists.freedesktop.org" , open list References: <20170410101202.19229-1-kraxel@redhat.com> <20170410161214.305f5daf@eldfell> <1491833847.30990.77.camel@redhat.com> <20170410180941.43922e25@eldfell> <20170411103101.0497fe08@eldfell> From: =?UTF-8?Q?Michel_D=c3=a4nzer?= Message-ID: Date: Tue, 18 Apr 2017 11:53:33 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 17/04/17 03:43 PM, Ilia Mirkin wrote: > On Tue, Apr 11, 2017 at 10:18 AM, Ilia Mirkin wrote: >>> However, I totally agree with Alex that someone with a BE machine >>> should review the whole stack before we could be confident with anything. >> >> Here's what I'm confident about: xf86-video-nouveau worked just fine >> on top of kernel 4.3 on an AGP GeForce FX 5200 (with AGPGART turned >> off because ... well ... uninorth). fbcon/fbdev accel worked, >> xf86-video-nouveau's 2d accel worked, and simple demos (ala glxgears) >> worked after I fixed up mesa and nv30 driver items in version ... 11.1 >> it seems. As I recall it had gotten all broken in 10.0 or so by Adam >> Jackson in the name of making llvmpipe work on BE, declaring all other >> drivers broken, with various fixes by Michel Dänzer to get it back to >> working over the years. >> >> Anyone "fixing" the stack has to maintain that level of functioning >> through their various fixing. >> >> I will double-check that the above still works with the latest >> kernel/xorg/xf86-video-nouveau/mesa and report back (hopefully by this >> weekend). If there are any patches you'd like me to test, now's the >> time to ask -- getting the box up and running is the hard part, >> booting up an extra kernel -- easy. > > OK, so I revived my PowerMac7,3 G5 setup (PPC64 BE, NV34 GPU). Booted > it with an upstream 4.11-rc7 kernel, loaded up the nouveau kernel > module (which is included in that kernel), updated X to 1.19.2 and > mesa to 17.0.3. Everything works fine. Specifically: > > fbcon on top of fbdev provided by nouveau -- colors are fine > glxgears hw-accelerated by mesa on top of xf86-video-nouveau using > DRI2 -- colors are fine > glxgears softpipe-accelerated by mesa on top of xf86-video-nouveau -- > colors are fine > glxgears softpipe-accelerated by mesa on top of xf86-video-modesetting > -- colors are fine > xterm on top of xf86-video-nouveau -- colors are fine > xterm on top of xf86-video-modesetting -- colors are fine > > I couldn't test anything with GLAMOR since GLAMOR requires GL 2.1 or > higher, whereas nouveau's NV3x acceleration only provides GL 1.5 (due > to lacking NPOT and a handful of other things). > > The modetest utility did have trouble with AR24 and I'm pretty sure > the XR24 pattern was off too. However I wouldn't be surprised if the > modetest utility itself had endian issues in the pattern generation > logic. (Seems to be the case, based on a quick glance at the > tests/util/format.c logic and how it's used in pattern.c.) > > So in short, I think the current definitions of format are fine. I agree with Pekka that it's not that simple. What you've established is that things look fine after going through several layers of abstraction. It's possible that multiple bugs in those layers cancel each other out; in particular, it's quite likely that the code dealing with DRM formats is treating them as using native endianness (one possible giveaway for that is using shifts for (un)packing colour components). -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X developer From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?Michel_D=c3=a4nzer?= Subject: Re: [RfC PATCH] drm: fourcc byteorder: brings header file comments in line with reality. Date: Tue, 18 Apr 2017 11:53:33 +0900 Message-ID: References: <20170410101202.19229-1-kraxel@redhat.com> <20170410161214.305f5daf@eldfell> <1491833847.30990.77.camel@redhat.com> <20170410180941.43922e25@eldfell> <20170411103101.0497fe08@eldfell> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Ilia Mirkin , Pekka Paalanen Cc: Daniel Vetter , "dri-devel@lists.freedesktop.org" , Gerd Hoffmann , amd-gfx@lists.freedesktop.org, open list List-Id: dri-devel@lists.freedesktop.org T24gMTcvMDQvMTcgMDM6NDMgUE0sIElsaWEgTWlya2luIHdyb3RlOgo+IE9uIFR1ZSwgQXByIDEx LCAyMDE3IGF0IDEwOjE4IEFNLCBJbGlhIE1pcmtpbiA8aW1pcmtpbkBhbHVtLm1pdC5lZHU+IHdy b3RlOgo+Pj4gSG93ZXZlciwgSSB0b3RhbGx5IGFncmVlIHdpdGggQWxleCB0aGF0IHNvbWVvbmUg d2l0aCBhIEJFIG1hY2hpbmUKPj4+IHNob3VsZCByZXZpZXcgdGhlIHdob2xlIHN0YWNrIGJlZm9y ZSB3ZSBjb3VsZCBiZSBjb25maWRlbnQgd2l0aCBhbnl0aGluZy4KPj4KPj4gSGVyZSdzIHdoYXQg SSdtIGNvbmZpZGVudCBhYm91dDogeGY4Ni12aWRlby1ub3V2ZWF1IHdvcmtlZCBqdXN0IGZpbmUK Pj4gb24gdG9wIG9mIGtlcm5lbCA0LjMgb24gYW4gQUdQIEdlRm9yY2UgRlggNTIwMCAod2l0aCBB R1BHQVJUIHR1cm5lZAo+PiBvZmYgYmVjYXVzZSAuLi4gd2VsbCAuLi4gdW5pbm9ydGgpLiBmYmNv bi9mYmRldiBhY2NlbCB3b3JrZWQsCj4+IHhmODYtdmlkZW8tbm91dmVhdSdzIDJkIGFjY2VsIHdv cmtlZCwgYW5kIHNpbXBsZSBkZW1vcyAoYWxhIGdseGdlYXJzKQo+PiB3b3JrZWQgYWZ0ZXIgSSBm aXhlZCB1cCBtZXNhIGFuZCBudjMwIGRyaXZlciBpdGVtcyBpbiB2ZXJzaW9uIC4uLiAxMS4xCj4+ IGl0IHNlZW1zLiBBcyBJIHJlY2FsbCBpdCBoYWQgZ290dGVuIGFsbCBicm9rZW4gaW4gMTAuMCBv ciBzbyBieSBBZGFtCj4+IEphY2tzb24gaW4gdGhlIG5hbWUgb2YgbWFraW5nIGxsdm1waXBlIHdv cmsgb24gQkUsIGRlY2xhcmluZyBhbGwgb3RoZXIKPj4gZHJpdmVycyBicm9rZW4sIHdpdGggdmFy aW91cyBmaXhlcyBieSBNaWNoZWwgRMOkbnplciB0byBnZXQgaXQgYmFjayB0bwo+PiB3b3JraW5n IG92ZXIgdGhlIHllYXJzLgo+Pgo+PiBBbnlvbmUgImZpeGluZyIgdGhlIHN0YWNrIGhhcyB0byBt YWludGFpbiB0aGF0IGxldmVsIG9mIGZ1bmN0aW9uaW5nCj4+IHRocm91Z2ggdGhlaXIgdmFyaW91 cyBmaXhpbmcuCj4+Cj4+IEkgd2lsbCBkb3VibGUtY2hlY2sgdGhhdCB0aGUgYWJvdmUgc3RpbGwg d29ya3Mgd2l0aCB0aGUgbGF0ZXN0Cj4+IGtlcm5lbC94b3JnL3hmODYtdmlkZW8tbm91dmVhdS9t ZXNhIGFuZCByZXBvcnQgYmFjayAoaG9wZWZ1bGx5IGJ5IHRoaXMKPj4gd2Vla2VuZCkuIElmIHRo ZXJlIGFyZSBhbnkgcGF0Y2hlcyB5b3UnZCBsaWtlIG1lIHRvIHRlc3QsIG5vdydzIHRoZQo+PiB0 aW1lIHRvIGFzayAtLSBnZXR0aW5nIHRoZSBib3ggdXAgYW5kIHJ1bm5pbmcgaXMgdGhlIGhhcmQg cGFydCwKPj4gYm9vdGluZyB1cCBhbiBleHRyYSBrZXJuZWwgLS0gZWFzeS4KPiAKPiBPSywgc28g SSByZXZpdmVkIG15IFBvd2VyTWFjNywzIEc1IHNldHVwIChQUEM2NCBCRSwgTlYzNCBHUFUpLiBC b290ZWQKPiBpdCB3aXRoIGFuIHVwc3RyZWFtIDQuMTEtcmM3IGtlcm5lbCwgbG9hZGVkIHVwIHRo ZSBub3V2ZWF1IGtlcm5lbAo+IG1vZHVsZSAod2hpY2ggaXMgaW5jbHVkZWQgaW4gdGhhdCBrZXJu ZWwpLCB1cGRhdGVkIFggdG8gMS4xOS4yIGFuZAo+IG1lc2EgdG8gMTcuMC4zLiBFdmVyeXRoaW5n IHdvcmtzIGZpbmUuIFNwZWNpZmljYWxseToKPiAKPiBmYmNvbiBvbiB0b3Agb2YgZmJkZXYgcHJv dmlkZWQgYnkgbm91dmVhdSAtLSBjb2xvcnMgYXJlIGZpbmUKPiBnbHhnZWFycyBody1hY2NlbGVy YXRlZCBieSBtZXNhIG9uIHRvcCBvZiB4Zjg2LXZpZGVvLW5vdXZlYXUgdXNpbmcKPiBEUkkyIC0t IGNvbG9ycyBhcmUgZmluZQo+IGdseGdlYXJzIHNvZnRwaXBlLWFjY2VsZXJhdGVkIGJ5IG1lc2Eg b24gdG9wIG9mIHhmODYtdmlkZW8tbm91dmVhdSAtLQo+IGNvbG9ycyBhcmUgZmluZQo+IGdseGdl YXJzIHNvZnRwaXBlLWFjY2VsZXJhdGVkIGJ5IG1lc2Egb24gdG9wIG9mIHhmODYtdmlkZW8tbW9k ZXNldHRpbmcKPiAtLSBjb2xvcnMgYXJlIGZpbmUKPiB4dGVybSBvbiB0b3Agb2YgeGY4Ni12aWRl by1ub3V2ZWF1IC0tIGNvbG9ycyBhcmUgZmluZQo+IHh0ZXJtIG9uIHRvcCBvZiB4Zjg2LXZpZGVv LW1vZGVzZXR0aW5nIC0tIGNvbG9ycyBhcmUgZmluZQo+IAo+IEkgY291bGRuJ3QgdGVzdCBhbnl0 aGluZyB3aXRoIEdMQU1PUiBzaW5jZSBHTEFNT1IgcmVxdWlyZXMgR0wgMi4xIG9yCj4gaGlnaGVy LCB3aGVyZWFzIG5vdXZlYXUncyBOVjN4IGFjY2VsZXJhdGlvbiBvbmx5IHByb3ZpZGVzIEdMIDEu NSAoZHVlCj4gdG8gbGFja2luZyBOUE9UIGFuZCBhIGhhbmRmdWwgb2Ygb3RoZXIgdGhpbmdzKS4K PiAKPiBUaGUgbW9kZXRlc3QgdXRpbGl0eSBkaWQgaGF2ZSB0cm91YmxlIHdpdGggQVIyNCBhbmQg SSdtIHByZXR0eSBzdXJlCj4gdGhlIFhSMjQgcGF0dGVybiB3YXMgb2ZmIHRvby4gSG93ZXZlciBJ IHdvdWxkbid0IGJlIHN1cnByaXNlZCBpZiB0aGUKPiBtb2RldGVzdCB1dGlsaXR5IGl0c2VsZiBo YWQgZW5kaWFuIGlzc3VlcyBpbiB0aGUgcGF0dGVybiBnZW5lcmF0aW9uCj4gbG9naWMuIChTZWVt cyB0byBiZSB0aGUgY2FzZSwgYmFzZWQgb24gYSBxdWljayBnbGFuY2UgYXQgdGhlCj4gdGVzdHMv dXRpbC9mb3JtYXQuYyBsb2dpYyBhbmQgaG93IGl0J3MgdXNlZCBpbiBwYXR0ZXJuLmMuKQo+IAo+ IFNvIGluIHNob3J0LCBJIHRoaW5rIHRoZSBjdXJyZW50IGRlZmluaXRpb25zIG9mIGZvcm1hdCBh cmUgZmluZS4KCkkgYWdyZWUgd2l0aCBQZWtrYSB0aGF0IGl0J3Mgbm90IHRoYXQgc2ltcGxlLiBX aGF0IHlvdSd2ZSBlc3RhYmxpc2hlZCBpcwp0aGF0IHRoaW5ncyBsb29rIGZpbmUgYWZ0ZXIgZ29p bmcgdGhyb3VnaCBzZXZlcmFsIGxheWVycyBvZiBhYnN0cmFjdGlvbi4KSXQncyBwb3NzaWJsZSB0 aGF0IG11bHRpcGxlIGJ1Z3MgaW4gdGhvc2UgbGF5ZXJzIGNhbmNlbCBlYWNoIG90aGVyIG91dDsK aW4gcGFydGljdWxhciwgaXQncyBxdWl0ZSBsaWtlbHkgdGhhdCB0aGUgY29kZSBkZWFsaW5nIHdp dGggRFJNIGZvcm1hdHMKaXMgdHJlYXRpbmcgdGhlbSBhcyB1c2luZyBuYXRpdmUgZW5kaWFubmVz cyAob25lIHBvc3NpYmxlIGdpdmVhd2F5IGZvcgp0aGF0IGlzIHVzaW5nIHNoaWZ0cyBmb3IgKHVu KXBhY2tpbmcgY29sb3VyIGNvbXBvbmVudHMpLgoKCi0tIApFYXJ0aGxpbmcgTWljaGVsIETDpG56 ZXIgICAgICAgICAgICAgICB8ICAgICAgICAgICAgICAgaHR0cDovL3d3dy5hbWQuY29tCkxpYnJl IHNvZnR3YXJlIGVudGh1c2lhc3QgICAgICAgICAgICAgfCAgICAgICAgICAgICBNZXNhIGFuZCBY IGRldmVsb3BlcgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f XwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcK aHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK