From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5EEF4C433E1 for ; Thu, 13 Aug 2020 11:50:40 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2B18B206A4 for ; Thu, 13 Aug 2020 11:50:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=citrix.com header.i=@citrix.com header.b="d7BQ4mib" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2B18B206A4 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=citrix.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k6BkD-0001Lp-AL; Thu, 13 Aug 2020 11:50:05 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k6BkC-00017q-8W for xen-devel@lists.xenproject.org; Thu, 13 Aug 2020 11:50:04 +0000 X-Inumbo-ID: eacb256c-5773-4b54-bf3e-f22d946918a5 Received: from esa1.hc3370-68.iphmx.com (unknown [216.71.145.142]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id eacb256c-5773-4b54-bf3e-f22d946918a5; Thu, 13 Aug 2020 11:50:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1597319403; h=subject:from:to:cc:references:message-id:date: mime-version:in-reply-to:content-transfer-encoding; bh=3h/6h+TTqGKylhQfVOCm+hm0y70vfCrsuo7GmI/Wim4=; b=d7BQ4mibi6KE8L2PRaYWY9Eq9KpwKQ3/E4wjUIxzW+XDI/7/VzpjZGUW GfBwb+yv8s6neDUa85KF0/VD9mG1uyX9upjciCl005Mi8lyQfDxBScPpG 63JsSD6NDHdE6jvQ6uoiTjjsmyxaQSiJlVY3DQ/oOLFCBWi9f8QFe6E/3 8=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: DUNXeUGO06MIRp2Tw/BGWknJp44X6Gsva2WE3NqbY+5yaCheiXiFG7qdvqpPDAiITFLG6U4Ul6 9K3Ka7HeY129/GjHneAaUDIxiiTk5KOU2saNuT+1UcFUC76kExLEoyuL96WUPrqUkVLlah2VqR MHskUxdq/7UdbwNVkjdb7pdWtXZXFhCvYbCiPIgfEax+ADjBAbdQ1dgEo1oSPDrzZGc+tt1YJP KWRH5XYC4OYba/I5Ka8T8cnpYO6aSMcSt3lpbt9TkuUc2cL78unhS/DzwlV2VYCzx6eh1MwWMo dyc= X-SBRS: 2.7 X-MesageID: 24780374 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.76,308,1592884800"; d="scan'208";a="24780374" Subject: Re: [PATCH] arch/x86/setup.c: Ignore early boot parameters like no-real-mode From: Andrew Cooper To: Trammell Hudson CC: Xen-devel References: Message-ID: Date: Thu, 13 Aug 2020 12:49:57 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Content-Language: en-GB X-ClientProxiedBy: AMSPEX02CAS01.citrite.net (10.69.22.112) To AMSPEX02CL02.citrite.net (10.69.22.126) X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 13/08/2020 00:35, Andrew Cooper wrote: > On 12/08/2020 20:06, Trammell Hudson wrote: >> On Wednesday, August 12, 2020 8:16 PM, Andrew Cooper wrote: >>> If you want, I can sort that out as a prereq patch, and rebase this one >>> on top? >> That sounds fine to me. They really are two separate patches. > I think we're fine caveat wise.  I'll try and find some time tomorrow. So the __UNIQUE_ID() plan doesn't work, as a consequence of the logic inside ignore_param() to shuffle the string name into initdata. As everything is in .initdata, it doesn't actually interact with LIVEPATCH. I've committed this patch with an extra note to try and prevent TEMP_NAME() being used in wider contexts. ~Andrew