All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Henderson <richard.henderson@linaro.org>
To: Janosch Frank <frankja@linux.ibm.com>, qemu-devel@nongnu.org
Cc: marcandre.lureau@redhat.com, pbonzini@redhat.com
Subject: Re: [PATCH v2 4/9] dump: Remove the section if when calculating the memory offset
Date: Fri, 11 Mar 2022 11:42:20 -0800	[thread overview]
Message-ID: <e9588005-002e-2feb-ed29-3babd6b00fee@linaro.org> (raw)
In-Reply-To: <20220310110854.2701-5-frankja@linux.ibm.com>

On 3/10/22 03:08, Janosch Frank wrote:
> When s->shdr_num is 0 we'll add 0 bytes of section headers which is
> equivalent to not adding section headers but with the multiplication
> we can remove a if/else.
> 
> Signed-off-by: Janosch Frank<frankja@linux.ibm.com>
> ---
>   dump/dump.c | 24 ++++++++----------------
>   1 file changed, 8 insertions(+), 16 deletions(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~


  reply	other threads:[~2022-03-11 19:45 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-10 11:08 [PATCH v2 0/9] dump: Cleanup and consolidation Janosch Frank
2022-03-10 11:08 ` [PATCH v2 1/9] dump: Use ERRP_GUARD() Janosch Frank
2022-03-11 18:45   ` Richard Henderson
2022-03-10 11:08 ` [PATCH v2 2/9] dump: Remove the sh_info variable Janosch Frank
2022-03-11 19:40   ` Richard Henderson
2022-03-10 11:08 ` [PATCH v2 3/9] dump: Introduce shdr_num to decrease complexity Janosch Frank
2022-03-11 19:41   ` Richard Henderson
2022-03-10 11:08 ` [PATCH v2 4/9] dump: Remove the section if when calculating the memory offset Janosch Frank
2022-03-11 19:42   ` Richard Henderson [this message]
2022-03-10 11:08 ` [PATCH v2 5/9] dump: Add more offset variables Janosch Frank
2022-03-11 19:44   ` Richard Henderson
2022-03-10 11:08 ` [PATCH v2 6/9] dump: Introduce dump_is_64bit() helper function Janosch Frank
2022-03-11 19:47   ` Richard Henderson
2022-03-10 11:08 ` [PATCH v2 7/9] dump: Consolidate phdr note writes Janosch Frank
2022-03-11 19:49   ` Richard Henderson
2022-03-10 11:08 ` [PATCH v2 8/9] dump: Cleanup dump_begin write functions Janosch Frank
2022-03-11 19:51   ` Richard Henderson
2022-03-10 11:08 ` [PATCH v2 9/9] dump: Consolidate elf note function Janosch Frank
2022-03-11 19:54   ` Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e9588005-002e-2feb-ed29-3babd6b00fee@linaro.org \
    --to=richard.henderson@linaro.org \
    --cc=frankja@linux.ibm.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.