All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hans Verkuil <hverkuil@xs4all.nl>
To: jacopo mondi <jacopo@jmondi.org>
Cc: Jacopo Mondi <jacopo+renesas@jmondi.org>,
	laurent.pinchart@ideasonboard.com, magnus.damm@gmail.com,
	geert@glider.be, mchehab@kernel.org, festevam@gmail.com,
	sakari.ailus@iki.fi, robh+dt@kernel.org, mark.rutland@arm.com,
	pombredanne@nexb.com, linux-renesas-soc@vger.kernel.org,
	linux-media@vger.kernel.org, linux-sh@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 3/9] v4l: platform: Add Renesas CEU driver
Date: Sun, 21 Jan 2018 10:23:12 +0000	[thread overview]
Message-ID: <e9623e9c-6444-2531-62c0-feed622c6e3b@xs4all.nl> (raw)
In-Reply-To: <55c3ab66-0886-4b2b-6842-ac07fc9138f3@xs4all.nl>

On 21/01/18 11:21, Hans Verkuil wrote:
> On 21/01/18 10:53, jacopo mondi wrote:
>> Hi Hans,
>>
>> On Fri, Jan 19, 2018 at 12:20:19PM +0100, Hans Verkuil wrote:
>>> static int ov7670_g_parm(struct v4l2_subdev *sd, struct v4l2_streamparm *parms)
>>> {
>>>         struct v4l2_captureparm *cp = &parms->parm.capture;
>>>         struct ov7670_info *info = to_state(sd);
>>>
>>>         if (parms->type != V4L2_BUF_TYPE_VIDEO_CAPTURE)
>>>                 return -EINVAL;
>>>
>>> And parms->type is CAPTURE_MPLANE. Just drop this test from the ov7670 driver
>>> in the g/s_parm functions. It shouldn't test for that since a subdev driver
>>> knows nothing about buffer types.
>>>
>>
>> I will drop that test in an additional patch part of next iteration of this series,
> 
> Replace g/s_parm by g/s_frame_interval. Consider g/s_parm for subdev drivers as
> deprecated (I'm working on a patch series to replace all g/s_parm uses by
> g/s_frame_interval).

Take a look here:

https://git.linuxtv.org/hverkuil/media_tree.git/log/?h=parm

You probably want to use the patch 'v4l2-common: add g/s_parm helper functions'
for the new ceu driver in your patch series. Feel free to add it.

Regards,

	Hans

WARNING: multiple messages have this Message-ID (diff)
From: Hans Verkuil <hverkuil@xs4all.nl>
To: jacopo mondi <jacopo@jmondi.org>
Cc: Jacopo Mondi <jacopo+renesas@jmondi.org>,
	laurent.pinchart@ideasonboard.com, magnus.damm@gmail.com,
	geert@glider.be, mchehab@kernel.org, festevam@gmail.com,
	sakari.ailus@iki.fi, robh+dt@kernel.org, mark.rutland@arm.com,
	pombredanne@nexb.com, linux-renesas-soc@vger.kernel.org,
	linux-media@vger.kernel.org, linux-sh@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 3/9] v4l: platform: Add Renesas CEU driver
Date: Sun, 21 Jan 2018 11:23:12 +0100	[thread overview]
Message-ID: <e9623e9c-6444-2531-62c0-feed622c6e3b@xs4all.nl> (raw)
In-Reply-To: <55c3ab66-0886-4b2b-6842-ac07fc9138f3@xs4all.nl>

On 21/01/18 11:21, Hans Verkuil wrote:
> On 21/01/18 10:53, jacopo mondi wrote:
>> Hi Hans,
>>
>> On Fri, Jan 19, 2018 at 12:20:19PM +0100, Hans Verkuil wrote:
>>> static int ov7670_g_parm(struct v4l2_subdev *sd, struct v4l2_streamparm *parms)
>>> {
>>>         struct v4l2_captureparm *cp = &parms->parm.capture;
>>>         struct ov7670_info *info = to_state(sd);
>>>
>>>         if (parms->type != V4L2_BUF_TYPE_VIDEO_CAPTURE)
>>>                 return -EINVAL;
>>>
>>> And parms->type is CAPTURE_MPLANE. Just drop this test from the ov7670 driver
>>> in the g/s_parm functions. It shouldn't test for that since a subdev driver
>>> knows nothing about buffer types.
>>>
>>
>> I will drop that test in an additional patch part of next iteration of this series,
> 
> Replace g/s_parm by g/s_frame_interval. Consider g/s_parm for subdev drivers as
> deprecated (I'm working on a patch series to replace all g/s_parm uses by
> g/s_frame_interval).

Take a look here:

https://git.linuxtv.org/hverkuil/media_tree.git/log/?h=parm

You probably want to use the patch 'v4l2-common: add g/s_parm helper functions'
for the new ceu driver in your patch series. Feel free to add it.

Regards,

	Hans

  reply	other threads:[~2018-01-21 10:23 UTC|newest]

Thread overview: 84+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-16 21:44 [PATCH v6 0/9] Renesas Capture Engine Unit (CEU) V4L2 driver Jacopo Mondi
2018-01-16 21:44 ` Jacopo Mondi
2018-01-16 21:44 ` Jacopo Mondi
2018-01-16 21:44 ` [PATCH v6 1/9] dt-bindings: media: Add Renesas CEU bindings Jacopo Mondi
2018-01-16 21:44   ` Jacopo Mondi
2018-01-17  7:59   ` Sakari Ailus
2018-01-17  7:59     ` Sakari Ailus
2018-01-17  8:35     ` jacopo mondi
2018-01-17  8:35       ` jacopo mondi
2018-01-17  8:55       ` Sakari Ailus
2018-01-17  8:55         ` Sakari Ailus
2018-01-16 21:44 ` [PATCH v6 2/9] include: media: Add Renesas CEU driver interface Jacopo Mondi
2018-01-16 21:44   ` Jacopo Mondi
2018-01-16 21:44 ` [PATCH v6 3/9] v4l: platform: Add Renesas CEU driver Jacopo Mondi
2018-01-16 21:44   ` Jacopo Mondi
2018-01-19 11:20   ` Hans Verkuil
2018-01-19 11:20     ` Hans Verkuil
2018-01-19 12:20     ` Laurent Pinchart
2018-01-19 12:20       ` Laurent Pinchart
2018-01-19 12:25       ` Hans Verkuil
2018-01-19 12:25         ` Hans Verkuil
     [not found]         ` <4195ec6a-b99d-2fad-3898-9ce9c02fce00-qWit8jRvyhVmR6Xm/wNWPw@public.gmane.org>
2018-01-22  0:52           ` Laurent Pinchart
2018-01-22  0:52             ` Laurent Pinchart
2018-01-22  0:52             ` Laurent Pinchart
2018-01-22  9:07             ` Hans Verkuil
2018-01-22  9:07               ` Hans Verkuil
2018-01-21  9:53     ` jacopo mondi
2018-01-21  9:53       ` jacopo mondi
2018-01-21 10:21       ` Hans Verkuil
2018-01-21 10:21         ` Hans Verkuil
2018-01-21 10:23         ` Hans Verkuil [this message]
2018-01-21 10:23           ` Hans Verkuil
2018-01-21 17:29           ` jacopo mondi
2018-01-21 17:29             ` jacopo mondi
2018-01-22  9:56             ` Hans Verkuil
2018-01-22  9:56               ` Hans Verkuil
2018-01-19 22:35   ` kbuild test robot
2018-01-19 22:35     ` kbuild test robot
2018-01-19 22:35     ` kbuild test robot
2018-01-20  2:11   ` kbuild test robot
2018-01-20  2:11     ` kbuild test robot
2018-01-20  2:11     ` kbuild test robot
2018-01-16 21:44 ` [PATCH v6 4/9] ARM: dts: r7s72100: Add Capture Engine Unit (CEU) Jacopo Mondi
2018-01-16 21:44   ` Jacopo Mondi
2018-01-16 21:44 ` [PATCH v6 5/9] v4l: i2c: Copy ov772x soc_camera sensor driver Jacopo Mondi
2018-01-16 21:44   ` Jacopo Mondi
2018-01-16 21:44 ` [PATCH v6 6/9] media: i2c: ov772x: Remove soc_camera dependencies Jacopo Mondi
2018-01-16 21:44   ` Jacopo Mondi
2018-01-19 10:24   ` Hans Verkuil
2018-01-19 10:24     ` Hans Verkuil
     [not found]     ` <d67c21e5-2488-977b-39d8-561048409209-qWit8jRvyhVmR6Xm/wNWPw@public.gmane.org>
2018-01-19 10:47       ` Hans Verkuil
2018-01-19 10:47         ` Hans Verkuil
2018-01-19 10:47         ` Hans Verkuil
2018-01-19 11:19         ` Sakari Ailus
2018-01-19 11:19           ` Sakari Ailus
2018-01-19 11:44           ` Hans Verkuil
2018-01-19 11:44             ` Hans Verkuil
     [not found]           ` <20180119111917.76wosrokgracbdrz-S+BSfZ9RZZmRSg0ZkenSGLdO1Tsj/99ntUK59QYPAWc@public.gmane.org>
2018-01-19 12:23             ` Laurent Pinchart
2018-01-19 12:23               ` Laurent Pinchart
2018-01-19 12:23               ` Laurent Pinchart
2018-01-21  9:31               ` jacopo mondi
2018-01-21  9:31                 ` jacopo mondi
2018-01-21 10:18                 ` Hans Verkuil
2018-01-21 10:18                   ` Hans Verkuil
2018-01-16 21:44 ` [PATCH v6 7/9] v4l: i2c: Copy tw9910 soc_camera sensor driver Jacopo Mondi
2018-01-16 21:44   ` Jacopo Mondi
2018-01-16 21:45 ` [PATCH v6 8/9] media: i2c: tw9910: Remove soc_camera dependencies Jacopo Mondi
2018-01-16 21:45   ` Jacopo Mondi
2018-01-16 21:45 ` [PATCH v6 9/9] arch: sh: migor: Use new renesas-ceu camera driver Jacopo Mondi
2018-01-16 21:45   ` Jacopo Mondi
2018-01-19 11:26 ` [PATCH v6 0/9] Renesas Capture Engine Unit (CEU) V4L2 driver Hans Verkuil
2018-01-19 11:26   ` Hans Verkuil
     [not found]   ` <6fcd22c1-19a5-e0b7-2b00-961e1cd1ebaa-qWit8jRvyhVmR6Xm/wNWPw@public.gmane.org>
2018-01-21 17:49     ` jacopo mondi
2018-01-21 17:49       ` jacopo mondi
2018-01-21 17:49       ` jacopo mondi
2018-01-22 10:00       ` Hans Verkuil
2018-01-22 10:00         ` Hans Verkuil
2018-01-22 10:00         ` Hans Verkuil
2018-01-19 22:12 ` Randy Dunlap
2018-01-19 22:12   ` Randy Dunlap
2018-01-21 17:54   ` jacopo mondi
2018-01-21 17:54     ` jacopo mondi
2018-01-21 18:04     ` Randy Dunlap
2018-01-21 18:04       ` Randy Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e9623e9c-6444-2531-62c0-feed622c6e3b@xs4all.nl \
    --to=hverkuil@xs4all.nl \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=geert@glider.be \
    --cc=jacopo+renesas@jmondi.org \
    --cc=jacopo@jmondi.org \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=linux-sh@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    --cc=mark.rutland@arm.com \
    --cc=mchehab@kernel.org \
    --cc=pombredanne@nexb.com \
    --cc=robh+dt@kernel.org \
    --cc=sakari.ailus@iki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.