From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,
	HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,
	USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id A69DEC433E0
	for <linux-kernel@archiver.kernel.org>; Mon, 15 Feb 2021 19:23:23 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by mail.kernel.org (Postfix) with ESMTP id 6E51B64DF4
	for <linux-kernel@archiver.kernel.org>; Mon, 15 Feb 2021 19:23:23 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S230489AbhBOTXW (ORCPT <rfc822;linux-kernel@archiver.kernel.org>);
        Mon, 15 Feb 2021 14:23:22 -0500
Received: from mx3.molgen.mpg.de ([141.14.17.11]:58475 "EHLO mx1.molgen.mpg.de"
        rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP
        id S230163AbhBOTXU (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 15 Feb 2021 14:23:20 -0500
Received: from [192.168.0.6] (ip5f5aea9d.dynamic.kabel-deutschland.de [95.90.234.157])
        (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
        (No client certificate requested)
        (Authenticated sender: pmenzel)
        by mx.molgen.mpg.de (Postfix) with ESMTPSA id 569EB20647913;
        Mon, 15 Feb 2021 20:22:35 +0100 (CET)
From:   Paul Menzel <pmenzel@molgen.mpg.de>
Subject: smpboot: CPU numbers printed as warning
To:     Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        x86@kernel.org
Cc:     LKML <linux-kernel@vger.kernel.org>, it+linux-x86@molgen.mpg.de,
        Petr Mladek <pmladek@suse.com>,
        Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Message-ID: <e964b2ae-7a15-a510-e76a-56d704949d62@molgen.mpg.de>
Date:   Mon, 15 Feb 2021 20:22:34 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.7.1
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Dear Linux folks,


Using Linux 5.10.13 (and before), looking at the Linux kernel warnings, 
the CPU numbers show up. For example with 12 cpus/threads:

```
$ sudo dmesg --level=warn
[    0.216103]   #2
[    0.220105]   #3
[    0.224103]   #4
[    0.228104]   #5
[    0.232110]   #6
[    0.236101]   #7
[    0.240102]   #8
[    0.244102]   #9
[    0.248100]  #10
[    0.252098]  #11
```

If I am not mistaken, this is from `announce_cpu()` in 
`arch/x86/kernel/smpboot.c`, and the `pr_cont()` in their “forgets” the 
log level it belongs to, maybe because of SMP and other messages are 
printed in between.

```
         if (system_state < SYSTEM_RUNNING) {
                 if (node != current_node) {
                         if (current_node > (-1))
                                 pr_cont("\n");
                         current_node = node;

                         printk(KERN_INFO ".... node %*s#%d, CPUs:  ",
                                node_width - num_digits(node), " ", node);
                 }

                 /* Add padding for the BSP */
                 if (cpu == 1)
                         pr_cont("%*s", width + 1, " ");

                 pr_cont("%*s#%d", width - num_digits(cpu), " ", cpu);

         } else
                 pr_info("Booting Node %d Processor %d APIC 0x%x\n",
                         node, cpu, apicid);
```

Would using `pr_info()` instead be an acceptable fix?


Kind regards,

Paul