From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
To: Thomas Monjalon <thomas@monjalon.net>, dev@dpdk.org
Cc: stable@dpdk.org, Anatoly Burakov <anatoly.burakov@intel.com>,
Ferruh Yigit <ferruh.yigit@intel.com>,
Liron Himi <lironh@marvell.com>,
Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [dpdk-dev] [PATCH 1/1] ethdev: fix handling of close failure
Date: Mon, 25 Jan 2021 12:13:11 +0300 [thread overview]
Message-ID: <e96f6ae7-0be7-5ad7-dd8c-f731d7443b54@oktetlabs.ru> (raw)
In-Reply-To: <20210122175804.772207-1-thomas@monjalon.net>
On 1/22/21 8:58 PM, Thomas Monjalon wrote:
> If a failure happens when closing a port,
> it was unnecessarily failing again in the function eth_err(),
> because of a check against HW removal cause.
> Indeed there is a big chance the port is released at this point.
> Given the port is in the middle (or at the end) of a close process,
> checking the error cause by accessing the port is a non-sense.
> The error check is replaced by a simple return in the close function.
>
> Bugzilla ID: 624
> Fixes: 8a5a0aad5d3e ("ethdev: allow close function to return an error")
> Cc: stable@dpdk.org
>
> Reported-by: Anatoly Burakov <anatoly.burakov@intel.com>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
Acked-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
next prev parent reply other threads:[~2021-01-25 9:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-22 17:58 [dpdk-dev] [PATCH 1/1] ethdev: fix handling of close failure Thomas Monjalon
2021-01-25 9:13 ` Andrew Rybchenko [this message]
2021-01-25 12:37 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
2021-01-25 12:39 ` Thomas Monjalon
2021-01-27 11:44 ` Ferruh Yigit
2021-01-25 10:51 ` [dpdk-dev] " Burakov, Anatoly
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e96f6ae7-0be7-5ad7-dd8c-f731d7443b54@oktetlabs.ru \
--to=andrew.rybchenko@oktetlabs.ru \
--cc=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=lironh@marvell.com \
--cc=stable@dpdk.org \
--cc=stephen@networkplumber.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.