From: Arnaud Ferraris <arnaud.ferraris@collabora.com>
To: Gabriel Krisman Bertazi <krisman@collabora.com>
Cc: linux-ext4@vger.kernel.org, drosen@google.com,
ebiggers@kernel.org, tytso@mit.edu
Subject: Re: [PATCH RESEND v2 06/12] e2fsck: Fix entries with invalid encoded characters
Date: Tue, 15 Dec 2020 18:16:44 +0100 [thread overview]
Message-ID: <e991ad61-684b-8d40-8af6-ddf341ba44c2@collabora.com> (raw)
In-Reply-To: <87360d2xm9.fsf@collabora.com>
Hi Gabriel,
Le 10/12/2020 à 21:51, Gabriel Krisman Bertazi a écrit :
> Arnaud Ferraris <arnaud.ferraris@collabora.com> writes:
>
>> From: Gabriel Krisman Bertazi <krisman@collabora.com>
>>
>> @@ -1483,11 +1520,7 @@ skip_checksum:
>> if (check_filetype(ctx, dirent, ino, &cd->pctx))
>> dir_modified++;
>>
>> - if (dir_encpolicy_id == NO_ENCRYPTION_POLICY) {
>> - /* Unencrypted directory */
>> - if (check_name(ctx, dirent, &cd->pctx))
>> - dir_modified++;
>> - } else {
>> + if (dir_encpolicy_id != NO_ENCRYPTION_POLICY) {
>> /* Encrypted directory */
>> if (dot_state > 1 &&
>> check_encrypted_dirent(ctx, dirent,
>> @@ -1497,6 +1530,14 @@ skip_checksum:
>> dir_modified++;
>> goto next;
>> }
>> + } else if (cf_dir) {
>> + /* Casefolded directory */
>> + if (encoded_check_name(ctx, dirent, &cd->pctx))
>> + dir_modified++;
>> + } else {
>> + /* Unencrypted and uncasefolded directory */
>> + if (check_name(ctx, dirent, &cd->pctx))
>> + dir_modified++;
>> }
>
> This won't do for encrypted+casefolded directories, right?
Indeed, as encrypted+casefolded isn't supported right now, it's just a
re-arrangement to ease future support, as suggested by Eric.
Arnaud
>
>>
>> if (dx_db) {
>
next prev parent reply other threads:[~2020-12-15 17:18 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-10 15:03 [PATCH RESEND v2 00/12] e2fsprogs: improve case-insensitive fs Arnaud Ferraris
2020-12-10 15:03 ` [PATCH RESEND v2 01/12] tune2fs: Allow enabling casefold feature after fs creation Arnaud Ferraris
2021-01-27 22:42 ` Theodore Ts'o
2020-12-10 15:03 ` [PATCH RESEND v2 02/12] tune2fs: Fix casefold+encrypt error message Arnaud Ferraris
2021-01-27 22:46 ` Theodore Ts'o
2020-12-10 15:03 ` [PATCH RESEND v2 03/12] ext2fs: Add method to validate casefolded strings Arnaud Ferraris
2021-01-28 2:48 ` Theodore Ts'o
2020-12-10 15:03 ` [PATCH RESEND v2 04/12] ext2fs: Implement faster CI comparison of strings Arnaud Ferraris
2021-01-28 2:49 ` Theodore Ts'o
2020-12-10 15:03 ` [PATCH RESEND v2 05/12] e2fsck: add new problem for casefolded name check Arnaud Ferraris
2020-12-10 20:36 ` Gabriel Krisman Bertazi
2020-12-10 20:38 ` Gabriel Krisman Bertazi
2020-12-10 15:03 ` [PATCH RESEND v2 06/12] e2fsck: Fix entries with invalid encoded characters Arnaud Ferraris
2020-12-10 20:51 ` Gabriel Krisman Bertazi
2020-12-15 17:16 ` Arnaud Ferraris [this message]
2020-12-10 15:03 ` [PATCH RESEND v2 07/12] e2fsck: Support casefold directories when rehashing Arnaud Ferraris
2020-12-10 20:53 ` Gabriel Krisman Bertazi
2020-12-15 17:17 ` Arnaud Ferraris
2020-12-15 17:34 ` Gabriel Krisman Bertazi
2020-12-10 15:03 ` [PATCH RESEND v2 08/12] dict: Support comparison with context Arnaud Ferraris
2020-12-10 15:03 ` [PATCH RESEND v2 09/12] e2fsck: Detect duplicated casefolded direntries for rehash Arnaud Ferraris
2020-12-10 15:03 ` [PATCH RESEND v2 10/12] e2fsck: Add option to force encoded filename verification Arnaud Ferraris
2020-12-10 20:48 ` Gabriel Krisman Bertazi
2020-12-10 15:03 ` [PATCH RESEND v2 11/12] e2fsck.8.in: Document check_encoding extended option Arnaud Ferraris
2020-12-10 15:03 ` [PATCH RESEND v2 12/12] tests: f_bad_fname: Test fixes of invalid filenames and duplicates Arnaud Ferraris
2021-01-28 2:52 ` [PATCH RESEND v2 00/12] e2fsprogs: improve case-insensitive fs Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e991ad61-684b-8d40-8af6-ddf341ba44c2@collabora.com \
--to=arnaud.ferraris@collabora.com \
--cc=drosen@google.com \
--cc=ebiggers@kernel.org \
--cc=krisman@collabora.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.